Fixed
Status Update
Comments
si...@gmail.com <si...@gmail.com> #2
Looks like we're incorrectly using 0 as the placeholder value for 'no popUpTo was set' when in fact 0 is a valid value - the value of the root of the graph when no ID is set. We'll switch to a popUpTo of -1 as that default value.
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 58cb7bb9e314406b30414b4198cba9d0d13256cb
Author: Ian Lake <ilake@google.com>
Date: Mon Feb 25 15:33:39 2019
Fix popUpTo with the root graph ID of 0
All navigation nodes must have a valid ID
*except* the root of the navigation graph, which
can have a ID of 0. We should still be able to
popUpTo the root of the graph by using
popUpTo on a navigate() option, so we need to change
the default value from 0 to -1.
Test: new NavControllerTest
Fixes: 126251695
Change-Id: Iac3ac25abdb91562753db25ff09d23bec7f46292
M navigation/common/ktx/src/main/java/androidx/navigation/NavOptionsBuilder.kt
M navigation/common/src/main/java/androidx/navigation/NavOptions.java
M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
https://android-review.googlesource.com/912257
https://goto.google.com/android-sha1/58cb7bb9e314406b30414b4198cba9d0d13256cb
Branch: androidx-master-dev
commit 58cb7bb9e314406b30414b4198cba9d0d13256cb
Author: Ian Lake <ilake@google.com>
Date: Mon Feb 25 15:33:39 2019
Fix popUpTo with the root graph ID of 0
All navigation nodes must have a valid ID
*except* the root of the navigation graph, which
can have a ID of 0. We should still be able to
popUpTo the root of the graph by using
popUpTo on a navigate() option, so we need to change
the default value from 0 to -1.
Test: new NavControllerTest
Fixes: 126251695
Change-Id: Iac3ac25abdb91562753db25ff09d23bec7f46292
M navigation/common/ktx/src/main/java/androidx/navigation/NavOptionsBuilder.kt
M navigation/common/src/main/java/androidx/navigation/NavOptions.java
M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
il...@google.com <il...@google.com> #4
This is fixed for Navigation 1.0.0-rc02
si...@gmail.com <si...@gmail.com> #5
Awesome, thanks for the quick merge 😀
na...@google.com <na...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-alpha01
androidx.navigation:navigation-ui:2.8.0-alpha01
si...@gmail.com <si...@gmail.com> #7
I can confirm the issue reported here is fixed in 2.8.0-alpha01
.
Not sure why there is no mention of it in the release notes though.
I should have added a RelNotes
trailer to the git commit message, or can it be added afterwards?
il...@google.com <il...@google.com> #8
You would have had to add a Relnote
if you wanted it mentioned in the release notes, yes.
We can manually add it to the release notes though.
si...@gmail.com <si...@gmail.com> #9
Understood!
We can manually add it to the release notes though.
It's up to you to decide if it's worth mentioning :)
il...@google.com <il...@google.com> #10
We've added it to the
ju...@gmail.com <ju...@gmail.com> #11
juma
Description
androidx.navigation:navigation-*:2.6.0
and aboveThis commit b1ac7d6 introduced a regression in how the title is dynamically rendered, and more precisely how the
Bundle
containing parameters is accessed.Previously, it used the default
Bundle.get(key)
method:But after this commit, it now uses
Bundle.getString(key)
:Unfortunately, this breaks basic usage, with other types than
String
, sinceBundle.getString(key)
will returnnull
.Here is a very simple example:
Previously it would have correctly set the title to
"Album #42"
(for example).But since this update, it will render
"Album #null"
!