Status Update
Comments
si...@gmail.com <si...@gmail.com> #2
Branch: androidx-main
commit b17204359581a71c427d7519a6cfc1825141ed72
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Mar 17 21:47:24 2023
Prevent crash when adding unmanaged fragment in nav
Currently, if you attempt to add a fragment to the fragment manager
associated with the FragmentNavigator, navigation crashes as it cannot
find an entry associated with fragment.
While it is strongly recommended to only use navigation APIs to
manipulate the fragment manager, if the back stack is not affected, then
we should not crash.
RelNote: "Adding fragments to the `FragmentNavigator`'s
`FragmentManager` without using navigation will no longer crash."
Test: Added FragmentNavigatorTest
Bug: 274167493
Change-Id: I47d4c75ca46ee7f8282b2a7b97d28d71edd9a07b
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #3
This has been fixed internally and will be in the Navigation 2.6.0-alpha08
release.
il...@google.com <il...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.6.0-alpha08
si...@gmail.com <si...@gmail.com> #5
Awesome, thanks for the quick merge 😀
na...@google.com <na...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-alpha01
androidx.navigation:navigation-ui:2.8.0-alpha01
si...@gmail.com <si...@gmail.com> #7
I can confirm the issue reported here is fixed in 2.8.0-alpha01
.
Not sure why there is no mention of it in the release notes though.
I should have added a RelNotes
trailer to the git commit message, or can it be added afterwards?
il...@google.com <il...@google.com> #8
You would have had to add a Relnote
if you wanted it mentioned in the release notes, yes.
We can manually add it to the release notes though.
si...@gmail.com <si...@gmail.com> #9
Understood!
We can manually add it to the release notes though.
It's up to you to decide if it's worth mentioning :)
il...@google.com <il...@google.com> #10
We've added it to the
ju...@gmail.com <ju...@gmail.com> #11
juma
Description
androidx.navigation:navigation-*:2.6.0
and aboveThis commit b1ac7d6 introduced a regression in how the title is dynamically rendered, and more precisely how the
Bundle
containing parameters is accessed.Previously, it used the default
Bundle.get(key)
method:But after this commit, it now uses
Bundle.getString(key)
:Unfortunately, this breaks basic usage, with other types than
String
, sinceBundle.getString(key)
will returnnull
.Here is a very simple example:
Previously it would have correctly set the title to
"Album #42"
(for example).But since this update, it will render
"Album #null"
!