Fixed
Status Update
Comments
si...@gmail.com <si...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1381476
Branch: androidx-master-dev
commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #3
This has been fixed internally and will be available in the Navigation 2.4.0-alpha01 release.
il...@google.com <il...@google.com> #4
Thank you, that's great to hear. Looking forward to it.
si...@gmail.com <si...@gmail.com> #5
Project: platform/frameworks/support
Branch: snap-temp-L69500000699825513
commit 91e0659733e097aabfb5801caccbf6f40d2f4a72
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1436153
Branch: snap-temp-L69500000699825513
commit 91e0659733e097aabfb5801caccbf6f40d2f4a72
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
na...@google.com <na...@google.com> #6
Project: platform/frameworks/support
Branch: snap-temp-L62000000699827533
commit 94827a2939f3a4d2c8d08e8dc93d53330de56806
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1436736
Branch: snap-temp-L62000000699827533
commit 94827a2939f3a4d2c8d08e8dc93d53330de56806
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
si...@gmail.com <si...@gmail.com> #7
Project: platform/frameworks/support
Branch: snap-temp-L46100000699831674
commit b1fbee9fc7b04ae2cb8868774a714c134c86f865
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1436740
Branch: snap-temp-L46100000699831674
commit b1fbee9fc7b04ae2cb8868774a714c134c86f865
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
il...@google.com <il...@google.com> #8
Project: platform/frameworks/support
Branch: snap-temp-L91000000699844097
commit 81272b7a61a520f9be7803eefd58bf8143b3fd50
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1436541
Branch: snap-temp-L91000000699844097
commit 81272b7a61a520f9be7803eefd58bf8143b3fd50
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
si...@gmail.com <si...@gmail.com> #9
Project: platform/frameworks/support
Branch: snap-temp-L34200000699848945
commit 0849c43e4adbea7f96104d328f69a7c504b15ea1
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1436871
Branch: snap-temp-L34200000699848945
commit 0849c43e4adbea7f96104d328f69a7c504b15ea1
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
il...@google.com <il...@google.com> #10
Project: platform/frameworks/support
Branch: snap-temp-L04700000699849955
commit 2a048de5fbc9f21dfb785a8d015eec9c10930874
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1436748
Branch: snap-temp-L04700000699849955
commit 2a048de5fbc9f21dfb785a8d015eec9c10930874
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
ju...@gmail.com <ju...@gmail.com> #11
Project: platform/frameworks/support
Branch: snap-temp-L69500000699869549
commit f5f97b37c2bf85e50d6e819a0e2529f733e5c5c2
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
https://android-review.googlesource.com/1436413
Branch: snap-temp-L69500000699869549
commit f5f97b37c2bf85e50d6e819a0e2529f733e5c5c2
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020
override equals and hashCode for NavOptions
Lets implement these methods to simplify comparing NavOptions.
Equals method generated using studio.
Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
Description
androidx.navigation:navigation-*:2.6.0
and aboveThis commit b1ac7d6 introduced a regression in how the title is dynamically rendered, and more precisely how the
Bundle
containing parameters is accessed.Previously, it used the default
Bundle.get(key)
method:But after this commit, it now uses
Bundle.getString(key)
:Unfortunately, this breaks basic usage, with other types than
String
, sinceBundle.getString(key)
will returnnull
.Here is a very simple example:
Previously it would have correctly set the title to
"Album #42"
(for example).But since this update, it will render
"Album #null"
!