AndroidX Navigation 2.6.0 broke dynamic app bar title for non String arguments [316676794]

Fixed

Bug

Status Update

No update yet.

Description

si...@gmail.com

created issue #1

Dec 16, 2023 04:56PM

Component used: Navigation
Version used: androidx.navigation:navigation-*:2.6.0 and above
Devices/Android versions reproduced on: Not applicable

This commit b1ac7d6 introduced a regression in how the title is dynamically rendered, and more precisely how the Bundle containing parameters is accessed.

Previously, it used the default Bundle.get(key) method:

if (argType == NavType.ReferenceType) {
    val value = context.resources.getString(arguments[argName] as Int)
    title.append(value)
} else {
    title.append(arguments[argName].toString())
}

But after this commit, it now uses Bundle.getString(key):

if (argType == NavType.ReferenceType) {
    val value = context.getString(bundle.getInt(argName))
    builder.append(value)
} else {
    builder.append(bundle.getString(argName))
}

Unfortunately, this breaks basic usage, with other types than String, since Bundle.getString(key) will return null.

Here is a very simple example:

<navigation>
    <fragment android:label="Album #{albumId}">
        <argument android:name="albumId" app:argType="long" />
    </fragment>
</navigation>

Previously it would have correctly set the title to "Album #42" (for example).
But since this update, it will render "Album #null"!

Comments

si...@gmail.com <si...@gmail.com> #2Dec 16, 2023 05:20PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

il...@google.com <il...@google.com> Dec 19, 2023 09:37PM

Assigned to il...@google.com.

ap...@google.com <ap...@google.com> #3Dec 19, 2023 10:21PM

Marked as fixed.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

il...@google.com <il...@google.com> #4Dec 19, 2023 10:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

si...@gmail.com <si...@gmail.com> #5Dec 19, 2023 10:44PM

Awesome, thanks for the quick merge 😀

na...@google.com <na...@google.com> #6Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-alpha01
androidx.navigation:navigation-ui:2.8.0-alpha01

si...@gmail.com <si...@gmail.com> #7Jan 27, 2024 11:57AM

I can confirm the issue reported here is fixed in 2.8.0-alpha01. Not sure why there is no mention of it in the release notes though. I should have added a RelNotes trailer to the git commit message, or can it be added afterwards?

il...@google.com <il...@google.com> #8Jan 31, 2024 12:08AM

You would have had to add a Relnote if you wanted it mentioned in the release notes, yes.

We can manually add it to the release notes though.

si...@gmail.com <si...@gmail.com> #9Feb 3, 2024 09:01AM

Understood!

We can manually add it to the release notes though.

It's up to you to decide if it's worth mentioning :)

il...@google.com <il...@google.com> #10Feb 5, 2024 10:58PM

We've added it to the 2.8.0-alpha01 release notes. Thanks again for the contribution!

ju...@gmail.com <ju...@gmail.com> #11Dec 2, 2024 05:47PM

juma