Fixed
Status Update
Comments
si...@gmail.com <si...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
il...@google.com <il...@google.com> #4
Opening diff shortly
si...@gmail.com <si...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
na...@google.com <na...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-alpha01
androidx.navigation:navigation-ui:2.8.0-alpha01
si...@gmail.com <si...@gmail.com> #7
I can confirm the issue reported here is fixed in 2.8.0-alpha01
.
Not sure why there is no mention of it in the release notes though.
I should have added a RelNotes
trailer to the git commit message, or can it be added afterwards?
il...@google.com <il...@google.com> #8
You would have had to add a Relnote
if you wanted it mentioned in the release notes, yes.
We can manually add it to the release notes though.
si...@gmail.com <si...@gmail.com> #9
Understood!
We can manually add it to the release notes though.
It's up to you to decide if it's worth mentioning :)
il...@google.com <il...@google.com> #10
We've added it to the
ju...@gmail.com <ju...@gmail.com> #11
juma
Description
androidx.navigation:navigation-*:2.6.0
and aboveThis commit b1ac7d6 introduced a regression in how the title is dynamically rendered, and more precisely how the
Bundle
containing parameters is accessed.Previously, it used the default
Bundle.get(key)
method:But after this commit, it now uses
Bundle.getString(key)
:Unfortunately, this breaks basic usage, with other types than
String
, sinceBundle.getString(key)
will returnnull
.Here is a very simple example:
Previously it would have correctly set the title to
"Album #42"
(for example).But since this update, it will render
"Album #null"
!