Migrate Lifecycle Common/Runtime to multiplatform [317249252]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

Dec 20, 2023 07:32PM

It would be nice if the core concepts of Lifecycle would be available for use in Kotlin Multiplatform projects.

Libraries like the Navigation Component, Fragments, etc. have all settled on the same definitions of Lifecycle States, which seem to apply to any UI:

CREATED - created, but not yet visible
STARTED - visible, but not yet settled (e.g., entering or exiting transitions may still be running)
RESUMED - visible and settled

This would include:

And ideally everything in the lifecycle-common and lifecycle-runtime artifacts.

Comments

il...@google.com <il...@google.com> Jan 23, 2024 09:23PM

Assigned to mg...@google.com.

il...@google.com <il...@google.com> #2Jan 30, 2024 11:09PM

The first CL of this effort has been officially submitted in aosp/2926690, adding multiplatform support to lifecycle-common.

ap...@google.com <ap...@google.com> #3Feb 2, 2024 12:20AM

Project: platform/frameworks/support
Branch: androidx-main

commit e4a654d863af22d2a4f486b90cf29c26c487cffb
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Mon Jan 22 11:49:53 2024

Multiplatform support for lifecycle-runtime

This change introduces multiplatform support for the lifecycle-runtime module by exposing the `LifecycleRegistry` to common, ensuring compatibility with published versions on Android.

BUG: 317249252
Relnote: Added multiplatform support for `lifecycle-runtime`
Test: Run existing and newly added tests
Change-Id: I0c5acfde52bd6c4a3cf7f38193c235915b45d549

M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/MissingClassTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/src/androidMain/java/androidx/lifecycle/LifecycleRegistryOwner.java
A lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/LifecycleRegistry.android.kt
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ViewTreeLifecycleOwner.android.kt
M lifecycle/lifecycle-runtime/src/androidMain/res/values/ids.xml
M lifecycle/lifecycle-runtime/src/androidUnitTest/kotlin/NoPackageObserver.kt
M lifecycle/lifecycle-runtime/src/androidUnitTest/kotlin/NoPackageTest.kt
M lifecycle/lifecycle-runtime/src/androidUnitTest/kotlin/androidx/lifecycle/LifecycleRegistryTest.java
A lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/LifecycleRegistry.kt
A lifecycle/lifecycle-runtime/src/commonTest/kotlin/androidx/lifecycle/CommonLifecycleRegistryTest.kt
A lifecycle/lifecycle-runtime/src/commonTest/kotlin/androidx/lifecycle/TestObserver.kt
A lifecycle/lifecycle-runtime/src/desktopMain/kotlin/androidx/lifecycle/LifecycleRegistry.desktop.kt
M lifecycle/lifecycle-runtime/src/jvmMain/kotlin/androidx/lifecycle/LifecycleRegistry.jvm.kt
M lifecycle/lifecycle-runtime/src/nativeMain/kotlin/androidx/lifecycle/LifecycleRegistry.native.kt
A lifecycle/lifecycle-runtime/src/nativeTest/kotlin/androidx/lifecycle/NativeLifecycleRegistryTest.kt
M settings.gradle

https://android-review.googlesource.com/2927699

mg...@google.com <mg...@google.com> #4Feb 2, 2024 04:31PM

The second CL of this effort has been officially submitted in aosp/2927699, adding multiplatform support to lifecycle-runtime.

ap...@google.com <ap...@google.com> #5Feb 6, 2024 09:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 08f40110a0400fa434ed023e763152e6f4aa39af
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Fri Jan 26 17:06:51 2024

Multiplatform support for lifecycle-runtime-ktx

BUG: 317249252
Relnote: Added multiplatform support for `lifecycle-runtime-ktx`
Test: Run existing tests
Change-Id: If445d68e7e85929839ad10347b31b9f11d61c00d

M lifecycle/lifecycle-runtime-ktx/build.gradle
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FakeLifecycleOwner.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FlowWithLifecycleTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/LaunchWhenTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/RepeatOnLifecycleTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TaskTracker.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TrackedExecutor.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/WithLifecycleStateTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-runtime-ktx/src/androidMain/kotlin/androidx/lifecycle/View.android.kt
M lifecycle/lifecycle-runtime-ktx/src/commonMain/kotlin/androidx/lifecycle/FlowExt.kt
M lifecycle/lifecycle-runtime-ktx/src/commonMain/kotlin/androidx/lifecycle/RepeatOnLifecycle.kt
M lifecycle/lifecycle-runtime-ktx/src/commonMain/kotlin/androidx/lifecycle/WithLifecycleState.kt
M settings.gradle

https://android-review.googlesource.com/2930012

mg...@google.com <mg...@google.com> Feb 14, 2024 03:27PM

Marked as fixed.

ap...@google.com <ap...@google.com> #6Mar 8, 2024 11:29AM

Project: platform/frameworks/support
Branch: androidx-main

commit d48a756bfcbc4679bbcf641554f75be5458cad04
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Mon Mar 04 22:55:59 2024

Align source sets in lifecycle-runtime with JetBrains fork

- Move shared code into `nonJvmMain` (a common source set for native and web targets)
- Use expect/actual for `WeakReference` and `isMainThread`

Bug: 317249252
Test: N/A
Change-Id: If70f6aa691d231674a7e3234a668e4b8184f2d91

M development/build_log_simplifier/messages.ignore
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/nativeMain/kotlin/androidx/lifecycle/LifecycleRegistry.native.kt
A lifecycle/lifecycle-runtime/src/nativeMain/kotlin/androidx/lifecycle/WeakReference.native.kt
A lifecycle/lifecycle-runtime/src/nonJvmMain/kotlin/androidx/lifecycle/LifecycleRegistry.nonJvm.kt
A lifecycle/lifecycle-runtime/src/nonJvmMain/kotlin/androidx/lifecycle/WeakReference.nonJvm.kt

https://android-review.googlesource.com/2986215

ap...@google.com <ap...@google.com> #7Mar 8, 2024 11:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit 1b02695fac60c198985910d0a4658a3f53027f35
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Mon Mar 04 22:08:16 2024

Align source sets in lifecycle-common with JetBrains fork

- Move shared code into `nonJvmMain` (a common source set for native and web targets)

Bug: 317249252
Test: N/A
Change-Id: If7e05abc26e53d93f1b853941687602093576cc5

M lifecycle/lifecycle-common/build.gradle
M lifecycle/lifecycle-common/src/nonJvmMain/kotlin/androidx/lifecycle/Lifecycle.nonJvm.kt
M lifecycle/lifecycle-common/src/nonJvmMain/kotlin/androidx/lifecycle/Lifecycling.nonJvm.kt

https://android-review.googlesource.com/2986214

pr...@google.com <pr...@google.com> #8Mar 20, 2024 08:26PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-common:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-iosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-iossimulatorarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-iosx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-jvm:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-linuxx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-macosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-macosx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-android:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-desktop:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-iosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-iossimulatorarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-iosx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-linuxx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-macosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-macosx64:2.8.0-alpha03