IssueTracker

How should this work "else if (parent instanceof BottomSheetDialogFragment)"?

Yeah, I just realized that it's not as simple as in the case of the DrawerLayout. When using a DrawerLayout, people mostly have something like this:

<android.support.v4.widget.DrawerLayout xmlns:android="http://schemas.android.com/apk/res/android"
                                        xmlns:app="http://schemas.android.com/apk/res-auto"
                                        android:id="@+id/drawer_layout"
                                        android:layout_width="match_parent"
                                        android:layout_height="match_parent"
                                        android:fitsSystemWindows="true">

    <FrameLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:id="@+id/header_container"/>

    <android.support.design.widget.NavigationView
        android:id="@+id/nav_view"
        android:layout_width="wrap_content"
        android:layout_height="match_parent"
        android:layout_gravity="start"
        app:headerLayout="@layout/main_nav_header"
        android:fitsSystemWindows="true"
        app:menu="@menu/main_drawercontent"/>

</android.support.v4.widget.DrawerLayout>

Obviously here the NavigationView is a direct child of the DrawerLayout, which is why the implementation we already have for handling the closing of the navigation drawer works like it does, by checking the NavigationView's parent.
But when using a BottomSheetDialogFragment, we can't rely on the NavigationView being a direct child of the BottomSheetDialogFragment. Since it's mostly a regular Fragment, people may use a layout like this (simplified):

<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".view.BottomDrawerFragment">

    <!-- Here we'd have views typically found in the navigation drawer,
         such as a user profile picture or their name -->

    <com.google.android.material.navigation.NavigationView
        android:id="@+id/bottom_drawer_navigation"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_gravity="bottom"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/divider"
        app:menu="@menu/bottom_drawer_menu" />
</androidx.constraintlayout.widget.ConstraintLayout>

My suggestion wouldn't work with this, as the NavigationView's parent is not the BottomSheetDialogFragment, but the ConstraintLayout. So we can't use the parent to detect when we should dismiss a BottomSheetDialogFragment.

A potential solution would probably have to use a different approach. Maybe in setupWithNavController() you could pass a reference to the BottomSheetDialogFragment directly, in addition to the NavigationView and NavController. Something similar happens already, for example when using a Toolbar that should be kept in sync also, the method call is NavigationUI.setupWithNavController(collapsingToolbarLayout, toolbar, navController) for that.
So we could end up having an implementation of setupWithNavController just for our case with the BottomSheetDialogFragment that goes something like this:

public static void setupWithNavController(
        @NonNull BottomSheetDialogFragment bottomSheetDialogFragment,
        @NonNull final NavigationView navigationView,
        @NonNull final NavController navController) {
    navigationView.setNavigationItemSelectedListener(
            new NavigationView.OnNavigationItemSelectedListener() {
                @Override
                public boolean onNavigationItemSelected(@NonNull MenuItem item) {
                    boolean handled = onNavDestinationSelected(item, navController, true);
                    if (handled) {
                        bottomSheetDialogFragment.dismiss();
                    }
                    return handled;
                }
            });
    final WeakReference<NavigationView> weakReference = new WeakReference<>(navigationView);
    navController.addOnNavigatedListener(new NavController.OnNavigatedListener() {
        @Override
        public void onNavigated(@NonNull NavController controller,
                @NonNull NavDestination destination) {
            NavigationView view = weakReference.get();
            if (view == null) {
                controller.removeOnNavigatedListener(this);
                return;
            }
            Menu menu = view.getMenu();
            for (int h = 0, size = menu.size(); h < size; h++) {
                MenuItem item = menu.getItem(h);
                item.setChecked(matchDestination(destination, item.getItemId()));
            }
        }
    });
}

And we'd use it in our example like so:

public class BottomDrawerFragment extends BottomSheetDialogFragment {
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.fragment_bottom_drawer, container, false);
        NavigationView navigationView = view.findViewById(R.id.bottom_drawer_navigation);
        NavigationUI.setupWithNavController(this, navigationView, Navigation.findNavController(getActivity(), R.id.nav_host_fragment));
        return view;
    }
}

You nailed it man. Thanks for your investigation!

Are there any cases where you'd have a NavigationView in a BottomSheet of any type and not expect the bottom sheet to be hidden when you tap on a NavigationView item?

If you'd always expect it to be hidden, we could use BottomSheetBehavior.from(navigationView) to find the bottom sheet, avoiding the need to create another setup method.

Not that I can think of. According to the Material Design spec, there are standard bottom sheets which remain open while the user interacts with the main UI region or the sheet itself, and modal bottom sheets which must be dismissed to interact with the underlying content.
Examples for standard bottom sheets are playback controls inside a music player or the location information in Google Maps, while modal bottom sheets provide a set of choices and are an alternative to inline menus.

This makes it pretty clear that modal bottom sheets should be used for any kind of menu, and modal bottom sheets are always dismissed by tapping a menu item or action. That being said, it's not unlikely that someone is going to use a NavigationView inside a standard bottom sheet at some point. While the spec doesn't explicitly prohibit that, it's clearly not the intention, so I wouldn't consider this case in the implementation.

With that in mind, I think using BottomSheetBehavior.from(navigationView) is a good solution.

Fixed in https://android-review.googlesource.com/c/platform/frameworks/support/+/743749

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 43e060b8c23a7163673f77ee42e5a1e3cb1f7c14
Author: Ian Lake <ilake@google.com>
Date:   Fri Aug 31 14:11:51 2018

    Close bottom sheets when tapping a NavigationView
   
    When a NavigationView is contained within a bottom
    sheet (such as is the case for the common
    BottomAppBar use case), tapping on a menu item that
    navigates to a destination will also hide the
    bottom sheet.
   
    Test: manual testing
    Change-Id: Ia6cf92288988fe160ffd1136de417066b33377f2
    Fixes: 112158843

M       navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java

https://android-review.googlesource.com/743749
https://goto.google.com/android-sha1/43e060b8c23a7163673f77ee42e5a1e3cb1f7c14

Nicely done, works just as expected. Thank you!

Is it possible to see when I can use this code officially?

It'll be part of the upcoming 1.0.0-alpha06 release.

Can you show me your CustomBottomSheetDialofFragment and the associated layout please. I get the error message "The view is not a child of CoordinatorLayout".

This is what would work if you use a simple bottom sheet layout with a ConstraintLayout as root view as pointed out in comment #3:

                           if (parent instanceof DrawerLayout) {
                                ((DrawerLayout) parent).closeDrawer(navigationView);
                            } else {
                                BottomSheetBehavior bottomSheetBehavior =
                                        BottomSheetBehavior.from((View) navigationView.getParent().getParent());
                                if (bottomSheetBehavior != null) {
                                    bottomSheetBehavior.setState(BottomSheetBehavior.STATE_HIDDEN);
                                }
                            }

but only

                                BottomSheetBehavior bottomSheetBehavior =
                                        BottomSheetBehavior.from(navigationView);

would expect, that the navigationView is a direct child of a CoordinatorLayout and would have the app:layout_behavior="com.google.android.material.bottomsheet.BottomSheetBehavior" attribute. That can't work or did I miss something?

Yeah, we should avoid BottomSheetBehavior.from()'s overzealous throwing of exceptions and handle cases like BottomSheetDialogFragment where the NavigationView is a few layers below the CoordinatorLayout.

Thanks for catching the oversight! The new code should work considerably better for other bottom sheet cases without the IllegalArgumentExceptions :)

Project: platform/frameworks/support
Branch: androidx-main

commit 59dd212495f4378911cbb310367743b2aae734a3
Author: Marcello Galhardo <mgalhardo@google.com>
Date:   Wed May 29 17:49:02 2024

    Make `LocalLifecycleOwner` backward compatible with Compose 1.6.*
   
    Lifecycle 2.8.* requires Compose 1.7.* for correctness, but
     Compose 1.7.* have not yet reached stable.
   
    For allowing Lifecycle 2.8.* to be used with Compose 1.6.*, we are
     introducing the following measures:
    * When Lifecycle 2.8.* detects it's running with Compose 1.6.*, it
     uses reflection to access the previous version of
     `androidx.compose.ui.platform.LocalLifecycleOwner`.
    * A custom Proguard rule has been added to prevent the obfuscation of
     `androidx.compose.ui.platform.LocalLifecycleOwner` when using
     Compose 1.6.*. This ensures the reflection approach works correctly.
   
    We have tested these backward compatibility measures in various
    scenarios, including:
    * Projects with and without Navigation Compose integrated.
    * Compose versions 1.6.* and 1.7.*.
    * Builds both with and without Proguard obfuscation applied.
   
    Please note that backward compatibility reflection will be removed once
     Compose 1.7.* is stable. A Gradle dependency constraint should be
     put in place to ensure smooth migration for clients.
   
    Fixes: b/336842920
    Test: manual
    Change-Id: I3d0666a88eb309aae9a5c60eacc6818f52dd0bfd

M       lifecycle/lifecycle-runtime-compose/build.gradle
A       lifecycle/lifecycle-runtime-compose/proguard-rules.pro
A       lifecycle/lifecycle-runtime-compose/src/androidMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.android.kt
M       lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.kt
A       lifecycle/lifecycle-runtime-compose/src/desktopMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.desktop.kt

https://android-review.googlesource.com/3105647

Last stable version is 2.7.0

I have updated to 2.8.2, and everything works when building debug. However, if I build the release with ProGuard, it still crashes with the error "CompositionLocal LocalLifecycleOwner not present".

the same, in 2.8.2 it's still crashing on release builds, debug builds are ok

Same for me, version 2.8.2. debug builds is ok, release crashes

Same problem for me.
Updating to 2.8.2 with Compose BOM "2024.06.00" the app is crashing on Release build with the error "CompositionLocal LocalLifecycleOwner not present".
A proguard rules should be provided or another version with fix.

I can confirm, that the issue persists on the 2.8.2 version in the release build.

However, for the visitors

"-keep class androidx.compose.ui.platform.AndroidCompositionLocals_androidKt { *; }"

Add this to your app proguard file and it'll work fine.