Status Update
Comments
se...@google.com <se...@google.com>
pe...@gmail.com <pe...@gmail.com> #2
Would love to know if you found a workaround for this.
64...@gmail.com <64...@gmail.com> #3
#2 i didn't have the chance to investigate on a workaround sadly, let me know if you do find some way :)
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #4
Branch: androidx-main
commit 6408e12a00fe573586bf1f052317ad7a4868e8a3
Author: Jose Figueroa <serniebanders@google.com>
Date: Fri May 10 10:17:32 2024
Update status and nav bar icons to respond to system dark theme status.
Note: new style res have been moved under androidMain
Bug: 338342149
Test: Manual
Relnote: ModalBottomSheet status and nav bar icons now respond to dark theme status
Change-Id: Ie1fe7e1f792c39d52b4d419a08209c2577bf1175
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/res/values-v30/styles.xml
M compose/material3/material3/src/androidMain/res/values/styles.xml
se...@google.com <se...@google.com> #5
The updated fix here has the sheet dialog respond to system dark theme to toggle between light and dark icons. Because the dialog provides a new window it does not respect an applications theme unfortunately. Down the line we hope to split the window and sheet logic so users can customize this more thoroughly.
na...@google.com <na...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.3.0-beta02
androidx.compose.material3:material3-android:1.3.0-beta02
androidx.compose.material3:material3-desktop:1.3.0-beta02
64...@gmail.com <64...@gmail.com> #7
thanks for the fix!
gi...@spotify.com <gi...@spotify.com> #8
The fix introduced a new bug. In our app, we don't use the night mode and only have one dark theme. After upgrading to 1.3.0, whenever a bottom sheet is opened, the navigation bar turns bright, instead of staying dark. It might be better to decide, if a dark theme is used by using the current colorScheme instead of the system's night mode.
Description
description
Since the last alpha (
1.3.0-alpha06
) the bottom sheet doesn't respect the existing options of the status bar (light/dark) when fully expanded. Resulting in an unreadable statusbar when fully expanded (see sample code & screenshot).info
Jetpack Compose version:
bom 2024.05.00
/compiler 1.5.13
Material Library Version (M2, M3 or Both?):
m3 1.3.0-alpha06
Material Compose component used:
ModalBottomSheet
Android Studio Build:
#AI-241.14494.240.2411.11771556
Kotlin version:
1.9.23
code sample to reproduce: