Multiple back button presses (fast popBackStack) cause crash [338624457]

Fixed

Bug

Status Update

No update yet.

Description

kr...@gmail.com

created issue #1

May 4, 2024 01:19PM

Component used: Fragment

Versions used:

androidx.fragment:fragment:1.7.0
androidx.navigation:navigation-runtime:2.7.7
com.google.android.material:material:1.12.0

Setup in Fragment:

import com.google.android.material.transition.MaterialFadeThrough

override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    enterTransition = MaterialFadeThrough()
    exitTransition = MaterialFadeThrough()
}

Im getting this crash, when I navigate forward multiple times (navigate(FragFooDirections.actionFooBar())) and then repeatedly fast use the back gesture or back button (popBackStack()).

java.lang.IllegalStateException: setCurrentPlayTimeMillis() called after animation has been started
	at androidx.transition.Transition$SeekController.setCurrentPlayTimeMillis(Transition.java:2778)
	at androidx.transition.FragmentTransitionSupport.setCurrentPlayTime(FragmentTransitionSupport.java:265)
	at androidx.fragment.app.DefaultSpecialEffectsController$TransitionEffect.onProgress(DefaultSpecialEffectsController.kt:817)
	at androidx.fragment.app.SpecialEffectsController.processProgress(SpecialEffectsController.kt:441)
	at androidx.fragment.app.FragmentManager$1.handleOnBackProgressed(FragmentManager.java:513)
	at androidx.activity.OnBackPressedDispatcher.onBackProgressed(OnBackPressedDispatcher.kt:258)
	at androidx.activity.OnBackPressedDispatcher.access$onBackProgressed(OnBackPressedDispatcher.kt:63)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:129)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:127)
	at androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1.onBackProgressed(OnBackPressedDispatcher.kt:391)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.lambda$onBackStarted$0(WindowOnBackInvokedDispatcher.java:334)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper$$ExternalSyntheticLambda1.onProgressUpdate(D8$$SyntheticClass:0)
	at android.window.BackProgressAnimator.updateProgressValue(BackProgressAnimator.java:162)
	at android.window.BackProgressAnimator.-$$Nest$mupdateProgressValue(Unknown Source:0)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:61)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:57)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.setPropertyValue(DynamicAnimation.java:731)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.doAnimationFrame(DynamicAnimation.java:687)
	at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:344)
	at android.animation.AnimationHandler.-$$Nest$mdoAnimationFrame(Unknown Source:0)
	at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:87)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1397)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1408)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1008)
	at android.view.Choreographer.doFrame(Choreographer.java:934)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1382)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8501)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

The same happens with a SharedAxisTransition:

exitTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
reenterTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)
enterTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
returnTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)

Comments

jb...@google.com <jb...@google.com> #2May 6, 2024 03:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 66494e2d6810347e6a3b41ec3f2665e598f108f0
Author: Ian Lake <ilake@google.com>
Date: Thu Apr 14 00:14:24 2022

Ensure that SavedStateHandle restores upon initial creation

runOnNextRecreation() only runs on the next time
the lifecycle reaches CREATED, not the first time.

By using a LifecycleObserver directly, we ensure that
each Lifecycle move causes a performRestore() to
consistently happen.

Test: existing tests pass, sample app works
BUG: 228865698
Relnote: "Fixed an issue where nesting one `NavHost` within
another `NavHost` in a non-primary bottom navigation tab
would lead to an `IllegalStateException` when using
multiple back stacks."

Change-Id: I11bd5173f035ae1da7922b4142fcedc0f3b54ff6

M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt

https://android-review.googlesource.com/2064518

kr...@gmail.com <kr...@gmail.com> #3May 6, 2024 05:41PM

Thanks for quick fix! Works well with latest snapshot.

jb...@google.com <jb...@google.com> May 8, 2024 06:14PM

Assigned to jb...@google.com.

kr...@gmail.com <kr...@gmail.com> #4May 16, 2024 02:06PM

Thanks for confirming! The fix will be in the next release of Lifecycle (2.5.0-beta01).

kr...@gmail.com <kr...@gmail.com> #5Jun 13, 2024 07:19PM

2.4.1 also has same issue

using jetpack compose / bottom navigation with NavHost

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

kr...@gmail.com <kr...@gmail.com> #6Jun 27, 2024 02:11PM

I am seeing a high occurance rate with 2.5.0-beta01 as well.

th...@gmail.com <th...@gmail.com> #7Jul 5, 2024 05:22AM

Re comment#5 and comment#6 - please file a new bug with a sample project that reproduces your issue. That would help rule out it being a duplicate of this issue where your remember around getBackStackEntry needs to be updated.

ap...@google.com <ap...@google.com> #8Jul 9, 2024 08:21PM

Hi, I recently came across this crash in my current project and I discovered that it happens when a Textfield was tapped and in focus, then the app was backgrounded. This would occur with all of the Textfields in the app.

We are using Compose version: 1.2.0-rc03
and jetpack lifecycle version: 2.4.1

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

ap...@google.com <ap...@google.com> #9Jul 18, 2024 05:08AM

Please file a new bug with a minimal sample project that reproduces your error.

jb...@google.com <jb...@google.com> #10Jul 18, 2024 02:11PM

Marked as fixed, reassigned to mo...@google.com.

Okay, we will get a sample project up soon. One thing I forgot to mention in the initial comment is that this crash occurs when we use backQueue.clear() to clear the back stack. We were able to come up with a solution/workaround by using popUpTo() as a way to clear the back stack, and after implementing that solution we saw no crashes when backgrounding the app while a textfield was in focus.

kr...@gmail.com <kr...@gmail.com> #11Jul 25, 2024 01:42PM

Re comment#10 - backQueue is not part of the public API surface and never has been. Calling anything on that is always, always, always the wrong thing to do.

kr...@gmail.com <kr...@gmail.com> #12Sep 5, 2024 01:59PM

Any updates? This issue is persistent for almost 6 months and its getting crazier.

jb...@google.com <jb...@google.com> #13Sep 11, 2024 10:23PM

Solution is provided here >

https://github.com/google/accompanist/issues/1487#issuecomment-1660115297

jb...@google.com <jb...@google.com> #14Sep 12, 2024 05:40PM

This is still happened

pr...@google.com <pr...@google.com> #15Oct 2, 2024 05:37PM

It's still happening with navigation-compose 2.7.0 and lifecycle 2.6.1

pr...@google.com <pr...@google.com> #16Dec 11, 2024 06:27PM

Try 2.7.1