Multiple back button presses (fast popBackStack) cause crash [338624457]

Fixed

Bug

Status Update

No update yet.

Description

kr...@gmail.com

created issue #1

May 4, 2024 01:19PM

Component used: Fragment

Versions used:

androidx.fragment:fragment:1.7.0
androidx.navigation:navigation-runtime:2.7.7
com.google.android.material:material:1.12.0

Setup in Fragment:

import com.google.android.material.transition.MaterialFadeThrough

override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    enterTransition = MaterialFadeThrough()
    exitTransition = MaterialFadeThrough()
}

Im getting this crash, when I navigate forward multiple times (navigate(FragFooDirections.actionFooBar())) and then repeatedly fast use the back gesture or back button (popBackStack()).

java.lang.IllegalStateException: setCurrentPlayTimeMillis() called after animation has been started
	at androidx.transition.Transition$SeekController.setCurrentPlayTimeMillis(Transition.java:2778)
	at androidx.transition.FragmentTransitionSupport.setCurrentPlayTime(FragmentTransitionSupport.java:265)
	at androidx.fragment.app.DefaultSpecialEffectsController$TransitionEffect.onProgress(DefaultSpecialEffectsController.kt:817)
	at androidx.fragment.app.SpecialEffectsController.processProgress(SpecialEffectsController.kt:441)
	at androidx.fragment.app.FragmentManager$1.handleOnBackProgressed(FragmentManager.java:513)
	at androidx.activity.OnBackPressedDispatcher.onBackProgressed(OnBackPressedDispatcher.kt:258)
	at androidx.activity.OnBackPressedDispatcher.access$onBackProgressed(OnBackPressedDispatcher.kt:63)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:129)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:127)
	at androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1.onBackProgressed(OnBackPressedDispatcher.kt:391)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.lambda$onBackStarted$0(WindowOnBackInvokedDispatcher.java:334)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper$$ExternalSyntheticLambda1.onProgressUpdate(D8$$SyntheticClass:0)
	at android.window.BackProgressAnimator.updateProgressValue(BackProgressAnimator.java:162)
	at android.window.BackProgressAnimator.-$$Nest$mupdateProgressValue(Unknown Source:0)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:61)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:57)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.setPropertyValue(DynamicAnimation.java:731)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.doAnimationFrame(DynamicAnimation.java:687)
	at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:344)
	at android.animation.AnimationHandler.-$$Nest$mdoAnimationFrame(Unknown Source:0)
	at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:87)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1397)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1408)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1008)
	at android.view.Choreographer.doFrame(Choreographer.java:934)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1382)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8501)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

The same happens with a SharedAxisTransition:

exitTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
reenterTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)
enterTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
returnTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)

Comments

jb...@google.com <jb...@google.com> #2May 6, 2024 03:28PM

Might be related to

https://issuetracker.google.com/issues/118020865. BTW, I'm using 1.1.0-alpha01.

Project:

https://github.com/SUPERCILEX/Robot-Scouter/tree/2e3100276e5fe2cbad8a2cbb36303694e9f46bbd
Setup: ./gradlew setup

kr...@gmail.com <kr...@gmail.com> #3May 6, 2024 05:41PM

This is due to a bug in Fragment - using 1.1.0-alpha02 of Preference uses a newer Fragment dependency, and fixes this issue.

jb...@google.com <jb...@google.com> May 8, 2024 06:14PM

Assigned to jb...@google.com.

kr...@gmail.com <kr...@gmail.com> #4May 16, 2024 02:06PM

Actually, I just checked and it still crashes using 1.1.0-alpha02.

kr...@gmail.com <kr...@gmail.com> #5Jun 13, 2024 07:19PM

Could you maybe upload a simpler project with reproduction steps? Or at least provide reproduction steps for the project you linked - Does it crash when using Preference 1.0.0?

This still seems suspiciously similar to

https://issuetracker.google.com/issues/120240628, which can not be reproduced with 1.1.0-alpha02 (following the reproduction steps in the first comment).

kr...@gmail.com <kr...@gmail.com> #6Jun 27, 2024 02:11PM

Hi guys. I can also confirm that it still crashes using preferences 1.1.0-alpha02. I ran the barebones sample project included in

https://issuetracker.google.com/issues/120240628 on a Samsung Galaxy J2 Prime running Android 6.0.1.

If I use 1.0.0 version, the NPE issue will not appear. If I use any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02, the NPE issue is there. This issue also exists for MultiSelectListPreference.

th...@gmail.com <th...@gmail.com> #7Jul 5, 2024 05:22AM

I also ran it on a Samsung Galaxy J4+ running Android 8.1.0, and it is the same story. There is no NPE issue using preferences 1.0.0, but using any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02 will cause the NPE.

ap...@google.com <ap...@google.com> #8Jul 9, 2024 08:21PM

Thanks for the further details - it appears there are two similar issues here with Fragment - one has been fixed, but there is still one that exists, causing this bug.

Apologies for the inconvenience.

ap...@google.com <ap...@google.com> #9Jul 18, 2024 05:08AM

This has been fixed and will be available in an upcoming release.

jb...@google.com <jb...@google.com> #10Jul 18, 2024 02:11PM

Marked as fixed, reassigned to mo...@google.com.

@9 Which one?

kr...@gmail.com <kr...@gmail.com> #11Jul 25, 2024 01:42PM

Both the Fragment issues and a workaround in Preference library to prevent this from happening in the future will be released.

kr...@gmail.com <kr...@gmail.com> #12Sep 5, 2024 01:59PM

@11 I mean in which version exactly should we expect it to happen? What would be in the gradle file?

jb...@google.com <jb...@google.com> #13Sep 11, 2024 10:23PM

alpha03, which is yet to be released.

jb...@google.com <jb...@google.com> #14Sep 12, 2024 05:40PM

@13 You mean :
implementation 'androidx.fragment:fragment:1.1.0-alpha03' ?

pr...@google.com <pr...@google.com> #15Oct 2, 2024 05:37PM

Oh I see - sorry.

The two fragment fixes will be available in androidx.fragment:fragment:1.1.0-alpha04
However, androidx.preference:preference:1.1.0-alpha03 will depend on fragment alpha04, so you only need to specify androidx.preference:preference:1.1.0-alpha03 to bring in these fixes and other changes in Preference.

pr...@google.com <pr...@google.com> #16Dec 11, 2024 06:27PM

@15 Thank you