Multiple back button presses (fast popBackStack) cause crash [338624457]

Fixed

Bug

Status Update

No update yet.

Description

kr...@gmail.com

created issue #1

May 4, 2024 01:19PM

Component used: Fragment

Versions used:

androidx.fragment:fragment:1.7.0
androidx.navigation:navigation-runtime:2.7.7
com.google.android.material:material:1.12.0

Setup in Fragment:

import com.google.android.material.transition.MaterialFadeThrough

override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    enterTransition = MaterialFadeThrough()
    exitTransition = MaterialFadeThrough()
}

Im getting this crash, when I navigate forward multiple times (navigate(FragFooDirections.actionFooBar())) and then repeatedly fast use the back gesture or back button (popBackStack()).

java.lang.IllegalStateException: setCurrentPlayTimeMillis() called after animation has been started
	at androidx.transition.Transition$SeekController.setCurrentPlayTimeMillis(Transition.java:2778)
	at androidx.transition.FragmentTransitionSupport.setCurrentPlayTime(FragmentTransitionSupport.java:265)
	at androidx.fragment.app.DefaultSpecialEffectsController$TransitionEffect.onProgress(DefaultSpecialEffectsController.kt:817)
	at androidx.fragment.app.SpecialEffectsController.processProgress(SpecialEffectsController.kt:441)
	at androidx.fragment.app.FragmentManager$1.handleOnBackProgressed(FragmentManager.java:513)
	at androidx.activity.OnBackPressedDispatcher.onBackProgressed(OnBackPressedDispatcher.kt:258)
	at androidx.activity.OnBackPressedDispatcher.access$onBackProgressed(OnBackPressedDispatcher.kt:63)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:129)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:127)
	at androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1.onBackProgressed(OnBackPressedDispatcher.kt:391)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.lambda$onBackStarted$0(WindowOnBackInvokedDispatcher.java:334)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper$$ExternalSyntheticLambda1.onProgressUpdate(D8$$SyntheticClass:0)
	at android.window.BackProgressAnimator.updateProgressValue(BackProgressAnimator.java:162)
	at android.window.BackProgressAnimator.-$$Nest$mupdateProgressValue(Unknown Source:0)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:61)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:57)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.setPropertyValue(DynamicAnimation.java:731)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.doAnimationFrame(DynamicAnimation.java:687)
	at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:344)
	at android.animation.AnimationHandler.-$$Nest$mdoAnimationFrame(Unknown Source:0)
	at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:87)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1397)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1408)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1008)
	at android.view.Choreographer.doFrame(Choreographer.java:934)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1382)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8501)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

The same happens with a SharedAxisTransition:

exitTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
reenterTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)
enterTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
returnTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)

Comments

jb...@google.com <jb...@google.com> #2May 6, 2024 03:28PM

Please include a sample project that reproduces your issue.

kr...@gmail.com <kr...@gmail.com> #3May 6, 2024 05:41PM

Sample project attached. Just add to plain project this dependencies allow to reproduce.

def emoji2_version = "1.1.0-beta01"
implementation "androidx.emoji2:emoji2:$emoji2_version"

def lifecycle_version = "2.5.0-alpha01"
implementation "androidx.lifecycle:lifecycle-process:$lifecycle_version"

jb...@google.com <jb...@google.com> May 8, 2024 06:14PM

Assigned to jb...@google.com.

kr...@gmail.com <kr...@gmail.com> #4May 16, 2024 02:06PM

The reason may be related to this change, which check itself before it is initialized. Use 2.4.0 of lifecycle-process as workaround.

kr...@gmail.com <kr...@gmail.com> #5Jun 13, 2024 07:19PM

Yes, this is due to this change, as well as the fact that EmojiCompatInitializer has a ProcessLifecycleInitializer as a dependency and also re-calls it, but in manual mode.

kr...@gmail.com <kr...@gmail.com> #6Jun 27, 2024 02:11PM

ProcessLifecycleInitializer is expected to already be initialized (via the manifest provider for App Startup) by the time that code runs - App Startup shouldn't be calling create if that component has already been initialized, hence you shouldn't get any exception. We'll take a look on where things are breaking down though.

th...@gmail.com <th...@gmail.com> #7Jul 5, 2024 05:22AM

Thanks for the answer.

As I understand EmojiCompatInitializer has ProcessLifecycleInitializer as a dependency. That is mean, the ProcessLifecycleInitializer must be executed before the EmojiCompatInitializer, which in its create method calls the delayUntilFirstResume method, which in turn calls the ProcessLifecycleInitializer via appInitializer.initializeComponent(ProcessLifecycleInitializer.class)

Maybe it would be more correct to create a bug in emoji-2, but let it be here.

ap...@google.com <ap...@google.com> #8Jul 9, 2024 08:21PM

This issue isn't related to emoji2, it could be reproduced easily with the lifecycle-process (2.4.0 -> 2.5.0-alpha01) only.

ap...@google.com <ap...@google.com> #9Jul 18, 2024 05:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit 97993ad954cb98211ef52b6e26c7877dbdeeec1c
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 01 17:06:11 2022

Bump lifecycle process start-up dependency to 1.1.1

Bumping the startup dependency to include aosp/1855769.

RelNote: "Updated `lifecycle-process` to depend on [Startup 1.1.1](/jetpack/androidx/releases/startup#1.1.1) to ensure that fixes that prevent `ProcessLifecycleInitializer` from throwing a `StartupException` are available by default."
Bug: 216490724
Test: tested in sample app

Change-Id: Ib01dfbba1d63aa03e43e09ee8886cc76e1050e1b

M lifecycle/lifecycle-process/build.gradle

https://android-review.googlesource.com/1964554

jb...@google.com <jb...@google.com> #10Jul 18, 2024 02:11PM

Marked as fixed, reassigned to mo...@google.com.

This has been fixed internally and will be released in the Lifecycle 2.5.0-alpha02 release.

kr...@gmail.com <kr...@gmail.com> #11Jul 25, 2024 01:42PM

When will start-up 1.1.1 release?

kr...@gmail.com <kr...@gmail.com> #12Sep 5, 2024 01:59PM

It should be out before the end of the week.

jb...@google.com <jb...@google.com> #13Sep 11, 2024 10:23PM

Are you seeing a new crash or is it the same trace from above? If it is a new crash can you file a separate bug with your project and the new crash?

jb...@google.com <jb...@google.com> #14Sep 12, 2024 05:40PM

Nevermind I see b/364804225

pr...@google.com <pr...@google.com> #15Oct 2, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.8.4

pr...@google.com <pr...@google.com> #16Dec 11, 2024 06:27PM