Multiple back button presses (fast popBackStack) cause crash [338624457]

Fixed

Bug

Status Update

No update yet.

Description

kr...@gmail.com

created issue #1

May 4, 2024 01:19PM

Component used: Fragment

Versions used:

androidx.fragment:fragment:1.7.0
androidx.navigation:navigation-runtime:2.7.7
com.google.android.material:material:1.12.0

Setup in Fragment:

import com.google.android.material.transition.MaterialFadeThrough

override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    enterTransition = MaterialFadeThrough()
    exitTransition = MaterialFadeThrough()
}

Im getting this crash, when I navigate forward multiple times (navigate(FragFooDirections.actionFooBar())) and then repeatedly fast use the back gesture or back button (popBackStack()).

java.lang.IllegalStateException: setCurrentPlayTimeMillis() called after animation has been started
	at androidx.transition.Transition$SeekController.setCurrentPlayTimeMillis(Transition.java:2778)
	at androidx.transition.FragmentTransitionSupport.setCurrentPlayTime(FragmentTransitionSupport.java:265)
	at androidx.fragment.app.DefaultSpecialEffectsController$TransitionEffect.onProgress(DefaultSpecialEffectsController.kt:817)
	at androidx.fragment.app.SpecialEffectsController.processProgress(SpecialEffectsController.kt:441)
	at androidx.fragment.app.FragmentManager$1.handleOnBackProgressed(FragmentManager.java:513)
	at androidx.activity.OnBackPressedDispatcher.onBackProgressed(OnBackPressedDispatcher.kt:258)
	at androidx.activity.OnBackPressedDispatcher.access$onBackProgressed(OnBackPressedDispatcher.kt:63)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:129)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:127)
	at androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1.onBackProgressed(OnBackPressedDispatcher.kt:391)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.lambda$onBackStarted$0(WindowOnBackInvokedDispatcher.java:334)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper$$ExternalSyntheticLambda1.onProgressUpdate(D8$$SyntheticClass:0)
	at android.window.BackProgressAnimator.updateProgressValue(BackProgressAnimator.java:162)
	at android.window.BackProgressAnimator.-$$Nest$mupdateProgressValue(Unknown Source:0)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:61)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:57)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.setPropertyValue(DynamicAnimation.java:731)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.doAnimationFrame(DynamicAnimation.java:687)
	at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:344)
	at android.animation.AnimationHandler.-$$Nest$mdoAnimationFrame(Unknown Source:0)
	at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:87)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1397)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1408)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1008)
	at android.view.Choreographer.doFrame(Choreographer.java:934)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1382)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8501)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

The same happens with a SharedAxisTransition:

exitTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
reenterTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)
enterTransition = MaterialSharedAxis(MaterialSharedAxis.X, true)
returnTransition = MaterialSharedAxis(MaterialSharedAxis.X, false)

Comments

jb...@google.com <jb...@google.com> #2May 6, 2024 03:28PM

> The Transition Kotlin extensions target the Framework Transition class which is a bit confusing

All extensions in 'core-ktx' target either 'core' or the framework types. This is working as expected. It sounds like this is a feature request for a transition-ktx with equivalent extensions for the androidx.transition types.

> as most framework classes are being deprecated in favor of their AndroidX counterparts, Fragments for example.

"Most"? This *dramatically* overstates what is actually happening. Fragments (and loaders) were added to the framework in a time where the Android team did not have external libraries for shipping features. Transition was added 5 years later.

kr...@gmail.com <kr...@gmail.com> #3May 6, 2024 05:41PM

Pardon my misunderstanding, I was under the belief that where possible, new features that could be developed outside the framework, would be under Androidx. Also it's a common refrain to use the Androidx libraries over the framework libraries where possible, as those ship update independently of platform releases. I wasn't attempting to be dramatic.

If the Transition api is unlikely to change, there is no need for a transition-ktx for androidx.transition types. If developers should use Androidx transitions over framework transitions where possible however, then it would be much appreciated.

I am well aware of the limitations that existed when Fragments and Loaders were created, and when the Transition api was introduced.

jb...@google.com <jb...@google.com> May 8, 2024 06:14PM

Assigned to jb...@google.com.

kr...@gmail.com <kr...@gmail.com> #4May 16, 2024 02:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ae42e311ecfbac18cedc90e489d1fdde956a4557
Author: Jake Wharton <jakew@google.com>
Date: Fri Nov 22 11:13:30 2019

Introduce transition-ktx for standalone transition library

These extensions are the same as androidx.core.transition for the platform types, just adapted to the standalone library.

Bug: 138870873
Test: gw :transition:transition-ktx:build :transition:transition-ktx:connectedCheck
Change-Id: Ie80022cc60ed1f482b7593db5ef1ac1c5ea33d8d

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M jetifier/jetifier/migration.config
M settings.gradle
A transition/transition-ktx/OWNERS
A transition/transition-ktx/api/1.4.0-alpha01.txt
A transition/transition-ktx/api/current.txt
A transition/transition-ktx/api/public_plus_experimental_1.4.0-alpha01.txt
A transition/transition-ktx/api/public_plus_experimental_current.txt
A transition/transition-ktx/api/res-1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_current.txt
A transition/transition-ktx/build.gradle
A transition/transition-ktx/src/androidTest/AndroidManifest.xml
A transition/transition-ktx/src/androidTest/java/androidx/transition/TestActivity.kt
A transition/transition-ktx/src/androidTest/java/androidx/transition/TransitionTest.kt
A transition/transition-ktx/src/androidTest/res/layout/test_activity.xml
A transition/transition-ktx/src/main/AndroidManifest.xml
A transition/transition-ktx/src/main/java/androidx/transition/Transition.kt

https://android-review.googlesource.com/1172715

kr...@gmail.com <kr...@gmail.com> #5Jun 13, 2024 07:19PM

Still crashing with fragment 1.8.0. I have updated my example github repo with all latest libraries.

kr...@gmail.com <kr...@gmail.com> #6Jun 27, 2024 02:11PM

Still crashing with fragment 1.8.1. Example GitHub Repo was updated again.

th...@gmail.com <th...@gmail.com> #7Jul 5, 2024 05:22AM

Any plan to get this done in time for Android 15's enabling of back gesture animations?

ap...@google.com <ap...@google.com> #8Jul 9, 2024 08:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8b1990bc47272275051da2b252189adafde79124
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jun 28 02:56:56 2024

Fix issue with predictive back cancellation

When a Predictive back gesture that is not seekable is interrupted by
another fragment operation, fragment manager loses it state and fails to
display the proper fragment.

We should make it so that when a Predictive back gesture that is not
seekable is interrupt we still move to the correct state.

This ignores the fact that the system will continue to dispatch calls,
but that is okay, we should ignore any calls after our cancellation.

RelNote: "Fixed an issue in fragments where interrupting a predictive
back gesture would send the fragment manager into an undefined state and
even up showing the wrong fragment."
Test: modified and added tests
Bug: 338624457

Change-Id: If82e2cd540a5319faa2e40d4a28ce31026e2e19d

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimatorTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/OnBackStackChangedListenerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionSeekingTest.kt

https://android-review.googlesource.com/3093315

ap...@google.com <ap...@google.com> #9Jul 18, 2024 05:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit 27a398bdc622236b84683d7a1c036803d77fe0d3
Author: George Mount <mount@google.com>
Date: Thu Jul 11 15:39:01 2024

Delay start of animateToStart/End() until Transition is ready.

Bug: 338624457

When a seekable transition has animateToStart() or animateToEnd()
called before the transition is ready, it was previously not
animating. Now, it waits until the transition is ready
before starting the animation.

Test: New tests, manual testing
Change-Id: I44d9618604c29659e1f6ae7e966cd1533369b18c

M transition/transition/src/androidTest/java/androidx/transition/SeekTransitionTest.kt
M transition/transition/src/main/java/androidx/transition/Transition.java

https://android-review.googlesource.com/3168824

jb...@google.com <jb...@google.com> #10Jul 18, 2024 02:11PM

Marked as fixed, reassigned to mo...@google.com.

This was actually an error specific to Androidx Transition, was addressed internally, and will be released in the Transition 1.5.1 version.

kr...@gmail.com <kr...@gmail.com> #11Jul 25, 2024 01:42PM

Seems to be not fixed. My sample app is still crashing after updating to the latest libraries:

material = "1.12.0"
activity = "1.9.1"
fragment = "1.8.2"
transition = "1.5.1"

I have pushed an update to my sample library. To reproduce:

click multiple times on "Next Fragment" (adding a fragment to the back stack)
repeatedly perform the back gesture in a short period of time -> crash

kr...@gmail.com <kr...@gmail.com> #12Sep 5, 2024 01:59PM

It's still crashing with the latest libraries:

material = "1.13.0-alpha05"
activity = "1.9.2"
fragment = "1.8.3"
navigation = "2.8.0"

my github repo was updated

jb...@google.com <jb...@google.com> #13Sep 11, 2024 10:23PM

Are you seeing a new crash or is it the same trace from above? If it is a new crash can you file a separate bug with your project and the new crash?

jb...@google.com <jb...@google.com> #14Sep 12, 2024 05:40PM

Nevermind I see b/364804225

pr...@google.com <pr...@google.com> #15Oct 2, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.8.4

pr...@google.com <pr...@google.com> #16Dec 11, 2024 06:27PM