Fixed
Status Update
No update yet.
Comments
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
kr...@gmail.com
jb...@google.com
kr...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
kr...@gmail.com
Still crashing with fragment 1.8.0. I have updated my example github repo with all latest libraries.
kr...@gmail.com
Still crashing with fragment 1.8.1. Example GitHub Repo was updated again.
th...@gmail.com
Any plan to get this done in time for Android 15's enabling of back gesture animations?
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8b1990bc47272275051da2b252189adafde79124
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jun 28 02:56:56 2024
Fix issue with predictive back cancellation
When a Predictive back gesture that is not seekable is interrupted by
another fragment operation, fragment manager loses it state and fails to
display the proper fragment.
We should make it so that when a Predictive back gesture that is not
seekable is interrupt we still move to the correct state.
This ignores the fact that the system will continue to dispatch calls,
but that is okay, we should ignore any calls after our cancellation.
RelNote: "Fixed an issue in fragments where interrupting a predictive
back gesture would send the fragment manager into an undefined state and
even up showing the wrong fragment."
Test: modified and added tests
Bug: 338624457
Change-Id: If82e2cd540a5319faa2e40d4a28ce31026e2e19d
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimatorTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/OnBackStackChangedListenerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionSeekingTest.kt
https://android-review.googlesource.com/3093315
Branch: androidx-main
commit 8b1990bc47272275051da2b252189adafde79124
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jun 28 02:56:56 2024
Fix issue with predictive back cancellation
When a Predictive back gesture that is not seekable is interrupted by
another fragment operation, fragment manager loses it state and fails to
display the proper fragment.
We should make it so that when a Predictive back gesture that is not
seekable is interrupt we still move to the correct state.
This ignores the fact that the system will continue to dispatch calls,
but that is okay, we should ignore any calls after our cancellation.
RelNote: "Fixed an issue in fragments where interrupting a predictive
back gesture would send the fragment manager into an undefined state and
even up showing the wrong fragment."
Test: modified and added tests
Bug: 338624457
Change-Id: If82e2cd540a5319faa2e40d4a28ce31026e2e19d
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimatorTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/OnBackStackChangedListenerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionSeekingTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 27a398bdc622236b84683d7a1c036803d77fe0d3
Author: George Mount <mount@google.com>
Date: Thu Jul 11 15:39:01 2024
Delay start of animateToStart/End() until Transition is ready.
Bug: 338624457
When a seekable transition has animateToStart() or animateToEnd()
called before the transition is ready, it was previously not
animating. Now, it waits until the transition is ready
before starting the animation.
Test: New tests, manual testing
Change-Id: I44d9618604c29659e1f6ae7e966cd1533369b18c
M transition/transition/src/androidTest/java/androidx/transition/SeekTransitionTest.kt
M transition/transition/src/main/java/androidx/transition/Transition.java
https://android-review.googlesource.com/3168824
Branch: androidx-main
commit 27a398bdc622236b84683d7a1c036803d77fe0d3
Author: George Mount <mount@google.com>
Date: Thu Jul 11 15:39:01 2024
Delay start of animateToStart/End() until Transition is ready.
Bug: 338624457
When a seekable transition has animateToStart() or animateToEnd()
called before the transition is ready, it was previously not
animating. Now, it waits until the transition is ready
before starting the animation.
Test: New tests, manual testing
Change-Id: I44d9618604c29659e1f6ae7e966cd1533369b18c
M transition/transition/src/androidTest/java/androidx/transition/SeekTransitionTest.kt
M transition/transition/src/main/java/androidx/transition/Transition.java
jb...@google.com
This was actually an error specific to Androidx Transition, was addressed internally, and will be released in the Transition 1.5.1 version.
kr...@gmail.com
Seems to be not fixed. My sample app is still crashing after updating to the latest libraries:
material = "1.12.0"
activity = "1.9.1"
fragment = "1.8.2"
transition = "1.5.1"
I have pushed an update to my sample library. To reproduce:
- click multiple times on "Next Fragment" (adding a fragment to the back stack)
- repeatedly perform the back gesture in a short period of time -> crash
kr...@gmail.com
It's still crashing with the latest libraries:
material = "1.13.0-alpha05"
activity = "1.9.2"
fragment = "1.8.3"
navigation = "2.8.0"
my github repo was updated
jb...@google.com
Are you seeing a new crash or is it the same trace from above? If it is a new crash can you file a separate bug with your project and the new crash?
jb...@google.com
Nevermind I see
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.fragment:fragment:1.8.4
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.transition:transition:1.6.0-alpha01
Description
Component used: Fragment
Versions used:
Setup in Fragment:
Im getting this crash, when I navigate forward multiple times (
navigate(FragFooDirections.actionFooBar())) and then repeatedly fast use the back gesture or back button (popBackStack()).The same happens with a SharedAxisTransition: