Remove `compose-ui` dependency from `lifecycle-viewmodel-compose` commonMain [339562627]

Fixed

Bug

Status Update

No update yet.

Description

de...@gmail.com

created issue #1

May 9, 2024 06:12PM

Currently lifecycle-viewmodel-compose are depending on compose-ui in commonMain. The dependency is only used in androidMain.

This dependency brings alot of code for projects aiming to use Compose Runtime only, for example Redwood. At Voyager the Core and Navigator modules only depend on Compose Runtime, by adding the support for ViewModel to KMP projects with Voyager would bring the hole compose-ui.

The solution here is just move the compose-ui dependency to androidMain.

Comments

mg...@google.com <mg...@google.com> May 9, 2024 06:14PM

Assigned to mg...@google.com.

ap...@google.com <ap...@google.com> #2May 13, 2024 10:34AM

Marked as fixed.

Might be related to

https://issuetracker.google.com/issues/118020865. BTW, I'm using 1.1.0-alpha01.

Project:

https://github.com/SUPERCILEX/Robot-Scouter/tree/2e3100276e5fe2cbad8a2cbb36303694e9f46bbd
Setup: ./gradlew setup

na...@google.com <na...@google.com> #3May 29, 2024 06:05PM

This is due to a bug in Fragment - using 1.1.0-alpha02 of Preference uses a newer Fragment dependency, and fixes this issue.

pr...@google.com <pr...@google.com> #4Aug 13, 2024 06:58PM

Actually, I just checked and it still crashes using 1.1.0-alpha02.

Issue 339562627

Description

Issue summary

Comments

mg...@google.com <mg...@google.com> May 9, 2024 06:14PM

ap...@google.com <ap...@google.com> #2May 13, 2024 10:34AM

na...@google.com <na...@google.com> #3May 29, 2024 06:05PM

pr...@google.com <pr...@google.com> #4Aug 13, 2024 06:58PM

Add comment

Issue metadata