Fixed
Status Update
No update yet.
Comments
mg...@google.com
ap...@google.com
Building note: run ./gradlew ... -x processReleaseMetadata
na...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018
Fix ViewModel proguard rules
It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection
Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c
M lifecycle/viewmodel/proguard-rules.pro
https://android-review.googlesource.com/727573
https://goto.google.com/android-sha1/5f6e46e40a7e47924ac1d04426230466de7b6f38
Branch: androidx-master-dev
commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018
Fix ViewModel proguard rules
It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection
Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c
M lifecycle/viewmodel/proguard-rules.pro
pr...@google.com
Thanks!
Description
Currently
lifecycle-viewmodel-composeare depending oncompose-uiincommonMain. The dependency is only used inandroidMain.This dependency brings alot of code for projects aiming to use Compose Runtime only, for example Redwood. At Voyager the Core and Navigator modules only depend on Compose Runtime, by adding the support for ViewModel to KMP projects with Voyager would bring the hole
compose-ui.The solution here is just move the
compose-uidependency toandroidMain.