Fixed

Bug

Status Update

No update yet.

Description

ju...@gmail.com

created issue #1

May 25, 2024 10:12AM

Summary:

Using ExifInterface to call saveAttributes on a WebP file corrupts the WebP file, causing it to become invalid.

Steps to Reproduce:

Use ExifInterface to load a WebP file that does not contain a VP8X header. Call saveAttributes on the ExifInterface object. Attempt to open the resulting WebP file. Expected Result: The WebP file should remain valid and openable after saving attributes.

Actual Result: The WebP file becomes corrupted and cannot be opened properly.

Root Cause Analysis:

If the WebP file does not have a VP8X header, ExifInterface writes a new VP8X header.

When the WebP file's width or height is greater than 8191, the issue arises.

The following code causes the problem:

widthAndHeight = totalInputStream.readInt();
width = (widthAndHeight << 18) >> 18;
height = (widthAndHeight << 2) >> 18;

If the width or height is greater than 8191, left-shifting causes the sign bit to be lost, turning a '1' into a '0', which results in an incorrect width or height.

Environment

Android version: Any version.
Device model: Any device.
ExifInterface version: 1.3.7

Comments

ib...@google.com <ib...@google.com> Aug 1, 2024 08:40AM

Assigned to ib...@google.com.

ju...@gmail.com <ju...@gmail.com> #2Aug 1, 2024 08:42AM

There are a few more changes to DataStoreImpl's logic which makes a reevaluation necessary.

Now with Yigit's changes, datastore's cold flow always tries to do a dirty read by readState which calls readAndInitOrPropagateAndThrowFailure that invokes readDataOrHandleCorruption only in InitDataStore's first run. Any following read is triggered by IPC's listener which calls readDataAndUpdateCache which updates the cache to ReadException returned from attemptRead.

A ReadException is not automatically handled and stays in cache until a updateData call which revisits readAndInitOrPropagateAndThrowFailure, but it doesn't handle the corruption exception because it's already not the first run. In such case, the handleUpdate call proceeds to transformAndWrite which does not catch the exceptions thrown from readDataFromFileOrDefault.

ib...@google.com <ib...@google.com> #3Aug 1, 2024 09:16AM

can we create a test failure for this? I'm not fully sure what is going wrong here, it is a bit hard to track w/o a repro case.

ju...@gmail.com <ju...@gmail.com> #4Aug 1, 2024 09:22AM

can we create a test failure for this?

Sure I'm working on the code changes.

In the meantime I think this bug might makes the errors e.g. in b/309382591 harder to recover because it doesn't try to handle the corruption until the app restarts so the DS can readAndInit again (with corruption handler logic).

ap...@google.com <ap...@google.com> #5Aug 5, 2024 01:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 383a67d0e5a9b35e394b212db35bdee892b167fb
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Wed Feb 21 17:04:40 2024

Add tests to verify that CorruptionException is not properly handled after DataStore's first disk read. If the internal state is [ReadException], it will not recover for the rest of the lifecycle.

Fix in the follow up change.

Bug: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Ie77900b5c2cb8fb8e55d4c40364491dea9250784

M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt

https://android-review.googlesource.com/2972402

ib...@google.com <ib...@google.com> #6Aug 6, 2024 12:59PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 70085fee2af278bb8c3e45e1acfcf3f4cbb05c5a
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Thu Feb 22 15:08:34 2024

DataStore handles CorruptionException for all reads and writes.

Before this change, DataStore didn't handle the CorruptionException for both the reads and writes after initialization.

Fixes: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Icb07b140017b62a905d3626f82aeb993f636c053

M datastore/datastore-core/src/commonMain/kotlin/androidx/datastore/core/DataStoreImpl.kt
M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt

https://android-review.googlesource.com/2974198

ap...@google.com <ap...@google.com> #7Aug 16, 2024 10:14AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.datastore:datastore-core:1.1.0-beta02
androidx.datastore:datastore-core-android:1.1.0-beta02
androidx.datastore:datastore-core-iosarm64:1.1.0-beta02
androidx.datastore:datastore-core-iossimulatorarm64:1.1.0-beta02
androidx.datastore:datastore-core-iosx64:1.1.0-beta02
androidx.datastore:datastore-core-jvm:1.1.0-beta02
androidx.datastore:datastore-core-linuxx64:1.1.0-beta02
androidx.datastore:datastore-core-macosarm64:1.1.0-beta02
androidx.datastore:datastore-core-macosx64:1.1.0-beta02

na...@google.com <na...@google.com> #8Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.exifinterface:exifinterface:1.4.0-alpha01

67...@gmail.com <67...@gmail.com> #9Mar 21, 2025 06:34PM

Comment has been deleted.

Message last modified on Mar 21, 2025 06:35PM

IssueTracker

WebP Files Corrupted by ExifInterface.saveAttributes When Width or Height Exceeds 8191

Status Update

Description

Summary:

Steps to Reproduce:

Environment

Comments

ib...@google.com <ib...@google.com> Aug 1, 2024 08:40AM

ju...@gmail.com <ju...@gmail.com> #2Aug 1, 2024 08:42AM

ib...@google.com <ib...@google.com> #3Aug 1, 2024 09:16AM

ju...@gmail.com <ju...@gmail.com> #4Aug 1, 2024 09:22AM

ap...@google.com <ap...@google.com> #5Aug 5, 2024 01:16PM

ib...@google.com <ib...@google.com> #6Aug 6, 2024 12:59PM

ap...@google.com <ap...@google.com> #7Aug 16, 2024 10:14AM

na...@google.com <na...@google.com> #8Nov 13, 2024 06:19PM

67...@gmail.com <67...@gmail.com> #9Mar 21, 2025 06:34PM

Issue 342697059

Description

Summary:

Steps to Reproduce:

Environment

Issue summary

Comments

ib...@google.com <ib...@google.com> Aug 1, 2024 08:40AM

ju...@gmail.com <ju...@gmail.com> #2Aug 1, 2024 08:42AM

ib...@google.com <ib...@google.com> #3Aug 1, 2024 09:16AM

ju...@gmail.com <ju...@gmail.com> #4Aug 1, 2024 09:22AM

ap...@google.com <ap...@google.com> #5Aug 5, 2024 01:16PM

ib...@google.com <ib...@google.com> #6Aug 6, 2024 12:59PM

ap...@google.com <ap...@google.com> #7Aug 16, 2024 10:14AM

na...@google.com <na...@google.com> #8Nov 13, 2024 06:19PM

67...@gmail.com <67...@gmail.com> #9Mar 21, 2025 06:34PM

Add comment

Issue metadata