Fixed
Status Update
No update yet.
Comments
ib...@google.com
ju...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4fc8470745f5b0f08f9531b7ab85eed6a8f424cb
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jun 10 11:26:54 2021
Remove uses of titleCase in Safe Args
The titleCase API was added in Kotlin 1.5.0. Gradle versions previous to
7.0 relied on eariler versionss of Kotlin that do not have that API
available. SafeArgs now depends on Android Gradle Plugin 4.2.0, which is
compatible down to Gradle 6.7.1, so we should continue to support older
versions of kotlin until we move to the next stable version of AGP.
RelNote: "SafeArgs will no longer fail when building your app with
`Kotlin` versions before `1.5.0`."
Test: tested in sample app
Bug: 190739257
Change-Id: Icd1ff3c64f220f4b310934c2edf910d6aae01475
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/ext/String_ext.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavArgumentResolverTest.kt
https://android-review.googlesource.com/1733983
Branch: androidx-main
commit 4fc8470745f5b0f08f9531b7ab85eed6a8f424cb
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jun 10 11:26:54 2021
Remove uses of titleCase in Safe Args
The titleCase API was added in Kotlin 1.5.0. Gradle versions previous to
7.0 relied on eariler versionss of Kotlin that do not have that API
available. SafeArgs now depends on Android Gradle Plugin 4.2.0, which is
compatible down to Gradle 6.7.1, so we should continue to support older
versions of kotlin until we move to the next stable version of AGP.
RelNote: "SafeArgs will no longer fail when building your app with
`Kotlin` versions before `1.5.0`."
Test: tested in sample app
Bug: 190739257
Change-Id: Icd1ff3c64f220f4b310934c2edf910d6aae01475
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/ext/String_ext.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavArgumentResolverTest.kt
ib...@google.com
This is fixed internally and will be available in the the Navigation 2.4.0-alpha04 release.
ju...@gmail.com
Still occurs in Version 2.4.0-beta02 with Gradle 6.9
ap...@google.com
Still occurs in Version 2.4.0-beta02 with Gradle 6.9
ib...@google.com
Please file a bug with a minimum sample project that reproduces this issue.
ap...@google.com
Hi Team,
Issue is still reproducible with Gradle 7.0
Please help to fix on priority
Issue is still reproducible with Gradle 7.0
Please help to fix on priority
na...@google.com
Please file a bug with a minimum sample project that reproduces this issue.
67...@gmail.com
Comment has been deleted.
Description
Summary:
Using
Steps to Reproduce:
Use ExifInterface to load a WebP file that does not contain a VP8X header. Call saveAttributes on the ExifInterface object. Attempt to open the resulting WebP file. Expected Result: The WebP file should remain valid and openable after saving attributes.
Actual Result: The WebP file becomes corrupted and cannot be opened properly.
Root Cause Analysis:
If the WebP file does not have a VP8X header, ExifInterface writes a new VP8X header.
When the WebP file's width or height is greater than 8191, the issue arises.
The following code causes the problem:
If the width or height is greater than 8191, left-shifting causes the sign bit to be lost, turning a '1' into a '0', which results in an incorrect width or height.
Environment