Fixed

Bug

Status Update

No update yet.

Description

ha...@meta.com

created issue #1

May 28, 2024 03:15PM

We can't reproduce these but after integrating with the in app review library we started to see crash reports with these stack traces at the bottom. We don't have info on the Google play services version on the client. But the issues might be device specific. Seems like we are on the latest versions of these libraries.

app library versions :

com.google.android.play:core-common: 2.0.3 com.google.android.play:review: @2.0.1

Crash 1

Mostly occuring on some xioami devices on android 14 Top 3 devices: Xiaomi-23127PN0CG Xiaomi-22071212AG Xiaomi-2303ERA42L

Trace: java.lang.RuntimeException: Unable to start activity ComponentInfo{ com.app/com.google.android.play.core.common.PlayCoreDialogWrapperActivity}: android.content.ActivityNotFoundException: No Activity found to handle null
- android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3971)
- android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:4124)
- android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:103)
- android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:149)
- android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:99)
- android.app.ActivityThread$H.handleMessage (ActivityThread.java:2572)
- android.os.Handler.dispatchMessage (Handler.java:106)
- android.os.Looper.loopOnce (Looper.java:224)
- android.os.Looper.loop (Looper.java:318)
- android.app.ActivityThread.main (ActivityThread.java:8677)
- java.lang.reflect.Method.invoke (Native Method:0)
- com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:561)
- com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1013)
- Caused by: android.content.ActivityNotFoundException: No Activity found to handle null
- android.app.Instrumentation.checkStartActivityResult (Instrumentation.java:2280)
- android.app.Activity.startIntentSenderForResultInner (Activity.java:6205)
- android.app.Activity.startIntentSenderForResult (Activity.java:6168)
- android.app.Activity.startIntentSenderForResult (Activity.java:6123)
- com.google.android.play.core.common.PlayCoreDialogWrapperActivity.onCreate (com.google.android.play:core-common@@2.0.3:12:0)
- android.app.Activity.performCreate (Activity.java:8891)
- android.app.Activity.performCreate (Activity.java:8856)
- android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1468)
- android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3953)

Crash 2

mostly occuring on vivo and huawei devices on differend android versions

top 3 devices vivo-V2027 vivo-V2029 HUAWEI-CAM-L21

Trace: java.lang.RuntimeException: Unable to start activity ComponentInfo{ com.app/com.google.android.play.core.common.PlayCoreDialogWrapperActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.IntentSender android.app.PendingIntent.getIntentSender()' on a null object reference
- android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3973)
- android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:4138)
- android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:103)
- android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
- android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
- android.app.ActivityThread$H.handleMessage (ActivityThread.java:2458)
- android.os.Handler.dispatchMessage (Handler.java:106)
- android.os.Looper.loopOnce (Looper.java:233)
- android.os.Looper.loop (Looper.java:334)
- android.app.ActivityThread.main (ActivityThread.java:8513)
- java.lang.reflect.Method.invoke (Native Method:0)
- com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:582)
- com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1068)
- Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.IntentSender android.app.PendingIntent.getIntentSender()' on a null object reference
- com.google.android.play.core.common.PlayCoreDialogWrapperActivity.onCreate (com.google.android.play:core-common@@2.0.3:11:0)
- android.app.Activity.performCreate (Activity.java:8506)
- android.app.Activity.performCreate (Activity.java:8484)
- android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1379)
- android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3946)

Comments

vi...@google.com <vi...@google.com> #2May 29, 2024 11:28AM

Assigned to vi...@google.com.

It looks like we have more directories

›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/arm64-v8a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/arm64-v8a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/armeabi-v7a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/armeabi-v7a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86_64/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86_64/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/arm64-v8a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/arm64-v8a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/armeabi-v7a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/armeabi-v7a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86_64/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86_64/build.ninja.txt📋

it also considers all of these input to configuration cache

ha...@meta.com <ha...@meta.com> #3Jun 3, 2024 04:15PM

Prefab feature also seems to cause the following to be added as configuration ache inputs

›../../out/androidx/external/libyuv/build/intermediates/prefab_package_header_only/prefab_publication.json/debug📋
›../../out/androidx/external/libyuv/build/intermediates/prefab_package_header_only/prefab_publication.json/release📋
›../../out/androidx/test/ext/junit-gtest/build/intermediates/prefab_package_header_only/prefab_publication.json/debug📋
›../../out/androidx/test/ext/junit-gtest/build/intermediates/prefab_package_header_only/prefab_publication.json/release📋

vi...@google.com <vi...@google.com> #4Jun 18, 2024 02:34AM

./gradlew zipTestConfigsWithApks

to...@gmail.com <to...@gmail.com> #5Sep 24, 2024 02:31PM

./gradlew zipTestConfigsWithApks in the androidx project

Do you mean to run from androidx-main/frameworks/support? If so, I did a run but it took too long and failed in the end with some 9 errors. Even if it finished successfully, it is too long for debug. Do we have to run that specific task or it can be reproduced with some lightweight task? If would be more helpful if we can even reproduce it in a sample project instead of using the androidx project.

Jomo, do you know where those cxx related files are being created? any pointers?

ra...@google.com <ra...@google.com> #6Oct 4, 2024 08:51PM

The easiest is to probably just look at https://android-build.corp.google.com/builds/pending/P58531861/androidx_incremental/latest/incremental/configuration-cache-reports/78r13m56v7yjbg14vhi2yg2nb/5o4wtl36u55s4qrlzmk4n19px/configuration-cache-report.html

in there see file system entry. all of these files are treated as input to the configuration cache. There should be no entries to ../../out/ once all the plugins are fixed.

to...@gmail.com <to...@gmail.com> #7Oct 7, 2024 11:18AM

Sadly, the report doesnt give you traces (I asked rodrigo from gradle to add it in the future version of gradle), so we only see it is coming from plugin 'com.android.internal.library'

ra...@google.com <ra...@google.com> #8Oct 22, 2024 08:09PM

Marked as fixed.

As far as I know, the most effective way to get the traces is to debug a build running with gradle by adding a break point here https://github.com/gradle/gradle/blob/8129d2feae87affd001b82ada7fa57c233f66467/subprojects/core/src/main/java/org/gradle/internal/classpath/Instrumented.java#L367 which is why we need a sample project. Other than that, we have to guess based on path name from the report.

ra...@paynearby.in <ra...@paynearby.in> #9Jan 7, 2025 07:19AM

The folder path '../../out/androidx/appsearch/appsearch-local-storage/build/intermediates/cxx' originates from ProjectInfo::getIntermediatesDir() which is deprecated with a message that says "Use the version that returns a provider".

The files mentioned in comment#2 are created in ExternalNativeJsonGenerator. The presence of "build/../nativeBuildStaging" in the path indicates that the output location is customized in build.gradle by setting com.android.build.api.dsl.Cmake::buildStagingDirectory.

The files in comment#3 are related to a Gradle module with C++ depending on another Gradle module with C++. Though I don't see why they would have 'debug' or 'release' post-pended. You can exercise the general module-to-module logic by running ModuleToModuleDepsTest.

A question maybe for Ivan, I thought the tests under com.android.build.gradle.integration.ndk.* would fail if they violated configuration caching (I recall the original push for configuration caching required some of these tests to be temporarily exempted). Is there a new constraint arriving with Gradle 8.1? In other words, are these regressions or have they always existed? It might help narrow down the cause/fix.

IssueTracker

Crashes at PlayCoreDialogWrapperActivity after integrating the In app review library .

Status Update

Description

Crash 1

Crash 2

Comments

vi...@google.com <vi...@google.com> #2May 29, 2024 11:28AM

ha...@meta.com <ha...@meta.com> #3Jun 3, 2024 04:15PM

vi...@google.com <vi...@google.com> #4Jun 18, 2024 02:34AM

to...@gmail.com <to...@gmail.com> #5Sep 24, 2024 02:31PM

ra...@google.com <ra...@google.com> #6Oct 4, 2024 08:51PM

to...@gmail.com <to...@gmail.com> #7Oct 7, 2024 11:18AM

ra...@google.com <ra...@google.com> #8Oct 22, 2024 08:09PM

ra...@paynearby.in <ra...@paynearby.in> #9Jan 7, 2025 07:19AM

Issue 343086058

Description

Crash 1

Crash 2

Issue summary

Comments

vi...@google.com <vi...@google.com> #2May 29, 2024 11:28AM

ha...@meta.com <ha...@meta.com> #3Jun 3, 2024 04:15PM

vi...@google.com <vi...@google.com> #4Jun 18, 2024 02:34AM

to...@gmail.com <to...@gmail.com> #5Sep 24, 2024 02:31PM

ra...@google.com <ra...@google.com> #6Oct 4, 2024 08:51PM

to...@gmail.com <to...@gmail.com> #7Oct 7, 2024 11:18AM

ra...@google.com <ra...@google.com> #8Oct 22, 2024 08:09PM

ra...@paynearby.in <ra...@paynearby.in> #9Jan 7, 2025 07:19AM

Add comment

Issue metadata