lifecycle-runtime-compose:2.8.2 occurs CompositionLocal LocalLifecycleOwner not present Error [346808608]

Fixed

Bug

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Jun 13, 2024 12:57PM

This is basically an follow-up of https://issuetracker.google.com/issues/336842920.

Component used:

Version used:

Compose 1.6.8
Lifecycle 2.8.2
AGP 8.4.2

Devices/Android versions reproduced on: Android 14

We see the the following crashes directly at app start when using R8 (with default AGP 8.x fullMode enabled): IllegalStateException: CompositionLocal LocalLifecycleOwner not present

We saw the added proguard rules in https://android-review.googlesource.com/c/platform/frameworks/support/+/3105647/21/lifecycle/lifecycle-runtime-compose/proguard-rules.pro

Changing them to

-keep class androidx.compose.ui.platform.AndroidCompositionLocals_androidKt { *; }

fixes the crash.

So it seems the keep rule is currently not sufficient to make 2.8.2 compatible with Compose 1.6 when minify the build.

Comments

il...@google.com <il...@google.com> #2Jun 13, 2024 04:04PM

Hi, sorry for the trouble. I am working on improving our radio HAL. Unfortunately, it will take a while because it is very large. Please do not send non-ASCII characters in SMS.

ga...@freeletics.com <ga...@freeletics.com> #3Jun 14, 2024 06:21AM

Hi, I don't know if it may be implemented as quick fix on the actual code, but looks like Ñ is the only alphabet letter having the issue (at least between ones widely used within GSM 03.38 GSM 7-bit).

I've tried with ÄÇÖÜàèéìòùäñöü and all of them are correctly sending only one SMS and not two concatenated.

mg...@google.com <mg...@google.com> Jun 14, 2024 10:22AM

Assigned to mg...@google.com.

Ni...@fressnapf.com <Ni...@fressnapf.com> #4Jun 14, 2024 11:16AM

I've tried with ÄÇÖÜàèéìòùäñöü and all of them are correctly sending only one SMS and not two concatenated.

I see, maybe we missed that one Unicode somewhere then. Could be easier to fix then. I will take a look this week. Thank you for pointing this.

Message last modified on Jun 14, 2024 11:19AM

mg...@google.com <mg...@google.com> #5Jun 14, 2024 12:48PM

Accepted by mg...@google.com.

Just to get the full picture, I've tested with all characters included here

https://en.wikipedia.org/wiki/GSM_03.38 both in Basic Character Set (they should take 1 char of the 160) and Basic Character Set Extension (they should take 2 char, first is ESC prefix) and the only one causing the issue is Ñ

Sending a character outside that set, like á, message it's correctly split into 2 parts, first one of 70 chars as expected.

Message last modified on Jun 14, 2024 02:44PM

mg...@google.com <mg...@google.com> #6Jun 14, 2024 03:10PM

So, we have this:

https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/android/emu/telephony/src/android/telephony/gsm.c#551

'Z', 0xc4, 0xd6,0x147, 0xdc, 0xa7,

I think 0x147 is wrong and it must be 0xd1 instead.

Message last modified on Jun 27, 2024 09:26PM

ap...@google.com <ap...@google.com> #7Jun 17, 2024 09:50AM

Marked as fixed.

Yes, I agree. 0x147 is something similar, but correct one is 0xd1

nu...@traderepublic.com <nu...@traderepublic.com> #8Jun 27, 2024 12:05PM

Feel free to try this build (pick a gfxstream one):

https://ci.android.com/builds/branches/aosp-emu-master-dev/grid?head=12910395&tail=12910395&legacy=1

mg...@google.com <mg...@google.com> #9Jun 27, 2024 03:48PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Emulator 35.4.6 Canary

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

Message last modified on Jun 27, 2024 03:49PM

pr...@google.com <pr...@google.com> #10Jun 27, 2024 10:50PM

https://issuetracker.google.com/389330750#attachment62124209

Gemini

m....@gmail.com <m....@gmail.com> #11Jun 28, 2024 02:31PM

Gracias

mg...@google.com <mg...@google.com> #12Jun 29, 2024 09:55AM

comment#11:

There was a mix-up, and the Lifecycle 2.8.3 artifacts won't be available until Monday. Sorry for the false alarm.

m....@gmail.com <m....@gmail.com> #13Jul 1, 2024 07:29PM

Seems to be good now. Thanks!

mg...@google.com <mg...@google.com> #14Jul 2, 2024 08:32AM

Lifecycle 2.8.3 is now available on maven.google.com.

pe...@mohemian.com <pe...@mohemian.com> #15Jul 8, 2024 08:48AM

I'm still getting "java.lang.IllegalStateException: CompositionLocal LocalLifecycleOwner not present" with 2.8.3 in release builds (with obfuscation enabled). Adding

-keep class androidx.compose.ui.platform.AndroidCompositionLocals_androidKt { *; }

to my ProGuard rules fixes the issue. Any advice?

In my setup I have an app that's using the lifecycle dependencies directly, but some other dependencies of mine also include the same (and these libraries are obfuscated too) - not sure if this makes a difference.

mg...@google.com <mg...@google.com> #16Jul 8, 2024 03:47PM

comment#15:

I'm unable to offer advice since I can't replicate the issue you're experiencing -- but based on your message, it appears Lifecycle "should" be working correctly.

Would you please create a separated issue and include a sample project that reproduces the problem you're encountering?

Message last modified on Jul 8, 2024 03:56PM

pr...@google.com <pr...@google.com> #17Aug 13, 2024 06:58PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-runtime-compose:2.9.0-alpha01
androidx.lifecycle:lifecycle-runtime-compose-android:2.9.0-alpha01
androidx.lifecycle:lifecycle-runtime-compose-desktop:2.9.0-alpha01