Fixed
Status Update
Comments
ky...@bytedance.com <ky...@bytedance.com> #2
Digging around a bit, it appears WebKit itself doesn't handle authentication at all.
Instead, it would appear on Android that the package org.apache.http.auth does this.
Instead, it would appear on Android that the package org.apache.http.auth does this.
rk...@google.com <rk...@google.com>
rk...@google.com <rk...@google.com> #3
It's definitely not passing through the information. Here's a snippet from my Apache
log:
---
192.168.10.199 - - [20/Nov/2008:20:14:37 -0600] "GET /file.txt HTTP/1.1" 401 401 "-"
"AndroidDownloadManager"
log:
---
192.168.10.199 - - [20/Nov/2008:20:14:37 -0600] "GET /file.txt HTTP/1.1" 401 401 "-"
"AndroidDownloadManager"
Description
AutoLock
appears to be a custom implementation ofstd::unique_lock/lock_guard
. It does, however, a method namedisLocked()
. There is only one use of the method at the moment:I believe, that has room for improvement. Firstly, even if we checked
isLock()
in general, asisLock()
is not thread-safe, there is no guarantee (in general) that the same thread can then lock it. It is only useful when there is only one thread that locks/unlocks the givenAutoLock
object and the thread wants know whether thelock
is acquired or not by itself. I don't think that's useful. I think the method being public, it has a good chance to confuse external developers.My belief is that the
AutoLock
should be simply replaced withstd::unique_lock
and/orstd::lock_guard
, as many uses of the class do not calllock
orunlock
. And,isLocked()
should be removed. The only call site should be implemented without that.Aside from all mentioned above, I am trying to compile the code with
--enable-thread-safety-checks
, and the first code that blocked the compilation on Linux was the use ofisLocked()
.