IssueTracker

AutoLock appears to be a custom implementation of std::unique_lock/lock_guard. It does, however, a method named isLocked(). There is only one use of the method at the moment: https://cs.android.com/android/platform/superproject/+/emu-master-dev:hardware/google/aemu/base/include/aemu/base/async/RecurrentTask.h;l=120

I believe, that has room for improvement. Firstly, even if we checked isLock() in general, as isLock() is not thread-safe, there is no guarantee (in general) that the same thread can then lock it. It is only useful when there is only one thread that locks/unlocks the given AutoLock object and the thread wants know whether the lock is acquired or not by itself. I don't think that's useful. I think the method being public, it has a good chance to confuse external developers.

My belief is that the AutoLock should be simply replaced with std::unique_lock and/or std::lock_guard, as many uses of the class do not call lock or unlock. And, isLocked() should be removed. The only call site should be implemented without that.

Aside from all mentioned above, I am trying to compile the code with --enable-thread-safety-checks, and the first code that blocked the compilation on Linux was the use of isLocked().