Fixed
Status Update
No update yet.
Comments
da...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3eb053061ebd600de2ce0d13994c7f227711b21e
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue May 28 09:54:27 2024
Fix find database impl reflection when class has no package.
Handle the Android only (not reproducible in JVM) case when a class has no package and the getPackage() call on the Class returns null.
Bug: 342097292
Test: KClassUtilTest
Change-Id: Ie04a62cb42e9d3e9a1badb4b66030851df22b01f
A room/room-runtime/src/androidInstrumentedTest/kotlin/NoPackageDatabase.kt
A room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/util/KClassUtilTest.kt
M room/room-runtime/src/jvmAndroidMain/kotlin/androidx/room/util/KClassUtil.jvmAndroid.kt
https://android-review.googlesource.com/3106237
Branch: androidx-main
commit 3eb053061ebd600de2ce0d13994c7f227711b21e
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue May 28 09:54:27 2024
Fix find database impl reflection when class has no package.
Handle the Android only (not reproducible in JVM) case when a class has no package and the getPackage() call on the Class returns null.
Bug: 342097292
Test: KClassUtilTest
Change-Id: Ie04a62cb42e9d3e9a1badb4b66030851df22b01f
A room/room-runtime/src/androidInstrumentedTest/kotlin/NoPackageDatabase.kt
A room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/util/KClassUtilTest.kt
M room/room-runtime/src/jvmAndroidMain/kotlin/androidx/room/util/KClassUtil.jvmAndroid.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ed9cc5573271288500a7f416520dc509d8047f0f
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Aug 08 13:41:08 2024
Use same visibility as expect declaration when generating RoomDatabaseConstructor
Bug: 358138953
Test: DatabaseObjectConstructorWriterKotlinCodeGenTest
Change-Id: I0b2bb1a590f48199e398f72ac2b881e1eceb571f
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseMigrationTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/DatabaseObjectConstructorWriter.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt
A room/room-compiler/src/test/test-data/kotlinCodeGen/actualDatabaseConstructor_internal.kt
https://android-review.googlesource.com/3213484
Branch: androidx-main
commit ed9cc5573271288500a7f416520dc509d8047f0f
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Aug 08 13:41:08 2024
Use same visibility as expect declaration when generating RoomDatabaseConstructor
Bug: 358138953
Test: DatabaseObjectConstructorWriterKotlinCodeGenTest
Change-Id: I0b2bb1a590f48199e398f72ac2b881e1eceb571f
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseMigrationTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/DatabaseObjectConstructorWriter.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt
A room/room-compiler/src/test/test-data/kotlinCodeGen/actualDatabaseConstructor_internal.kt
da...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-compiler:2.7.0-alpha07
Description
Version used: 2.7.0-alpha06
We are using Room in a KMP project where the Room database is not exposed outside the shared module. The newly added RoomDatabaseConstructor functionality forces us to make our Room database to have a public modifier thus exposing it outside our shared module. It would be nice if the generated RoomDatabaseConstructor copied the visibility modifier from the expect class.