[library desugar] Incorrect weekday name in Finnish [362277530]

Fixed

Bug

Status Update

No update yet.

Description

pi...@eliq.com

created issue #1

Aug 27, 2024 09:21AM

The day of the week is incorrectly formatted in the Finnish language when using the Core Desugaring library.

The code below incorrectly returns: 2 27. elokuuta 2024 when coreLibraryDesugaringEnabled = true in the app/build.gradle file.

When coreLibraryDesugaringEnabled = false, the result is correct: tiistai 27. elokuuta 2024

DateTimeFormatter.ofLocalizedDate(FormatStyle.FULL)
            .withLocale(Locale.forLanguageTag("fi-FI"))
            .format(LocalDate.now())

Steps to reproduce:

Clone the repository https://github.com/pchmielowski/DesugaringBug
Launch the application
The (incorrectly) formatted date is displayed in the launcher Activity
Disable desugaring (by setting coreLibraryDesugaringEnabled = false in the app/build.gradle file)
Launch the application again
Now the displayed date is a correct one

Versions:

coreLibraryDesugaring "com.android.tools:desugar_jdk_libs:2.1.0"
compileSdk 34

Comments

ch...@google.com <ch...@google.com> Aug 27, 2024 09:21AM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Aug 30, 2024 06:25PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3453829

Use Context.getDatabasePath() when a driver is configured.

Expand for full commit details

Use Context.getDatabasePath() when a driver is configured. 
 
This helps users migrating to driver APIs that use simple database names and expect Room to figure out the directory to store the database, for which the SupportSQLiteOpenHelper is responsible off when no driver is used. 
 
Since getDatabasePath() does some IO, a hook for the driver wrapper in the base connection manager was added so that the file name could be resolved, lazily and in the background thread where the connection is being opened. 
 
Lastly, if a bad path is used, a more proper error will be thrown instead of an obscure 'can't create file lock' since creating a file lock will first be attempted before actually creating / opening the actual database. 
 
Bug: 377830104 
Test: BuilderTest 
Change-Id: I833154e2855a38520e5a0e8c802964bd455000e8

Files:

M room/integration-tests/multiplatformtestapp/src/androidInstrumentedTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BuilderTest.kt
M room/room-runtime/src/androidMain/kotlin/androidx/room/RoomConnectionManager.android.kt
M room/room-runtime/src/commonMain/kotlin/androidx/room/RoomConnectionManager.kt
M room/room-runtime/src/commonMain/kotlin/androidx/room/concurrent/ExclusiveLock.kt

Hash: 35ddf21c6ede1af577d2d20b96107e04988b04e0
Date: Fri Jan 17 15:42:06 2025

sg...@google.com <sg...@google.com> #3Sep 4, 2024 08:42AM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.room:room-runtime:2.7.0-alpha13
androidx.room:room-runtime-android:2.7.0-alpha13
androidx.room:room-runtime-iosarm64:2.7.0-alpha13
androidx.room:room-runtime-iossimulatorarm64:2.7.0-alpha13
androidx.room:room-runtime-iosx64:2.7.0-alpha13
androidx.room:room-runtime-jvm:2.7.0-alpha13
androidx.room:room-runtime-linuxarm64:2.7.0-alpha13
androidx.room:room-runtime-linuxx64:2.7.0-alpha13
androidx.room:room-runtime-macosarm64:2.7.0-alpha13
androidx.room:room-runtime-macosx64:2.7.0-alpha13

Issue 362277530

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> Aug 27, 2024 09:21AM

ap...@google.com <ap...@google.com> #2Aug 30, 2024 06:25PM

sg...@google.com <sg...@google.com> #3Sep 4, 2024 08:42AM

Add comment

Issue metadata