AAOS programmatic access to VHAL not working via Car Service API [368059211]

Fixed

Bug

Status Update

No update yet.

Description

co...@accenture.com

created issue #1

Sep 18, 2024 06:09PM

The Car Service API allows programmatic access to the AAOS VHAL. The problem is that the https://android.googlesource.com/platform/external/qemu/+/emu-master-dev/android/android-grpc/services/incubating/car/proto/car_service.proto has the type for CarEvent as string whereas its expected as a byte string by AAOS.

The fix is to change the type from string to bytes. I've rebuilt the emulator on Linux and the fix is working fine with both python and node.js gRPC clients.

The following example python script can be used for reproducing the problem using a Linux emulator running an AAOS image (for example system-images;android-32;android-automotive-playstore;x86_64)

from __future__ import print_function
 
import logging
 
import grpc
import car_service_pb2
import car_service_pb2_grpc
import VehicleHalProto_pb2
 
def run():
    value = VehicleHalProto_pb2.VehiclePropValue(
        prop=287310853,
        int32_values=[1]
    )
 
    msg = VehicleHalProto_pb2.EmulatorMessage(
        msg_type=VehicleHalProto_pb2.MsgType.SET_PROPERTY_CMD,
        status=VehicleHalProto_pb2.Status.RESULT_OK,
        value=[value]
    )
 
    with grpc.insecure_channel("192.168.0.121:8554") as channel:
        stub = car_service_pb2_grpc.CarServiceStub(channel)
        response = stub.sendCarEvent(car_service_pb2.CarEvent(data=msg.SerializeToString()))
    print(response)
 
if __name__ == "__main__":
    logging.basicConfig()
    run()

Comments

sa...@google.com <sa...@google.com> Sep 18, 2024 07:23PM

Assigned to an...@google.com.

rk...@google.com <rk...@google.com> Sep 18, 2024 07:59PM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> #2Sep 23, 2024 02:47AM

Reassigned to ja...@google.com.

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

si...@google.com <si...@google.com> #3Sep 23, 2024 02:48AM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

Message last modified on Sep 23, 2024 02:49AM

si...@google.com <si...@google.com> #4Sep 23, 2024 02:49AM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

co...@accenture.com <co...@accenture.com> #5Sep 23, 2024 10:13AM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

si...@google.com <si...@google.com> #6Sep 24, 2024 05:31AM

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.

Message last modified on Sep 24, 2024 07:33AM

si...@google.com <si...@google.com> #7Sep 25, 2024 07:40AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 567b7459329d1ec8d27a8c6fe1c4a86442065d7d
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 26 20:06:54 2023

Add additional logging for transitions

Adding more debug logging in transitions to track the entering and
exiting transitions as well as the final merged transition and its
targets.

Test: added logging
Bug: 300157785
Change-Id: I0d9ad72b865422493c6c895ddb6115abf85eed16

M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt

https://android-review.googlesource.com/2763868