AAOS programmatic access to VHAL not working via Car Service API [368059211]

Fixed

Bug

Status Update

No update yet.

Description

co...@accenture.com

created issue #1

Sep 18, 2024 06:09PM

The Car Service API allows programmatic access to the AAOS VHAL. The problem is that the https://android.googlesource.com/platform/external/qemu/+/emu-master-dev/android/android-grpc/services/incubating/car/proto/car_service.proto has the type for CarEvent as string whereas its expected as a byte string by AAOS.

The fix is to change the type from string to bytes. I've rebuilt the emulator on Linux and the fix is working fine with both python and node.js gRPC clients.

The following example python script can be used for reproducing the problem using a Linux emulator running an AAOS image (for example system-images;android-32;android-automotive-playstore;x86_64)

from __future__ import print_function
 
import logging
 
import grpc
import car_service_pb2
import car_service_pb2_grpc
import VehicleHalProto_pb2
 
def run():
    value = VehicleHalProto_pb2.VehiclePropValue(
        prop=287310853,
        int32_values=[1]
    )
 
    msg = VehicleHalProto_pb2.EmulatorMessage(
        msg_type=VehicleHalProto_pb2.MsgType.SET_PROPERTY_CMD,
        status=VehicleHalProto_pb2.Status.RESULT_OK,
        value=[value]
    )
 
    with grpc.insecure_channel("192.168.0.121:8554") as channel:
        stub = car_service_pb2_grpc.CarServiceStub(channel)
        response = stub.sendCarEvent(car_service_pb2.CarEvent(data=msg.SerializeToString()))
    print(response)
 
if __name__ == "__main__":
    logging.basicConfig()
    run()

Comments

sa...@google.com <sa...@google.com> Sep 18, 2024 07:23PM

Assigned to an...@google.com.

rk...@google.com <rk...@google.com> Sep 18, 2024 07:59PM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> #2Sep 23, 2024 02:47AM

Reassigned to ja...@google.com.

Adding 2 more thread dumps from another freeze. Again after switching branches and updating from git.

si...@google.com <si...@google.com> #3Sep 23, 2024 02:48AM

Thanks for the report. I believe that this is fixed in our development branch, and also in the branch that will become Ladybug Feature Drop Beta. If you could verify that this doesn't happen in a nightly build (from https://developer.android.com/studio/nightly) that would be helpful -- and of course if you can trigger this in a recent nightly build, that's would be very important information.

Message last modified on Sep 23, 2024 02:49AM

si...@google.com <si...@google.com> #4Sep 23, 2024 02:49AM

Sorry, I have not tried it on the nightly build, but since then I updated to Meerkat and I have not seen the freeze afterwards.

co...@accenture.com <co...@accenture.com> #5Sep 23, 2024 10:13AM

That's good to hear. I think that the fix (which for reference was https://github.com/JetBrains/intellij-community/commit/fe621544dd61a9af34d97958d3d823a7c3454a87) is effective for both beta and canary branches.

For the record I am also arranging for https://github.com/JetBrains/intellij-community/commit/a444c8a500883669fc05c7177f93b5b794fdd13b (same fix, different implementation class) to be included; it's probably inactive code in our configurations, but it might be possible to trigger nevertheless.

Thanks for the confirmation!

si...@google.com <si...@google.com> #6Sep 24, 2024 05:31AM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 RC 1
Android Gradle Plugin 8.8.0-rc01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

Message last modified on Sep 24, 2024 07:33AM

si...@google.com <si...@google.com> #7Sep 25, 2024 07:40AM

Marked as fixed.

Ucfucuccj