Status Update
Comments
hc...@google.com <hc...@google.com> #2
Branch: androidx-master-dev
commit b4a3fe1d53c8c8082cf16795da164c446f7fd912
Author: Ian Lake <ilake@google.com>
Date: Wed Jul 15 14:34:08 2020
Add a hook that fires before the Activity's super.onCreate()
Provide a standard, composable API for libraries and
developers to run code as soon as possible after a
Context is available to an Activity (i.e., before the
logic in the base Activity.onCreate() runs and before any
layout is inflated).
This updates the code in FragmentActivity and
AppCompatActivity to use that new API.
Test: new activity tests pass
Test: existing fragment and appcompat tests still pass
BUG: 161390636
Relnote: "`ComponentActivity` now implements
`ContextAware`, allowing you to add one or more
`OnContextAvailableListener` instances which will
receive a callback before the base `Activity.onCreate()`."
Change-Id: I513da73bc0862b62af4166be35ba353fc7869a09
M activity/activity/api/1.2.0-alpha07.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha07.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha07.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityLifecycleTest.kt
A activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
A activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.java
A activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.java
A activity/activity/src/main/java/androidx/activity/contextaware/OnContextAvailableListener.java
M appcompat/appcompat/build.gradle
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatActivity.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
sa...@gmail.com <sa...@gmail.com>
pe...@google.com <pe...@google.com> #3
Branch: androidx-master-dev
commit 494d98d48e3c95c4338bda7ed1bf46797de257f6
Author: Ian Lake <ilake@google.com>
Date: Mon Aug 03 13:07:36 2020
Deliver the Context when added after it is available
Previously, an OnContextAvailableListener would only
receive a callback if added prior to the Context
being made available.
Rather than allow developers fall into a pitfall
where they add a listener and never receive a
callback, synchronously deliver the currently
available Context to listeners.
Test: updated activity tests pass
BUG: 161390636
Relnote: N/A
Change-Id: I24eff02712c90e84e1998407082e0b07cf04b44a
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.java
sa...@gmail.com <sa...@gmail.com> #4 Restricted+
sa...@gmail.com <sa...@gmail.com> #5
Branch: androidx-master-dev
commit d830158f1671930bab215716e329349a42eec1dd
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 31 14:14:29 2020
Add suspending withContextAvailable to ContextAware
Expand the ContextAware interface to allow developers
to synchronously peek to see if the context is
availble.
This allows us to write a Kotlin extension
withContextAvailable() that runs a non-suspending
block once the context becomes available (either
synchronously if it is already available or by
using a OnContextAvailableListener under the hood
if not).
Test: new tests pass
BUG: 161390636
Relnote: "Added a `peekAvailableContext()` API to
`ContextAware` to allow you to synchronously determine
if a Context is available. A suspending Kotlin extension
`withContextAvailable()` allows you to run a
non-suspending block when the Context becomes available
and return a result."
Change-Id: I8290cd9de8231913036d23a233c177ed45d2d370
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
M activity/activity-ktx/api/restricted_current.txt
A activity/activity-ktx/src/androidTest/java/androidx/activity/contextaware/ContextAwareTest.kt
A activity/activity-ktx/src/main/java/androidx/activity/contextaware/ContextAware.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.java
ca...@chromium.org <ca...@chromium.org> #6
The new ContextAware
API will be available in Activity 1.2.0-alpha08 and is used by Fragment 1.3.0-alpha08 and AppCompat 1.3.0-alpha02 to implement FragmentManager's and AppCompatDelegate's pre-onCreate() logic.
pe...@google.com <pe...@google.com> #7
Wait, this can't work as advertised.
FragmentActivity extends ComponentActivity
public FragmentActivity(@LayoutRes int contentLayoutId) {
super(contentLayoutId);
init();
}
private void init() {
addOnContextAvailableListener(new OnContextAvailableListener() {
// ...
}
}
ComponentActivity
@Override
protected void onCreate(@Nullable Bundle savedInstanceState) {
// ...
mContextAwareHelper.dispatchOnContextAvailable(this);
super.onCreate(savedInstanceState);
//...
}
- Call
FragmentActivity
constructor, - which calls
ComponentActivity
super constructor, - which dispatches context available... to noone,
- and calls platform Activity.onCreate.
- Bubble up to
FragmentActivity
constructor and register context listener, - which is invoked synchronously but only after platform
Activity.onCreate
has already been called.
Did I miss something? I'm confused.
pe...@google.com <pe...@google.com> #8
Never mind, constructor vs onCreate. :facepalm: Sorry.
pe...@google.com <pe...@google.com> #9
Re #8 - the fact that these are different things is indeed exactly why this API exists :)
am...@chromium.org <am...@chromium.org> #11
If this is a bypass of crbug.com/333708039 it would have been introduced much earlier than M130 or at least by the fix for that issue (
pe...@google.com <pe...@google.com> #12
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.
If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security Impact hotlist or the Severity field, and remove the ReleaseBlock hotlist.
sa...@gmail.com <sa...@gmail.com> #13
setTimeout("document.getElementById('x').style.opacity='5%'",300);
change the time (300ms) to be bigger for example : 400,500,etc
pe...@google.com <pe...@google.com> #14
szager: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?
If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?
If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.
Thanks for your time! To disable nags, add Disable-Nags (case sensitive) to the Chromium Labels custom field.
sz...@chromium.org <sz...@chromium.org> #15
I'm not able to reproduce any actual exploit from this. When I click on the button multiple times, eventually I get a "Sign in with Google" popup window asking for confirmation. As long as I "cancel" that, the login fails. I believe the popup window is evidence of the fact that the iframe detected that it was not visible; otherwise it would have permitted the authentication without showing a popup.
I'll leave this open for another week to gather feedback, in case I'm missing something.
sa...@gmail.com <sa...@gmail.com> #16
Chrome Version 131.0.6768.4 (Official Build) dev (64-bit)
Chrome Version 132.0.6788.0 (Official Build) canary (64-bit)
sz...@chromium.org <sz...@chromium.org> #17
I was able to reproduce this by using a longer setTimeout delay; I have a fix in review.
ap...@google.com <ap...@google.com> #18
Project: chromium/src
Branch: main
Author: Stefan Zager <
Link:
IntersectionObserver -- properly handle "unknown" occlusion state
Expand for full commit details
IntersectionObserver -- properly handle "unknown" occlusion state
If we most recently reported a target as "guaranteed visible", then in
the interest of avoiding false positives we must transition to "not
guaranteed visible" if the frame occlusion state becomes "unknown".
This CL also makes a child frame inherit its parent's "not visible"
occlusion state rather than calling it "unknown", which is technically
more correct.
Bug: chromium:371247941
Change-Id: I4d721dd252d013deac14a12f1f2922830ef2a8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950965
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373093}
Files:
- M
third_party/blink/renderer/core/frame/frame_view.cc
- M
third_party/blink/renderer/core/intersection_observer/intersection_observation.cc
- A
third_party/blink/web_tests/external/wpt/intersection-observer/resources/v2-midframe.sub.html
- M
third_party/blink/web_tests/external/wpt/intersection-observer/resources/v2-subframe.html
- A
third_party/blink/web_tests/external/wpt/intersection-observer/v2/nested-cross-origin.sub.html
Hash: 7b2e3f7ff30d5dcf17cd5c00f0554a44eec2c2a1
Date: Thu Oct 24 02:35:39 2024
sa...@gmail.com <sa...@gmail.com> #19
sz...@chromium.org <sz...@chromium.org> #20
It should be fixed in current Canary channel Chrome; it will reach Dev channel in about a week.
sa...@gmail.com <sa...@gmail.com> #21 Restricted+
sz...@chromium.org <sz...@chromium.org>
pe...@google.com <pe...@google.com> #22
The NextAction date has arrived: 2024-10-28 To opt-out from this automation rule, please add Optout-Blintz-Nextaction-Alert to the "Chromium Labels" custom field.
sa...@gmail.com <sa...@gmail.com> #23
am...@chromium.org <am...@chromium.org> #24
Hello, this is in our queue, but there have been a number of high severity issues for us to assess in the last few weeks. This issue should be assessed this week or next. As always, when assessment has taken place a reward decision will be provided here. Thank you for you patience in the meantime.
sp...@google.com <sp...@google.com> #25
Hello,
Congratulations! The Chrome Vulnerability Rewards Program (VRP) Panel has decided to award you $5000.00 for this report.
Rationale for this decision:
report of moderate impact security UI spoof
Important: If you aren't already registered with Google as a supplier, p2p-vrp@google.com will reach out to you. If you have registered in the past, no need to repeat the process – you can sit back and relax, and we will process the payment soon.
If you have any payment related requests, please direct them to p2p-vrp@google.com. Please remember to include the subject of this email and the email address that the report was sent from.
Thank you for your efforts and helping us make Chrome more secure for all users!
Cheers,
Chrome VRP Panel Bot
P.S. One other thing we'd like to mention:
* Please do NOT publicly disclose details until a fix has been released to all our users. Early public disclosure may cancel the provisional reward. Also, please be considerate about disclosure when the bug affects a core library that may be used by other products. Please do NOT share this information with third parties who are not directly involved in fixing the bug. Doing so may cancel the provisional reward. Please be honest if you have already disclosed anything publicly or to third parties. Lastly, we understand that some of you are not interested in money. We offer the option to donate your reward to an eligible charity. If you prefer this option, let us know and we will also match your donation - subject to our discretion. Any rewards that are unclaimed after 12 months will be donated to a charity of our choosing.
Please contact security-vrp@chromium.org with any questions.
am...@chromium.org <am...@chromium.org> #26
Congratulations Hafiizh! Thank you for your efforts and reporting this issue to us.
sa...@gmail.com <sa...@gmail.com> #27
am...@chromium.org <am...@chromium.org> #28
the original content of this report was set as restricted content
; which should not be a setting used for the information in a Chrome security bug report, the following is the content from the original report:
===================== VULNERABILITY DETAILS============
This vulnerability is similar to
VERSION Chrome Version 131.0.6755.0 (Official Build) canary (64-bit) Operating System: Windows 10
REPRODUCTION CASE
qk...@google.com <qk...@google.com> #29
[1]
pe...@google.com <pe...@google.com> #30
This bug has been closed for more than 14 weeks. Removing issue access restrictions.
Description