Compose 1.8 snapshot 12425984 break Dialogs in ModalBottomSheet on Samsung devices [373093006]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Oct 14, 2024 06:46AM

Jetpack Compose version: 1.8 SNAPSHOT : 12425984

The CL https://android-review.googlesource.com/c/platform/frameworks/support/+/3272334 have broken dialogs shown from BottomSheets on Samsung Android 14 devices at least.

Snapshot 12425888 does not exhibit this behavior.

Repo: Show a Dialog/AlertDialog from a ModalBottomSheet from a recent M3 (So after the popup rewrite).

While this is probably a Samsung Bug (See the SAF confirmation screenshot that have the dialog at the bottom too), this is problematic as the M3 alert dialogs does not allow to pass a modifier to at least set contentSafePadding().

So if you consider that this is fully Samsung bug, it would be nice that this was reaffected to M3 to ensure the dialog can have safe paddings.

saf.png

97 KB

View

Download

after.png

103 KB

View

Download

before.png

106 KB

View

Download

Comments

to...@gmail.com <to...@gmail.com> #2Oct 14, 2024 10:03AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ae09f6e6686b32c5677c086d51d5737553e2aeb9
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1373433

Screen_Recording_20241014_114421.mp4

3.4 MB

Download

lp...@google.com <lp...@google.com> Oct 14, 2024 12:45PM

Reassigned to mo...@google.com.

mo...@google.com <mo...@google.com> #3Oct 14, 2024 05:51PM

We've fixed this internally and are preparing a DrawerLayout 1.1.1 release with this fix.

to...@gmail.com <to...@gmail.com> #4Oct 14, 2024 06:14PM

Project: platform/frameworks/support
Branch: snap-temp-L48600000649720827

commit 6e863d72d89137a408907be4c44f5444b51f8dab
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1374836

Message last modified on Oct 14, 2024 06:15PM

mo...@google.com <mo...@google.com> #5Oct 16, 2024 04:15PM

Project: platform/frameworks/support
Branch: snap-temp-L11100000649726887

commit 4b1419f8d1c41233b1af357a178c1eb6e71e3fb0
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1374876

to...@gmail.com <to...@gmail.com> #6Oct 16, 2024 04:25PM

Project: platform/frameworks/support
Branch: snap-temp-L37200000649809909

commit 8e12fa9761f7d1ad254bd278392ed2020de2cec1
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1375018

mo...@google.com <mo...@google.com> #7Oct 16, 2024 05:58PM

Project: platform/frameworks/support
Branch: snap-temp-L59700000649811929

commit 8c0814d1467e02e617f002b61b09a5737a3a1e94
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1375020

to...@gmail.com <to...@gmail.com> #8Oct 16, 2024 06:00PM

Project: platform/frameworks/support
Branch: snap-temp-L27600000649911717

commit 63fcaff3662ea1236d84e644362f35b7618b56dd
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1375064

mo...@google.com <mo...@google.com> #9Oct 16, 2024 06:08PM

Project: platform/frameworks/support
Branch: snap-temp-L68100000649916060

commit e33fcbc8c30a40594cfcfbb643018e2bfe024820
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1375066

to...@gmail.com <to...@gmail.com> #10Oct 16, 2024 06:20PM

Project: platform/frameworks/support
Branch: snap-temp-L86900000650841826

commit 3ad4cab4e570828fddbf650934a4e9efdd8405e0
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1377801

mo...@google.com <mo...@google.com> #11Oct 16, 2024 06:26PM

Project: platform/frameworks/support
Branch: snap-temp-L89900000650843240

commit 978cae5a010bf4c0c1b6fcfd68fd1b1c7802e126
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1378183

to...@gmail.com <to...@gmail.com> #12Oct 16, 2024 06:42PM

Project: platform/frameworks/support
Branch: snap-temp-L89900000650864753

commit 2754768be7ccfd570f9355ab74406157e3a69d92
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1378185

to...@gmail.com <to...@gmail.com> #13Oct 17, 2024 07:32AM

The following changes were cherrypicked through Coastguard
Release Track: 5549033339944960
Changes: aosp/1373433

fillMaxSizePlatform.png

238 KB

View

Download

fillMaxSizeLandPlatform.png

252 KB

View

Download

fillMaxSizeLand.png

127 KB

View

Download

fillMaxHeightLand.png

159 KB

View

Download

fillMaxHeight.png

242 KB

View

Download

fillMaxSize.png

228 KB

View

Download

to...@gmail.com <to...@gmail.com> #14Oct 17, 2024 08:25AM

The following changes were cherrypicked through Coastguard
Release Track: 6205454677704704
Changes: aosp/1378185

plaformnoanimate.png

255 KB

View

Download

platformanimate.png

246 KB

View

Download

to...@gmail.com <to...@gmail.com> #15Oct 17, 2024 08:47AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c403da82b263cf8078bacafb9f4661e279a3089c
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 06 13:24:40 2020

Update navigation-ui to depend on DrawerLayout 1.1.1

DrawerLayout 1.1.1 includes a fix to the open()
call used by NavigationUI when locking the drawer.

Test: tested as part of

b/162253907

Relnote: "`navigation-ui` now depends on
[DrawerLayout 1.1.1](/jetpack/androidx/releases/drawerlayout#1.1.1),
ensuring that `NavigationUI` is able to open the drawer
even when using `LOCK_MODE_LOCKED_CLOSED` or
`LOCK_MODE_LOCKED_OPEN`."

Change-Id: Ie2eeec35770138e9d69396c0eea3c1a45e7d757b

M navigation/navigation-ui/build.gradle

https://android-review.googlesource.com/1451099

Message last modified on Oct 17, 2024 08:56AM

works.mp4

1.4 MB

Download

notwork.mp4

1.8 MB

Download

ap...@google.com <ap...@google.com> #16Oct 18, 2024 05:19PM

Marked as fixed.

The following changes were cherrypicked through Coastguard
Release Track: 6205454677704704
Changes: aosp/1451099

to...@gmail.com <to...@gmail.com> #17Oct 18, 2024 05:43PM

Can we discuss the other issues too?

to...@gmail.com <to...@gmail.com> #18Oct 24, 2024 07:41AM

I guess that's a no and I documented all the issues for nothing.

pr...@google.com <pr...@google.com> #19Oct 30, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.8.0-alpha05
androidx.compose.ui:ui-android:1.8.0-alpha05
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha05
androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha05

de...@gmail.com <de...@gmail.com> #20Dec 21, 2024 10:22AM

How does setting gravity CENTER solve any of the issues? On a Samsung device the dialogs are all stuck at center, even those that I set gravity to the bottom and no animation shows.

Issue 373093006

Description

Issue summary

Comments

to...@gmail.com <to...@gmail.com> #2Oct 14, 2024 10:03AM

lp...@google.com <lp...@google.com> Oct 14, 2024 12:45PM

mo...@google.com <mo...@google.com> #3Oct 14, 2024 05:51PM

to...@gmail.com <to...@gmail.com> #4Oct 14, 2024 06:14PM

mo...@google.com <mo...@google.com> #5Oct 16, 2024 04:15PM

to...@gmail.com <to...@gmail.com> #6Oct 16, 2024 04:25PM

mo...@google.com <mo...@google.com> #7Oct 16, 2024 05:58PM

to...@gmail.com <to...@gmail.com> #8Oct 16, 2024 06:00PM

mo...@google.com <mo...@google.com> #9Oct 16, 2024 06:08PM

to...@gmail.com <to...@gmail.com> #10Oct 16, 2024 06:20PM

mo...@google.com <mo...@google.com> #11Oct 16, 2024 06:26PM

to...@gmail.com <to...@gmail.com> #12Oct 16, 2024 06:42PM

to...@gmail.com <to...@gmail.com> #13Oct 17, 2024 07:32AM

to...@gmail.com <to...@gmail.com> #14Oct 17, 2024 08:25AM

to...@gmail.com <to...@gmail.com> #15Oct 17, 2024 08:47AM

ap...@google.com <ap...@google.com> #16Oct 18, 2024 05:19PM

to...@gmail.com <to...@gmail.com> #17Oct 18, 2024 05:43PM

to...@gmail.com <to...@gmail.com> #18Oct 24, 2024 07:41AM

pr...@google.com <pr...@google.com> #19Oct 30, 2024 05:37PM

de...@gmail.com <de...@gmail.com> #20Dec 21, 2024 10:22AM

Add comment

Issue metadata