IssueTracker

Also, it would be great to return Observable, cause Flowable has some overhead.

We are going to add Single for queries (and Maybe) but for @insert, @Update and @Delete it is a bit more tricky because we would be reading those values when the computable runs, in which case developer may change them by mistake. We've not decided whether we want to take that risk or not. (We could copy but that would be additional hidden load, especially if the input is a long list).

#2, flowable can easily turn into an observable, would you like to escalate on why you think the overhead is a problem?

Cool for Single/Maybe for queries :)

For @insert, @Update and @Delete I personally would like to have the possibility to have Single/Maybe... because I will 100% of the time wrap the call into a Single to make it asynchronous and have the possibility to chain other actions with it. I understand that copying entries will take additional resources but in that case we'll have the possibility to not use the RX return type.

That my opinion ^^
Thanks !

Shouldn't this be typed as a feature request?

https://issuetracker.google.com/issues/67770289 should probably be merged here and closed.

This issue is half year old and it's still not implemented. Without this the library is unusable.

+1

+1 Here as well.  I would like Completable support.

+1 i think Completable support is necessary

+1 for Completable support as well

+1 for completable - just missed it on the fly while coding

+1 for Completable support as well

+1 for completable for @Delete @Update and @Insert

+1 for Completable support as well

Please Give a star instead of adding new comments.

This would be a nice improvement!

My initial response is to wrap the insert in a Completable when exposing the call to a consumer because of the time spent writing to the file system on the main thread. Guessing would probably desire the same API for delete.

Out of the box without LiveData/RxJava support for those types of calls it would violate strict rules and run into the guards of Room ensures that database is never accessed on the main thread.

It's really necessary thing and it's not implemented still(

+1 Come on we need support for completable. its been more than an year :(

we are targeting this for 2.1.

+1 for completable for @Delete @Update and @Insert

+1 Come on guys!! ^_^

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c0c36b71b1e73eeaa49e5f29c2e3ee3923c811da
Author: Florina Muntenescu <florinam@google.com>
Date:   Wed Aug 15 10:49:18 2018

    Refactoring insert/update/delete to allow extensibility around the return type
   
    Bug: 63317956
    Test: tests updated
    Change-Id: I5f8168fbd5cf08e64cb80c1835f4eebef6b4e018

M       room/compiler/src/main/kotlin/androidx/room/processor/DeletionMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/InsertionMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/UpdateMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/DeleteOrUpdateMethodBinder.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InsertMethodBinder.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InstantDeleteOrUpdateMethodBinder.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InstantInsertMethodBinder.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/DeleteOrUpdateMethodBinderProvider.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InsertMethodBinderProvider.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantDeleteOrUpdateMethodBinderProvider.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantInsertMethodBinderProvider.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/DeleteOrUpdateMethodAdapter.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/InsertMethodAdapter.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/DeletionMethod.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/InsertionMethod.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/ShortcutMethod.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/UpdateMethod.kt
M       room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/DeletionMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/InsertionMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/UpdateMethodProcessorTest.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt

https://android-review.googlesource.com/732628
https://goto.google.com/android-sha1/c0c36b71b1e73eeaa49e5f29c2e3ee3923c811da

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 524c841aa2bec6fa72768b1aeb40f6c6b6734907
Author: Florina Muntenescu <florinam@google.com>
Date:   Mon Sep 03 16:37:48 2018

    Adding RxJava support to insert
   
    Bug: 63317956
    Change-Id: Ic122774f591319dcd70d7f362af94adb0342184b
    Test: InsertionMethodProcessorTest and TypeAdapterStoreTest updated

M       room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/InsertionMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/RxCallableInsertMethodBinder.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InsertMethodBinderProvider.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantInsertMethodBinderProvider.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/RxCallableInsertMethodBinderProvider.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/InsertMethodAdapter.kt
A       room/compiler/src/test/data/common/input/rxjava2/Completable.java
A       room/compiler/src/test/data/common/input/rxjava2/Maybe.java
A       room/compiler/src/test/data/common/input/rxjava2/Single.java
M       room/compiler/src/test/kotlin/androidx/room/processor/InsertionMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt

https://android-review.googlesource.com/745108
https://goto.google.com/android-sha1/524c841aa2bec6fa72768b1aeb40f6c6b6734907

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ecce72935bbe7987a9c0c1639f4aa245153c717a
Author: Florina Muntenescu <florinam@google.com>
Date:   Fri Sep 07 15:36:18 2018

    Add RxJava support for Delete and Update methods in Room.
   
    Support for update and delete returning Integer also added.
    Now, update and delete support:
    * void
    * int
    * Integer
    * Completable
    * Single<Integer>
    * Maybe<Integer>
   
    Refactored the DeleteOrUpdateMethodAdapter to hold the return type, like InsertMethodAdapter is.
   
    Bug: 63317956
    Test: DaoWriterTest, TypeAdapterStoreTest, kotlin integration tests
    Change-Id: Ic8d3cff21b9e8179fed237a18421c13b3e59059b

M       room/compiler/src/main/kotlin/androidx/room/processor/DeletionMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/UpdateMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/DeleteOrUpdateMethodBinder.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InstantDeleteOrUpdateMethodBinder.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/RxCallableDeleteOrUpdateMethodBinder.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/DeleteOrUpdateMethodBinderProvider.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantDeleteOrUpdateMethodBinderProvider.kt
A       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/RxCallableDeleteOrUpdateMethodBinderProvider.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/DeleteOrUpdateMethodAdapter.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/DeletionMethod.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/ShortcutMethod.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/UpdateMethod.kt
M       room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M       room/compiler/src/test/data/common/input/rxjava2/Completable.java
M       room/compiler/src/test/data/common/input/rxjava2/Maybe.java
M       room/compiler/src/test/data/common/input/rxjava2/Single.java
M       room/compiler/src/test/data/daoWriter/input/DeletionDao.java
M       room/compiler/src/test/data/daoWriter/input/UpdateDao.java
M       room/compiler/src/test/data/daoWriter/output/DeletionDao.java
M       room/compiler/src/test/data/daoWriter/output/UpdateDao.java
M       room/compiler/src/test/kotlin/androidx/room/processor/ShortcutMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M       room/compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt

https://android-review.googlesource.com/750573
https://goto.google.com/android-sha1/ecce72935bbe7987a9c0c1639f4aa245153c717a

Support for Single, Maybe and Completable added for insert, update and delete. To be released in Room 2.1

When is Room 2.1 going to be released?

artifact was moved to
https://mvnrepository.com/artifact/androidx.room

Yes, that is correct.

"We should break the build until the support for legacy multidex test apk is added."

This causes quite a bit of pain for my team. We currently have a test apk with more than 65k referenced methods (we're already running proguard on the test apk), and we're depending on it building properly. Our minSdkVersion is 18, but we only run our instrumentation tests on API 21+, so the old behavior allowed us to continue running our tests.

With the new behavior in AGP 3.0, our test apk fails to even build. It seems like my only options are:
1) Reduce the number of referenced methods
2) Create a new variant or flavor with minSdk 21+ and use that for running tests
3) Use minSdk 21 for all debug builds

The first option isn't really feasible, and the second is massively painful because it requires us to retrain 50+ devs on which gradle commands to use to run tests (since the commands change when adding a variant or flavor). The third option also isn't ideal because then we lose lint validation for our real minSdkVersion and lose the ability to easily run debug builds on older android versions manually.

Is there any way to keep the behavior from AGP 2.3.x for building test apks until a proper solution for legacy multidex is available?

@dr... for your specific situation, why not just stay on 2.3 until 2.4 (or 3.0) is out of alpha? Having 50 devs on alpha anything seems really iffy.

Yeah, definitely. We're not planning to upgrade until 3.0 is stable, but I'm worried that it will get to the stable channel without this being fixed. If legacy multidex support for test apks is ready before 3.0 is stable, then I don't have a problem :)

Hello,
since the multidex 1.0.2 is live I would expect that multidex works fine on api <21 for test apks, but this is not the case.
Did I misunderstand something when you said this will be backported to legacy multidex so test apk can contain multiple dex files also or?

classpath 'com.android.tools.build:gradle:3.0.0-alpha7'
multidex : '1.0.2',
Android Studio 3.0 Canary 7
Build #AI-171.4182969, built on July 14, 2017
JRE: 1.8.0_152-release-884-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.4

The support for legacy multidex test apks has been merged in AOSP, but a new version of com.android.support:multidex has not been published yet. We need this artifacts published in order to add support for legacy multidex test apks in the Android plugin for Gradle.

Hello,
Thank you for the answer but I don't understand what is inside multidex 1.0.2 then.

in support lib Revision 25.4.0 it is stated:
Concurrent with this support library release, we are also releasing multidex version 1.0.2. This version includes the following important changes:
Allows multidexing of instrumentation APK.
Deprecates MultiDexTestRunner (AndroidJUnitRunner should be used instead).

We use multidex 1.0.2. Does this mean this fix will come out in 1.0.3, do you have any eta window on this topic?

Cheers

Indeed, 1.0.2 contains all the necessary support, but the support in the plugin is missing. I will try to get the plugin changes published in the next few preview releases, but I cannot give any hard guarantees when it will happen.

Thank you for the clarification. Could you please update the documentation that the new support/ multidex lib is not integrated in tooling yet. Also in gradle build files lint recommends removing the "dev" flavor since it is not needed anymore but then it would break tests, instant run etc. also an important thing to note.
Looking forward to the integration let us know when you manage to merge it.
Have a nice weekend!

I am reopening this, as we have too many reports. It is blocked on internal issue b/62286076.

hello, what is the current progress of this issue?

thank you

@39 The support in the plugin is ready, however we need a new version of build tools published. Hopefully that will happen soon.

this is amazing news, could you please update the status of this ticket when this happens?

does this mean this will come out with beta4?

Build tools are published independently of the plugin and Android Studio, but I hope that will happen in the next week or two. I'll update the bug once it happens.

@42 1.0.2 does provide support for multidex android test APKs.

Simply create a "CustomerTestRunner" and override "onCreate" to call "MultiDex.installInstrumentation(context, targetContext)". See this example: https://github.com/jaredsburrows/android-gif-example/blob/master/src/androidTest/kotlin/test/CustomTestRunner.kt#L12.

It seems that multidex 1.0.2 works with multidex test apks for AGP 2.3.0, not 3.0.0+.

#44 Make sure you use ATSL runner 1.0.1 or later.

I am: https://github.com/jaredsburrows/android-gif-example/blob/master/gradle/versions.gradle.kts#L75.

We discovered this problem too. It's quite annoying for us and we will have to reverse switching to GAP 3 if there is no fix in the next 2 days...

Can anyone give us an update and an ETA for this ?
We use build tools 26.0.1, gap 3 beta 5, ASTL runner 1.0.1.

As a workaround, how can we run proguard on the instrumentation apk, when it is not enabled in our debug variant for the main app ?

You do not want to proguard a debug apk. It would take forever to write and
run new tests.

Jared Burrows

*jaredsburrows@gmail.com <jaredsburrows@gmail.com>*
LinkedIn: https://www.linkedin.com/in/jaredsburrows


On Thu, Sep 14, 2017 at 12:14 PM, <buganizer-system@google.com> wrote:

Until this issue is fixed, many apps will have no choice but to proguard their test apk :)

I agree, this workaround is not a good solution.

On our side, we fixed the issue by cutting down on our dependencies in the instrumentation apk. Though the dex count is still in the red zone and we will be happy to see the issue fix, but there is no more emergency on our side.

Fixed, bug tracking the release : https://buganizer.corp.google.com/issues/65838025

I see it is tracked in Moma. Is this set for marked release for 3.0.0-beta7? or release?

was the fix included in the latest release of build tools 26.1? I think the link to track the release is not public.

It still doesn't work for me on 3.0.0-beta7 and Build tools 26.0.2 - I still get the error.

Status says fixed but could we get instructions on how to make it work? Is this already included in Build tools 26.0.2 and AGP 3.0.0-beta7?

Same problem here... I don't see this issue as fixed

The issue has not been fixed in beta7, as build tools 26.0.2 are missing some of the pieces to have this working. Re-opening.

Thank you.

Is there an ETA? Looks like build tools 27.0.0 shipped without this fix.

Any ETA on this?  Or which components we should watch for updates?  Is the the build tools 2x.0.y?  Is it a new multidex support lib 1.0.3?  3.1 plugin?

Sorry, we don't commit to timelines on public bugs.

All the changes needed are submitted to the four components (build tools, MultidexTestRunner, AndroidJunitRunner and android gradle plugin) and we'll update this bug as soon as it is released, so it will be in Android Gradle Plugin 3.1.

Note that both the deprecated MultiDexTestRunner and the replacement AndroidJUnitRunner will support legacy multidex test APKs

Could you consider releasing the fix under 3.0.x (if that's even possible)?
Doing it in 3.1 will require everyone who wants to have multidex for test APK working to start using unstable version of AS and AGP.

Please update documentation to reflect that legacy multidex IS supported, except broken by this bug (known issue) in AGP 3.0.

https://developer.android.com/studio/build/multidex.html#testing

> `Using multidex to create a test APK is not currently supported.`

This is fixed starting with 3.1.0-alpha04. Please try it out, and let us know if you are facing any issues. Thanks!

Is it not "MultiDex.installInstrumentation(getContext(), getTargetContext());" in the AndroidJUnitRunner?

3.1.0-alpha04 worked for me.  Thanks for the fix.

I just trying with 3.1.0-alpha06 and the problem seams to still be there =/

This isn't working for me either with 3.1.0-alpha06. Can you clarify what was fixed, and what combination of Gradle, Android Gradle Plugin, Multidex library and Android Build Tools we should test against?

Folks, any news in this issue? Could you explain how to make this work? Simply using AGP 3.1.0-alpha04 doesn't solve the problem

Never mind. It does solve the problem

Re #70:
You need to use Android plugin for Gradle 3.1.0-alpha04+, any compatible version of Gradle (e.g. 4.4) and BuildTools (e.g. 27.0.3). Multidex library 1.0.2 will be added by the plugin as a dependency automatically. With this, your build will be successful.

To run tests successfully, the test runner needs to support legacy test APK. AndroidJUnitRunner supports that, so you can use that.

Looks much better but I still get an issue with multiDexKeepProguard file, it somehow feels it is not respected which classes should be added to the main dex file.
For example following your suggestion of tl;dr version the test crashes because some files are not found in the main dex file during the app start:

01-09 10:31:06.965 4861-4861/? W/dalvikvm: Class resolved by unexpected DEX: Ltimber/log/Timber$Tree;(0xa75def58):0x99f02000 ref [Lcom/google/devtools/build/android/desugar/runtime/ThrowableExtension;] Lcom/google/devtools/build/android/desugar/runtime/ThrowableExtension;(0xa75def58):0x99caf000
01-09 10:31:06.965 4861-4861/? W/dalvikvm: (Ltimber/log/Timber$Tree; had used a different Lcom/google/devtools/build/android/desugar/runtime/ThrowableExtension; during pre-verification)
01-09 10:31:06.965 4861-4861/? D/AndroidRuntime: Shutting down VM
01-09 10:31:06.965 4861-4861/? W/dalvikvm: threadid=1: thread exiting with uncaught exception (group=0xa66de228)
01-09 10:31:06.975 4861-4861/? E/InstrumentationResultPrinter: Failed to mark test No Tests as finished after process crash
01-09 10:31:06.975 4861-4861/? E/MonitoringInstr: Exception encountered by: Thread[main,5,main]. Dumping thread state to outputs and pining for the fjords.
                                                  java.lang.IllegalAccessError: Class ref in pre-verified class resolved to unexpected implementation
                                                      at timber.log.Timber$Tree.getStackTraceString(Timber.java:569)
                                                      at timber.log.Timber$Tree.prepareLog(Timber.java:544)
                                                      at timber.log.Timber$Tree.i(Timber.java:452)
                                                      at timber.log.Timber$1.i(Timber.java:288)
                                                      at timber.log.Timber.i(Timber.java:63)


Do you have any idea where does this pops out from?

Re #74:
This seems to be Java 8 specific bug, and I've filled https://issuetracker.google.com/71737186 to track this. Can we please continue discussion there?

We would love to use this fix, but we need a stable version of the gradle android plugin. When  will Gradle Android Plugin  3.1.0 be released ?

"Please " help me i want update oreo 8.0 without computer

The release note for 3.1.0 doesn't mention this issue, is it fixed ?

We are trying it and it looks like it's not working (though it used to be working in alpha04)

There is a bug of a new kind in 3.1 + related to instrumented APKs & multidex

Until recently we had a big module, with all our code + all our instrurmentation tests code. Then we could check and the plugin (3.1.alpha and 3.1) work well to enable multidex in tests apks.
But we recently dissociated this big module: one contains the production code, the other one contains the instrumentation code. And then, the new plugin breaks: we can still a multidex production app, but the instrumentation test apk is not generated. We hit the 65K limit and the build reports this as an issue. Also, the android test don't have a task: transformClassesWithMultidexlistFor<variant>AndroidTest

What can go wrong ?

To be more precise: we have one module named module_apk that contains:
* a few classes in production code
* quite a lot of classes of instrumentation tests

The module_apk wires together all other modules that are all library modules.

When adding multidexEnabled to module_apk, the production apk is multidexed, but not the test apk. There is no transform / task for the AndroidTest variant related to multidex.
When adding multidexEnabled to all default configuration of all modules, all of them have both instrumentation and production multidex tasks & transformations, all except module_apk...

We have no idea what is going wrong.

Re #81:
I've filled https://issuetracker.google.com/77183226, let's please continue discussion there. Thanks.

What went wrong:
Execution failed for task ':app:transformClassesWithMultidexlistForLive'.
> com.android.build.api.transform.TransformException: Error while generating the main dex list.

Re #83: Please file a new issue, as that is error indicates there is a main dex list task error for the application, not for the test.

Echoing #78. Our instrumented tests using multidex worked using the 3.0.0 version of the Android Plugin for gradle. Updated to 3.1.1 and it would just say empty test suite. I found this bug then reverted back to 3.1.0-alpha04 and the tests work again. Should this be working in 3.1.1?

We (whoever has a repro) should probably file a new issue against 3.1.1 referencing this issue. This has been "marked as Fixed" 3 times... so it's possible the current problems are far from the original.

Re #85, #86:

Yes, please file a new bug, and paste the link here. Issue in #78 was due to a custom plugin which would disable multidex. Thanks!

Cool. Created https://issuetracker.google.com/u/1/issues/78108767 for this