Support List<Enum> route parameters for type-safe navigation [375559962]

Fixed

Feature Request

Status Update

No update yet.

Description

cs...@supercharge.io

created issue #1

Oct 25, 2024 02:42PM

Component used: Navigation
Version used: 2.8.3

@Serializable
class MyRoute(
val platforms: List<Platform>
)

enum class Platform {
ANDROID, IOS
}

composable<MyRoute> { MyScreen() }

This will result in an exception:

java.lang.IllegalArgumentException: Route MyRoute could not find any NavType for argument platforms of type kotlin.collections.ArrayList - typeMap received was {}

Please support list of enums by default.

Comments

jb...@google.com <jb...@google.com> Oct 25, 2024 04:05PM

Assigned to cl...@google.com.

cs...@supercharge.io <cs...@supercharge.io> #2Oct 31, 2024 12:19PM

Would you accept external contributions for this ticket? I would gladly contribute implementation for this.

jb...@google.com <jb...@google.com> #3Oct 31, 2024 03:52PM

Absolutely, we'd be happy to accept a pull request for this if you'd like follow our contributing guide on Github.

cs...@supercharge.io <cs...@supercharge.io> #4Nov 8, 2024 03:10PM

I opened a pull request for this: https://github.com/androidx/androidx/pull/725

ap...@google.com <ap...@google.com> #5Nov 19, 2024 08:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Csaba Kozák <kozakcsabi@gmail.com>
Link: https://android-review.googlesource.com/3363931

[GH] Add support for List<Enum> arguments in typesafe navigation

Expand for full commit details

[GH] Add support for List<Enum> arguments in typesafe navigation 
 
## Proposed Changes 
 
Add support for List<Enum> arguments in typesafe navigation 
 
## Testing 
 
Test: ./gradlew navigation:navigation-common:test 
Test: ./gradlew navigation:navigation-common:cC 
Test: ./gradlew navigation:navigation-runtime:cC 
 
## Issues Fixed 
 
Fixes: 375559962 
 
This is an imported pull request from https://github.com/androidx/androidx/pull/725. 
 
Resolves #725 
Github-Pr-Head-Sha: 79289f5cd89a355aa44ac1a7190301cde1e03ae9 
GitOrigin-RevId: 5d12e8b036e98d45944806f1d16a00b0769b49e2 
Change-Id: Ie67dc9665634751da06fad21c93e9475627e7e62

Files:

M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteDecoderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
M navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavArgumentGeneratorTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

Hash: 061287da098c4249bbe0b3a10add04feb9bdf5ae
Date: Mon Nov 18 22:24:48 2024

cl...@google.com <cl...@google.com> #6Nov 19, 2024 09:00PM

Fixed externally and will be available in navigation 2.8.5

pr...@google.com <pr...@google.com> #7Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.9.0-alpha04
androidx.navigation:navigation-runtime:2.9.0-alpha04
androidx.navigation:navigation-common:2.8.5
androidx.navigation:navigation-runtime:2.8.5

cs...@supercharge.io <cs...@supercharge.io> #8Dec 12, 2024 09:22AM

The fix is missing from the release notes:
https://developer.android.com/jetpack/androidx/releases/navigation#2.8.5
https://developer.android.com/jetpack/androidx/releases/navigation#2.9.0-alpha04

Can you add it there, please?

Message last modified on Dec 12, 2024 09:23AM

il...@google.com <il...@google.com> #9Jan 17, 2025 11:23PM

We've added a note to the release notes - thanks again!

In the future, note that you can add a Relnote: line in the pull request's description to ensure it gets into the release notes automatically.

ko...@gmail.com <ko...@gmail.com> #10Feb 19, 2025 01:02PM

Thanks! I followed the Github contribution guide, there is no information about Relnote:, maybe it should be added there.