Support List<Enum> route parameters for type-safe navigation [375559962]

Fixed

Feature Request

Status Update

No update yet.

Description

cs...@supercharge.io

created issue #1

Oct 25, 2024 02:42PM

Component used: Navigation
Version used: 2.8.3

@Serializable
class MyRoute(
val platforms: List<Platform>
)

enum class Platform {
ANDROID, IOS
}

composable<MyRoute> { MyScreen() }

This will result in an exception:

java.lang.IllegalArgumentException: Route MyRoute could not find any NavType for argument platforms of type kotlin.collections.ArrayList - typeMap received was {}

Please support list of enums by default.

Comments

jb...@google.com <jb...@google.com> Oct 25, 2024 04:05PM

Assigned to cl...@google.com.

cs...@supercharge.io <cs...@supercharge.io> #2Oct 31, 2024 12:19PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

jb...@google.com <jb...@google.com> #3Oct 31, 2024 03:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

cs...@supercharge.io <cs...@supercharge.io> #4Nov 8, 2024 03:10PM

deleted

ap...@google.com <ap...@google.com> #5Nov 19, 2024 08:14PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

cl...@google.com <cl...@google.com> #6Nov 19, 2024 09:00PM

Fixed externally and will be available in navigation 2.8.5

pr...@google.com <pr...@google.com> #7Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.9.0-alpha04
androidx.navigation:navigation-runtime:2.9.0-alpha04
androidx.navigation:navigation-common:2.8.5
androidx.navigation:navigation-runtime:2.8.5

cs...@supercharge.io <cs...@supercharge.io> #8Dec 12, 2024 09:22AM

The fix is missing from the release notes:
https://developer.android.com/jetpack/androidx/releases/navigation#2.8.5
https://developer.android.com/jetpack/androidx/releases/navigation#2.9.0-alpha04

Can you add it there, please?

Message last modified on Dec 12, 2024 09:23AM

il...@google.com <il...@google.com> #9Jan 17, 2025 11:23PM

We've added a note to the release notes - thanks again!

In the future, note that you can add a Relnote: line in the pull request's description to ensure it gets into the release notes automatically.

ko...@gmail.com <ko...@gmail.com> #10Feb 19, 2025 01:02PM

Thanks! I followed the Github contribution guide, there is no information about Relnote:, maybe it should be added there.