Support List<Enum> route parameters for type-safe navigation [375559962]

Fixed

Feature Request

Status Update

No update yet.

Description

cs...@supercharge.io

created issue #1

Oct 25, 2024 02:42PM

Component used: Navigation
Version used: 2.8.3

@Serializable
class MyRoute(
val platforms: List<Platform>
)

enum class Platform {
ANDROID, IOS
}

composable<MyRoute> { MyScreen() }

This will result in an exception:

java.lang.IllegalArgumentException: Route MyRoute could not find any NavType for argument platforms of type kotlin.collections.ArrayList - typeMap received was {}

Please support list of enums by default.

Comments

jb...@google.com <jb...@google.com> Oct 25, 2024 04:05PM

Assigned to cl...@google.com.

cs...@supercharge.io <cs...@supercharge.io> #2Oct 31, 2024 12:19PM

alpha01? That's so old! :D

We've found the issue in alpha10 and are working on a fix.

jb...@google.com <jb...@google.com> #3Oct 31, 2024 03:52PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 37ed64d4de87bd4a4365f5c0dfee7b33c8043013
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jan 23 15:46:00 2019

Add missing import of parent Directions class in generated Safe Args.

When generating a parent direction action method in a child directions
class,correctly import the parent direction if its located in another
package. Both JavaPoet and KotlinPoet generate import statements but the
NavWriters were incorrectly creating the class name of the parent type,
specifically it missed the package name which caused the import to be
missing.

Bug: 123307342
Test: ./gradlew navigation:navigation-safe-args-gradle-plugin:test \
navigation:navigation-safe-args-generator:test

Change-Id: Ibeda7a7ec6f31bb1c860dfe1f5cd2a7e7ea6d47d

M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/LoginFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/RegisterFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/LoginFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/RegisterFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/nested_login_test.xml
M navigation/safe-args-gradle-plugin/src/test/test-data/app-project-kotlin/src/main/res/navigation/nav_nested_test.xml
A navigation/safe-args-gradle-plugin/src/test/test-data/app-project/src/main/res/navigation/nav_nested_test.xml

https://android-review.googlesource.com/883592

https://goto.google.com/android-sha1/37ed64d4de87bd4a4365f5c0dfee7b33c8043013

cs...@supercharge.io <cs...@supercharge.io> #4Nov 8, 2024 03:10PM

Hi, I'm still having the issue with 1.0.0-alpha11. Generated classes for fragments in nested navigation throws error for global actions.

ap...@google.com <ap...@google.com> #5Nov 19, 2024 08:14PM

Marked as fixed.

I am also having the issue with 1.0.0-alpha11. I'm going to see what the Kotlin generator does with this.

cl...@google.com <cl...@google.com> #6Nov 19, 2024 09:00PM

Re #4 and #5 - please file a new bug with a sample project that reproduces your issue.

pr...@google.com <pr...@google.com> #7Dec 11, 2024 06:27PM

Re #6 will do. I think it has to do with naming arguments with capital first letters but I'll see if I can make a minimal example app to demonstrate, as a new bug.

cs...@supercharge.io <cs...@supercharge.io> #8Dec 12, 2024 09:22AM

How do i fix this?

Message last modified on Dec 12, 2024 09:23AM

il...@google.com <il...@google.com> #9Jan 17, 2025 11:23PM

If you're working with Jetpack Navigation in Android and the generated classes don't import MainNavDirections, it usually points to an issue with your setup or the https://lillestromflytt.no/lager-lillestrom/ navigation component.If after all these steps the issue persists, consider invalidating caches and restarting Android Studio (File > Invalidate Caches / Restart), as sometimes cached data can cause problems with code generation.

ko...@gmail.com <ko...@gmail.com> #10Feb 19, 2025 01:02PM

It sounds like you are dealing with a coding issue, possibly in a web development or React project. If MainNavDirections isn't being imported in generated classes, you may need to explicitly import it in your files. If you provide more specific details about your setup and the context https://www.exploria.pk/tours/hunza-tour-packages/ in which MainNavDirections is used, I can offer more targeted assistance.