Room KMP - SQLException: Error code: 5, message: database is locked [380088809]

Assigned

Bug

Status Update

No update yet.

Description

ae...@gmail.com

created issue #1

Nov 20, 2024 11:21PM

Component used: RoomDB

Version used: Room - 2.7.0-alpha11, sqlite-bundled - 2.5.0-alpha11

Devices/Android versions reproduced on: Transsion Tecno, Nokia C21 Plus, Redmi A1+. Android 11-14.

Crash stack:

Fatal Exception: android.database.SQLException: Error code: 5, message: database is locked
       at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.nativeStep(BundledSQLiteStatement.jvmAndroid.kt)
       at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.access$nativeStep(BundledSQLiteStatement.jvmAndroid.kt)
       at androidx.sqlite.driver.bundled.BundledSQLiteStatement.step(BundledSQLiteStatement.jvmAndroid.kt:100)
       at androidx.sqlite.SQLite.execSQL(SQLite.kt:58)
       at androidx.room.coroutines.PooledConnectionImpl.endTransaction(ConnectionPoolImpl.kt:418)
       at androidx.room.coroutines.PooledConnectionImpl.transaction(ConnectionPoolImpl.kt:386)
       at androidx.room.coroutines.PooledConnectionImpl.withTransaction(ConnectionPoolImpl.kt:342)
       at androidx.room.TriggerBasedInvalidationTracker$syncTriggers$2$1.invokeSuspend(InvalidationTracker.kt:297)
       at androidx.room.TriggerBasedInvalidationTracker$syncTriggers$2$1.invoke(InvalidationTracker.kt:12)
       at androidx.room.TriggerBasedInvalidationTracker$syncTriggers$2$1.invoke(InvalidationTracker.kt:12)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invokeSuspend(ConnectionPoolImpl.kt:143)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invoke(ConnectionPoolImpl.kt:12)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invoke(ConnectionPoolImpl.kt:12)
       at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:42)
       at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(BuildersKt__Builders_common.kt:164)
       at kotlinx.coroutines.BuildersKt.withContext(Builders.kt:1)
       at androidx.room.coroutines.ConnectionPoolImpl.useConnection(ConnectionPoolImpl.kt:143)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$1.invokeSuspend(ConnectionPoolImpl.kt:13)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:28)
       at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:100)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
       at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.java:113)
       at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
       at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.java:589)
       at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:823)
       at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
       at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)

Please fix it.

Comments

ae...@gmail.com <ae...@gmail.com> #2Nov 30, 2024 01:29AM

Some movements happening on KAPT with regards to this:

https://github.com/JetBrains/kotlin/pull/2179

el...@google.com <el...@google.com> #3Dec 2, 2024 11:41PM

Yes, kapt incremental compilation support is available since 1.3.40-dev-795
Is there already some plan to add support to Room?

ae...@gmail.com <ae...@gmail.com> #4Dec 3, 2024 12:21AM

#3 incremental kapt is available in 1.3.30 released yesterday too.

ae...@gmail.com <ae...@gmail.com> #5Dec 3, 2024 12:36AM

Is there already some ETA?

ae...@gmail.com <ae...@gmail.com> #6Dec 5, 2024 11:44PM

We are working on it and aiming for Room 2.2

ae...@gmail.com <ae...@gmail.com> #7Dec 10, 2024 11:43AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e4fbb7fb77a4789ab40bff03cc131479779d3e69
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Apr 09 23:20:59 2019

Create integration test for Room that uses gradle test kit.

Useful for testing Room incremental annotation processing in Gradle.

Also consolidated some of the path definitions in various build.gradle
into methods in buildSrc/SupportConfig.

Bug: 112110217
Test: ./gradlew room:integration-tests:room-i-a-p:test
Change-Id: I34f6772675712c6edd500e9149ab7f21ade4f012

M buildSrc/src/main/kotlin/androidx/build/SupportConfig.kt
M lifecycle/integration-tests/incrementality/build.gradle
M navigation/safe-args-gradle-plugin/build.gradle
A room/integration-tests/incremental-annotation-processing/build.gradle
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/AndroidManifest.xml
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDao.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDatabase.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestEntity.java
A room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/CompileTest.kt
M settings.gradle

https://android-review.googlesource.com/941741

https://goto.google.com/android-sha1/e4fbb7fb77a4789ab40bff03cc131479779d3e69

ae...@gmail.com <ae...@gmail.com> #8Dec 20, 2024 01:50PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a68222dc929ae5e2a3445f9df69a63636854852e
Author: Hung Nguyen <hungnv@google.com>
Date: Fri Mar 29 11:39:50 2019

Prepare Room for incremental annotation processing.

In Java projects, with non-incremental annotation processing, the inputs
to an annotation processor includes only Java source files.

With incremental annotation processing, however, the inputs may include
both Java source files and class files (to avoid recompiling source
files that haven't changed).

Therefore, all Room annotations need to have retention policy CLASS or
RUNTIME (not SOURCE), so that Room can find the elements annotated with
those annotations from class files. This requirement is also stated at

https://docs.gradle.org/current/userguide/java_plugin.html#sec:incremental_annotation_processing.

Bug: 112110217
Test: Existing tests + New AnnotationRetentionPolicyTest
Change-Id: I1e3a433bf69503ef15cfc2e53cbe97616a6f13b8

M room/common/api/2.2.0-alpha01.txt
M room/common/api/current.txt
M room/common/build.gradle
M room/common/src/main/java/androidx/room/ColumnInfo.java
M room/common/src/main/java/androidx/room/ForeignKey.java
M room/common/src/main/java/androidx/room/OnConflictStrategy.java
M room/common/src/main/java/androidx/room/Update.java
A room/common/src/test/java/androidx/room/AnnotationRetentionPolicyTest.kt

https://android-review.googlesource.com/958284

https://goto.google.com/android-sha1/a68222dc929ae5e2a3445f9df69a63636854852e

ae...@gmail.com <ae...@gmail.com> #9Dec 20, 2024 01:55PM

Project: platform/prebuilts/jdk/jdk8
Branch: androidx-master-dev

commit fe743aa0d39ef9bab51c612a957acdd4588d069c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jun 05 14:03:32 2019

Update JDK prebuilts

This build contains fix for

https://bugs.openjdk.java.net/browse/JDK-8194268
which is needed for

b/112110217

(Room incremental annotation processing).

This JDK was taken from platform/prebuilts/studio/jdk in studio-master-dev
as it contains the cherry-picked fixes (ag/7057968).

Test: ./gradlew bOS
Bug: 134470119
Change-Id: I11e4ac20e8cca61ebff5640af7d9b535e5af4ba3

D darwin-x86/MODULE_LICENSE_GPL
M darwin-x86/THIRD_PARTY_README
M darwin-x86/bin/appletviewer
A darwin-x86/bin/clhsdb
M darwin-x86/bin/extcheck
A darwin-x86/bin/hsdb
M darwin-x86/bin/idlj
M darwin-x86/bin/jar
M darwin-x86/bin/jarsigner
M darwin-x86/bin/java
M darwin-x86/bin/javac
M darwin-x86/bin/javadoc
M darwin-x86/bin/javah
M darwin-x86/bin/javap
M darwin-x86/bin/jcmd
M darwin-x86/bin/jconsole
M darwin-x86/bin/jdb
M darwin-x86/bin/jdeps
M darwin-x86/bin/jhat
M darwin-x86/bin/jinfo
M darwin-x86/bin/jjs
M darwin-x86/bin/jmap
M darwin-x86/bin/jps
M darwin-x86/bin/jrunscript
M darwin-x86/bin/jsadebugd
M darwin-x86/bin/jstack
M darwin-x86/bin/jstat
M darwin-x86/bin/jstatd
M darwin-x86/bin/keytool
M darwin-x86/bin/native2ascii
M darwin-x86/bin/orbd
M darwin-x86/bin/pack200
M darwin-x86/bin/policytool
M darwin-x86/bin/rmic
M darwin-x86/bin/rmid
M darwin-x86/bin/rmiregistry
M darwin-x86/bin/schemagen
M darwin-x86/bin/serialver
M darwin-x86/bin/servertool
M darwin-x86/bin/tnameserv
M darwin-x86/bin/unpack200
M darwin-x86/bin/wsgen
M darwin-x86/bin/wsimport
M darwin-x86/bin/xjc
M darwin-x86/jre/THIRD_PARTY_README
A darwin-x86/jre/bin/clhsdb
A darwin-x86/jre/bin/hsdb
M darwin-x86/jre/bin/java
M darwin-x86/jre/bin/jjs
M darwin-x86/jre/bin/keytool
M darwin-x86/jre/bin/orbd
M darwin-x86/jre/bin/pack200
M darwin-x86/jre/bin/policytool
M darwin-x86/jre/bin/rmid
M darwin-x86/jre/bin/rmiregistry
M darwin-x86/jre/bin/servertool
M darwin-x86/jre/bin/tnameserv
M darwin-x86/jre/bin/unpack200
M darwin-x86/jre/lib/charsets.jar
M darwin-x86/jre/lib/ext/cldrdata.jar
M darwin-x86/jre/lib/ext/dnsns.jar
M darwin-x86/jre/lib/ext/jaccess.jar
M darwin-x86/jre/lib/ext/localedata.jar
M darwin-x86/jre/lib/ext/nashorn.jar
M darwin-x86/jre/lib/ext/sunec.jar
M darwin-x86/jre/lib/ext/sunjce_provider.jar
M darwin-x86/jre/lib/ext/sunpkcs11.jar
M darwin-x86/jre/lib/ext/zipfs.jar
M darwin-x86/jre/lib/fontconfig.bfc
M darwin-x86/jre/lib/fontconfig.properties.src
A darwin-x86/jre/lib/fonts/DroidSansFallbackFull.ttf
M darwin-x86/jre/lib/jce.jar
M darwin-x86/jre/lib/jli/libjli.dylib
M darwin-x86/jre/lib/jspawnhelper
M darwin-x86/jre/lib/jsse.jar
M darwin-x86/jre/lib/libAppleScriptEngine.dylib
M darwin-x86/jre/lib/libattach.dylib
M darwin-x86/jre/lib/libawt.dylib
M darwin-x86/jre/lib/libawt_lwawt.dylib
M darwin-x86/jre/lib/libdt_socket.dylib
M darwin-x86/jre/lib/libfontmanager.dylib
M darwin-x86/jre/lib/libfreetype.dylib.6
M darwin-x86/jre/lib/libhprof.dylib
M darwin-x86/jre/lib/libinstrument.dylib
M darwin-x86/jre/lib/libj2gss.dylib
M darwin-x86/jre/lib/libj2pcsc.dylib
M darwin-x86/jre/lib/libj2pkcs11.dylib
M darwin-x86/jre/lib/libjaas_unix.dylib
M darwin-x86/jre/lib/libjava.dylib
M darwin-x86/jre/lib/libjava_crw_demo.dylib
M darwin-x86/jre/lib/libjawt.dylib
M darwin-x86/jre/lib/libjdwp.dylib
M darwin-x86/jre/lib/libjpeg.dylib
M darwin-x86/jre/lib/libjsdt.dylib
M darwin-x86/jre/lib/libjsig.dylib
M darwin-x86/jre/lib/libjsound.dylib
M darwin-x86/jre/lib/liblcms.dylib
M darwin-x86/jre/lib/libmanagement.dylib
M darwin-x86/jre/lib/libmlib_image.dylib
M darwin-x86/jre/lib/libnet.dylib
M darwin-x86/jre/lib/libnio.dylib
M darwin-x86/jre/lib/libnpt.dylib
M darwin-x86/jre/lib/libosx.dylib
M darwin-x86/jre/lib/libosxapp.dylib
M darwin-x86/jre/lib/libosxkrb5.dylib
M darwin-x86/jre/lib/libosxui.dylib
M darwin-x86/jre/lib/libsaproc.dylib
M darwin-x86/jre/lib/libsplashscreen.dylib
M darwin-x86/jre/lib/libsunec.dylib
M darwin-x86/jre/lib/libunpack.dylib
M darwin-x86/jre/lib/libverify.dylib
M darwin-x86/jre/lib/libzip.dylib
M darwin-x86/jre/lib/management-agent.jar
M darwin-x86/jre/lib/resources.jar
M darwin-x86/jre/lib/rt.jar
M darwin-x86/jre/lib/security/java.security
M darwin-x86/jre/lib/security/policy/limited/US_export_policy.jar
M darwin-x86/jre/lib/security/policy/limited/local_policy.jar
M darwin-x86/jre/lib/security/policy/unlimited/US_export_policy.jar
M darwin-x86/jre/lib/security/policy/unlimited/local_policy.jar
M darwin-x86/jre/lib/server/libjsig.dylib
M darwin-x86/jre/lib/server/libjvm.dylib
M darwin-x86/jre/lib/tzdb.dat
M darwin-x86/lib/ct.sym
M darwin-x86/lib/dt.jar
M darwin-x86/lib/jconsole.jar
M darwin-x86/lib/sa-jdi.jar
M darwin-x86/lib/tools.jar
M darwin-x86/release
D darwin-x86/sample/README
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Kettle.xml
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Module.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/PluginChecker.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Require.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/RequireContainer.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/BoilerPlugin.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/ExtendedBoilerPlugin.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/TimerPlugin.java
D darwin-x86/sample/annotations/Validator/src/PositiveIntegerSupplier.java
D darwin-x86/sample/annotations/Validator/src/SupplierValidator.java
D darwin-x86/sample/annotations/Validator/src/Validate.java
D darwin-x86/sample/annotations/Validator/src/Validator.java
D darwin-x86/sample/annotations/index.html
D darwin-x86/sample/dtrace/README.txt
D darwin-x86/sample/dtrace/helpers/dtrace_helper.d
D darwin-x86/sample/dtrace/hotspot/README.txt
D darwin-x86/sample/dtrace/hotspot/class_loading_stat.d
D darwin-x86/sample/dtrace/hotspot/gc_time_stat.d
D darwin-x86/sample/dtrace/hotspot/hotspot_calls_tree.d
D darwin-x86/sample/dtrace/hotspot/method_compile_stat.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_stat.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_stat_filter.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_tree.d
D darwin-x86/sample/dtrace/hotspot/monitors.d
D darwin-x86/sample/dtrace/hotspot/object_allocation_stat.d
D darwin-x86/sample/dtrace/hotspot_jni/CriticalSection.d
D darwin-x86/sample/dtrace/hotspot_jni/CriticalSection_slow.d
D darwin-x86/sample/dtrace/hotspot_jni/README.txt
D darwin-x86/sample/dtrace/hotspot_jni/hotspot_jni_calls_stat.d
D darwin-x86/sample/dtrace/hotspot_jni/hotspot_jni_calls_tree.d
D darwin-x86/sample/forkjoin/mergesort/MergeDemo.java
D darwin-x86/sample/forkjoin/mergesort/MergeSort.java
D darwin-x86/sample/jmx/jmx-scandir/build.properties
D darwin-x86/sample/jmx/jmx-scandir/build.xml
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local-ant-run.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local-java-jar.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/remote-connection-failed.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/remote-connection.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-config.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-result.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-start.jpg
D darwin-x86/sample/jmx/jmx-scandir/index.html
D darwin-x86/sample/jmx/jmx-scandir/keystore
D darwin-x86/sample/jmx/jmx-scandir/logging.properties
D darwin-x86/sample/jmx/jmx-scandir/manifest.mf
D darwin-x86/sample/jmx/jmx-scandir/nbproject/file-targets.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/jdk.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/netbeans-targets.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/project.xml
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScanner.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScannerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManager.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManagerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirAgent.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirClient.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfigMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManager.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManagerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/DirectoryScannerConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/FileMatch.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultLogConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultRecord.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ScanManagerConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/XmlConfigUtils.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/package.html
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/package.html
D darwin-x86/sample/jmx/jmx-scandir/src/etc/access.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/management.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/password.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/testconfig.xml
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/DirectoryScannerTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanDirConfigTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanManagerTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/TestUtils.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/config/XmlConfigUtilsTest.java
D darwin-x86/sample/jmx/jmx-scandir/truststore
D darwin-x86/sample/lambda/BulkDataOperations/index.html
D darwin-x86/sample/lambda/BulkDataOperations/src/CSVProcessor.java
D darwin-x86/sample/lambda/BulkDataOperations/src/Grep.java
D darwin-x86/sample/lambda/BulkDataOperations/src/PasswordGenerator.java
D darwin-x86/sample/lambda/BulkDataOperations/src/WC.java
D darwin-x86/sample/lambda/DefaultMethods/ArrayIterator.java
D darwin-x86/sample/lambda/DefaultMethods/DiamondInheritance.java
D darwin-x86/sample/lambda/DefaultMethods/Inheritance.java
D darwin-x86/sample/lambda/DefaultMethods/MixIn.java
D darwin-x86/sample/lambda/DefaultMethods/Reflection.java
D darwin-x86/sample/lambda/DefaultMethods/SimplestUsage.java
D darwin-x86/sample/nbproject/project.xml
D darwin-x86/sample/nio/chatserver/ChatServer.java
D darwin-x86/sample/nio/chatserver/Client.java
D darwin-x86/sample/nio/chatserver/ClientReader.java
D darwin-x86/sample/nio/chatserver/DataReader.java
D darwin-x86/sample/nio/chatserver/MessageReader.java
D darwin-x86/sample/nio/chatserver/NameReader.java
D darwin-x86/sample/nio/chatserver/README.txt
D darwin-x86/sample/nio/file/AclEdit.java
D darwin-x86/sample/nio/file/Chmod.java
D darwin-x86/sample/nio/file/Copy.java
D darwin-x86/sample/nio/file/DiskUsage.java
D darwin-x86/sample/nio/file/FileType.java
D darwin-x86/sample/nio/file/WatchDir.java
D darwin-x86/sample/nio/file/Xdd.java
D darwin-x86/sample/nio/multicast/MulticastAddress.java
D darwin-x86/sample/nio/multicast/Reader.java
D darwin-x86/sample/nio/multicast/Sender.java
D darwin-x86/sample/nio/server/AcceptHandler.java
D darwin-x86/sample/nio/server/Acceptor.java
D darwin-x86/sample/nio/server/B1.java
D darwin-x86/sample/nio/server/BN.java
D darwin-x86/sample/nio/server/BP.java
D darwin-x86/sample/nio/server/ChannelIO.java
D darwin-x86/sample/nio/server/ChannelIOSecure.java
D darwin-x86/sample/nio/server/Content.java
D darwin-x86/sample/nio/server/Dispatcher.java
D darwin-x86/sample/nio/server/Dispatcher1.java
D darwin-x86/sample/nio/server/DispatcherN.java
D darwin-x86/sample/nio/server/FileContent.java
D darwin-x86/sample/nio/server/Handler.java
D darwin-x86/sample/nio/server/MalformedRequestException.java
D darwin-x86/sample/nio/server/N1.java
D darwin-x86/sample/nio/server/N2.java
D darwin-x86/sample/nio/server/README.txt
D darwin-x86/sample/nio/server/Reply.java
D darwin-x86/sample/nio/server/Request.java
D darwin-x86/sample/nio/server/RequestHandler.java
D darwin-x86/sample/nio/server/RequestServicer.java
D darwin-x86/sample/nio/server/Sendable.java
D darwin-x86/sample/nio/server/Server.java
D darwin-x86/sample/nio/server/StringContent.java
D darwin-x86/sample/nio/server/URLDumper.java
D darwin-x86/sample/scripting/scriptpad/README.txt
D darwin-x86/sample/scripting/scriptpad/build.properties
D darwin-x86/sample/scripting/scriptpad/build.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/file-targets.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/jdk.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/netbeans-targets.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/project.xml
D darwin-x86/sample/scripting/scriptpad/src/META-INF/manifest.mf
D darwin-x86/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java
D darwin-x86/sample/scripting/scriptpad/src/resources/Main.js
D darwin-x86/sample/scripting/scriptpad/src/resources/conc.js
D darwin-x86/sample/scripting/scriptpad/src/resources/gui.js
D darwin-x86/sample/scripting/scriptpad/src/resources/mm.js
D darwin-x86/sample/scripting/scriptpad/src/resources/scriptpad.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/README.txt
D darwin-x86/sample/scripting/scriptpad/src/scripts/browse.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/insertfile.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/linewrap.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/mail.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memmonitor.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.bat
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.sh
D darwin-x86/sample/scripting/scriptpad/src/scripts/textcolor.js
D darwin-x86/sample/try-with-resources/index.html
D darwin-x86/sample/try-with-resources/src/CustomAutoCloseableSample.java
D darwin-x86/sample/try-with-resources/src/Unzip.java
D darwin-x86/sample/try-with-resources/src/ZipCat.java
M darwin-x86/src.zip
D linux-x86/MODULE_LICENSE_GPL
M linux-x86/THIRD_PARTY_README
M linux-x86/bin/appletviewer
A linux-x86/bin/clhsdb
M linux-x86/bin/extcheck
A linux-x86/bin/hsdb
M linux-x86/bin/idlj
M linux-x86/bin/jar
M linux-x86/bin/jarsigner
M linux-x86/bin/java
M linux-x86/bin/javac
M linux-x86/bin/javadoc
M linux-x86/bin/javah
M linux-x86/bin/javap
M linux-x86/bin/jcmd
M linux-x86/bin/jconsole
M linux-x86/bin/jdb
M linux-x86/bin/jdeps
M linux-x86/bin/jhat
M linux-x86/bin/jinfo
M linux-x86/bin/jjs
M linux-x86/bin/jmap
M linux-x86/bin/jps
M linux-x86/bin/jrunscript
M linux-x86/bin/jsadebugd
M linux-x86/bin/jstack
M linux-x86/bin/jstat
M linux-x86/bin/jstatd
M linux-x86/bin/keytool
M linux-x86/bin/native2ascii
M linux-x86/bin/orbd
M linux-x86/bin/pack200
M linux-x86/bin/policytool
M linux-x86/bin/rmic
M linux-x86/bin/rmid
M linux-x86/bin/rmiregistry
M linux-x86/bin/schemagen
M linux-x86/bin/serialver
M linux-x86/bin/servertool
M linux-x86/bin/tnameserv
M linux-x86/bin/unpack200
M linux-x86/bin/wsgen
M linux-x86/bin/wsimport
M linux-x86/bin/xjc
M linux-x86/jre/THIRD_PARTY_README
A linux-x86/jre/bin/clhsdb
A linux-x86/jre/bin/hsdb
M linux-x86/jre/bin/java
M linux-x86/jre/bin/jjs
M linux-x86/jre/bin/keytool
M linux-x86/jre/bin/orbd
M linux-x86/jre/bin/pack200
M linux-x86/jre/bin/policytool
M linux-x86/jre/bin/rmid
M linux-x86/jre/bin/rmiregistry
M linux-x86/jre/bin/servertool
M linux-x86/jre/bin/tnameserv
M linux-x86/jre/bin/unpack200
M linux-x86/jre/lib/amd64/jli/libjli.so
M linux-x86/jre/lib/amd64/libattach.so
M linux-x86/jre/lib/amd64/libawt.so
M linux-x86/jre/lib/amd64/libawt_headless.so
M linux-x86/jre/lib/amd64/libawt_xawt.so
M linux-x86/jre/lib/amd64/libdt_socket.so
M linux-x86/jre/lib/amd64/libfontmanager.so
M linux-x86/jre/lib/amd64/libhprof.so
M linux-x86/jre/lib/amd64/libinstrument.so
M linux-x86/jre/lib/amd64/libj2gss.so
M linux-x86/jre/lib/amd64/libj2pcsc.so
M linux-x86/jre/lib/amd64/libj2pkcs11.so
M linux-x86/jre/lib/amd64/libjaas_unix.so
M linux-x86/jre/lib/amd64/libjava.so
M linux-x86/jre/lib/amd64/libjava_crw_demo.so
M linux-x86/jre/lib/amd64/libjawt.so
M linux-x86/jre/lib/amd64/libjdwp.so
M linux-x86/jre/lib/amd64/libjpeg.so
M linux-x86/jre/lib/amd64/libjsdt.so
M linux-x86/jre/lib/amd64/libjsig.so
M linux-x86/jre/lib/amd64/libjsound.so
M linux-x86/jre/lib/amd64/libjsoundalsa.so
M linux-x86/jre/lib/amd64/liblcms.so
M linux-x86/jre/lib/amd64/libmanagement.so
M linux-x86/jre/lib/amd64/libmlib_image.so
M linux-x86/jre/lib/amd64/libnet.so
M linux-x86/jre/lib/amd64/libnio.so
M linux-x86/jre/lib/amd64/libnpt.so
M linux-x86/jre/lib/amd64/libsaproc.so
M linux-x86/jre/lib/amd64/libsctp.so
M linux-x86/jre/lib/amd64/libsplashscreen.so
M linux-x86/jre/lib/amd64/libsunec.so
M linux-x86/jre/lib/amd64/libunpack.so
M linux-x86/jre/lib/amd64/libverify.so
M linux-x86/jre/lib/amd64/libzip.so
M linux-x86/jre/lib/amd64/server/libjsig.so
M linux-x86/jre/lib/amd64/server/libjvm.so
M linux-x86/jre/lib/charsets.jar
M linux-x86/jre/lib/ext/cldrdata.jar
M linux-x86/jre/lib/ext/dnsns.jar
M linux-x86/jre/lib/ext/jaccess.jar
M linux-x86/jre/lib/ext/localedata.jar
M linux-x86/jre/lib/ext/nashorn.jar
M linux-x86/jre/lib/ext/sunec.jar
M linux-x86/jre/lib/ext/sunjce_provider.jar
M linux-x86/jre/lib/ext/sunpkcs11.jar
M linux-x86/jre/lib/ext/zipfs.jar
A linux-x86/jre/lib/fonts/DroidSansFallbackFull.ttf
M linux-x86/jre/lib/jce.jar
M linux-x86/jre/lib/jexec
M linux-x86/jre/lib/jsse.jar
M linux-x86/jre/lib/management-agent.jar
M linux-x86/jre/lib/resources.jar
M linux-x86/jre/lib/rt.jar
M linux-x86/jre/lib/security/java.security
M linux-x86/jre/lib/security/policy/limited/US_export_policy.jar
M linux-x86/jre/lib/security/policy/limited/local_policy.jar
M linux-x86/jre/lib/security/policy/unlimited/US_export_policy.jar
M linux-x86/jre/lib/security/policy/unlimited/local_policy.jar
M linux-x86/jre/lib/tzdb.dat
M linux-x86/lib/amd64/jli/libjli.so
M linux-x86/lib/amd64/libjawt.so
M linux-x86/lib/ct.sym
M linux-x86/lib/dt.jar
M linux-x86/lib/jconsole.jar
M linux-x86/lib/jexec
M linux-x86/lib/sa-jdi.jar
M linux-x86/lib/tools.jar
M linux-x86/release
D linux-x86/sample/README
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Kettle.xml
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Module.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/PluginChecker.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Require.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/RequireContainer.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/BoilerPlugin.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/ExtendedBoilerPlugin.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/TimerPlugin.java
D linux-x86/sample/annotations/Validator/src/PositiveIntegerSupplier.java
D linux-x86/sample/annotations/Validator/src/SupplierValidator.java
D linux-x86/sample/annotations/Validator/src/Validate.java
D linux-x86/sample/annotations/Validator/src/Validator.java
D linux-x86/sample/annotations/index.html
D linux-x86/sample/forkjoin/mergesort/MergeDemo.java
D linux-x86/sample/forkjoin/mergesort/MergeSort.java
D linux-x86/sample/jmx/jmx-scandir/build.properties
D linux-x86/sample/jmx/jmx-scandir/build.xml
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local-ant-run.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local-java-jar.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/remote-connection-failed.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/remote-connection.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-config.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-result.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-start.jpg
D linux-x86/sample/jmx/jmx-scandir/index.html
D linux-x86/sample/jmx/jmx-scandir/keystore
D linux-x86/sample/jmx/jmx-scandir/logging.properties
D linux-x86/sample/jmx/jmx-scandir/manifest.mf
D linux-x86/sample/jmx/jmx-scandir/nbproject/file-targets.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/jdk.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/netbeans-targets.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/project.xml
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScanner.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScannerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManager.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManagerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirAgent.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirClient.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfigMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManager.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManagerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/DirectoryScannerConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/FileMatch.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultLogConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultRecord.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ScanManagerConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/XmlConfigUtils.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/package.html
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/package.html
D linux-x86/sample/jmx/jmx-scandir/src/etc/access.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/management.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/password.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/testconfig.xml
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/DirectoryScannerTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanDirConfigTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanManagerTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/TestUtils.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/config/XmlConfigUtilsTest.java
D linux-x86/sample/jmx/jmx-scandir/truststore
D linux-x86/sample/lambda/BulkDataOperations/index.html
D linux-x86/sample/lambda/BulkDataOperations/src/CSVProcessor.java
D linux-x86/sample/lambda/BulkDataOperations/src/Grep.java
D linux-x86/sample/lambda/BulkDataOperations/src/PasswordGenerator.java
D linux-x86/sample/lambda/BulkDataOperations/src/WC.java
D linux-x86/sample/lambda/DefaultMethods/ArrayIterator.java
D linux-x86/sample/lambda/DefaultMethods/DiamondInheritance.java
D linux-x86/sample/lambda/DefaultMethods/Inheritance.java
D linux-x86/sample/lambda/DefaultMethods/MixIn.java
D linux-x86/sample/lambda/DefaultMethods/Reflection.java
D linux-x86/sample/lambda/DefaultMethods/SimplestUsage.java
D linux-x86/sample/nbproject/project.xml
D linux-x86/sample/nio/chatserver/ChatServer.java
D linux-x86/sample/nio/chatserver/Client.java
D linux-x86/sample/nio/chatserver/ClientReader.java
D linux-x86/sample/nio/chatserver/DataReader.java
D linux-x86/sample/nio/chatserver/MessageReader.java
D linux-x86/sample/nio/chatserver/NameReader.java
D linux-x86/sample/nio/chatserver/README.txt
D linux-x86/sample/nio/file/AclEdit.java
D linux-x86/sample/nio/file/Chmod.java
D linux-x86/sample/nio/file/Copy.java
D linux-x86/sample/nio/file/DiskUsage.java
D linux-x86/sample/nio/file/FileType.java
D linux-x86/sample/nio/file/WatchDir.java
D linux-x86/sample/nio/file/Xdd.java
D linux-x86/sample/nio/multicast/MulticastAddress.java
D linux-x86/sample/nio/multicast/Reader.java
D linux-x86/sample/nio/multicast/Sender.java
D linux-x86/sample/nio/server/AcceptHandler.java
D linux-x86/sample/nio/server/Acceptor.java
D linux-x86/sample/nio/server/B1.java
D linux-x86/sample/nio/server/BN.java
D linux-x86/sample/nio/server/BP.java
D linux-x86/sample/nio/server/ChannelIO.java
D linux-x86/sample/nio/server/ChannelIOSecure.java
D linux-x86/sample/nio/server/Content.java
D linux-x86/sample/nio/server/Dispatcher.java
D linux-x86/sample/nio/server/Dispatcher1.java
D linux-x86/sample/nio/server/DispatcherN.java
D linux-x86/sample/nio/server/FileContent.java
D linux-x86/sample/nio/server/Handler.java
D linux-x86/sample/nio/server/MalformedRequestException.java
D linux-x86/sample/nio/server/N1.java
D linux-x86/sample/nio/server/N2.java
D linux-x86/sample/nio/server/README.txt
D linux-x86/sample/nio/server/Reply.java
D linux-x86/sample/nio/server/Request.java
D linux-x86/sample/nio/server/RequestHandler.java
D linux-x86/sample/nio/server/RequestServicer.java
D linux-x86/sample/nio/server/Sendable.java
D linux-x86/sample/nio/server/Server.java
D linux-x86/sample/nio/server/StringContent.java
D linux-x86/sample/nio/server/URLDumper.java
D linux-x86/sample/scripting/scriptpad/README.txt
D linux-x86/sample/scripting/scriptpad/build.properties
D linux-x86/sample/scripting/scriptpad/build.xml
D linux-x86/sample/scripting/scriptpad/nbproject/file-targets.xml
D linux-x86/sample/scripting/scriptpad/nbproject/jdk.xml
D linux-x86/sample/scripting/scriptpad/nbproject/netbeans-targets.xml
D linux-x86/sample/scripting/scriptpad/nbproject/project.xml
D linux-x86/sample/scripting/scriptpad/src/META-INF/manifest.mf
D linux-x86/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java
D linux-x86/sample/scripting/scriptpad/src/resources/Main.js
D linux-x86/sample/scripting/scriptpad/src/resources/conc.js
D linux-x86/sample/scripting/scriptpad/src/resources/gui.js
D linux-x86/sample/scripting/scriptpad/src/resources/mm.js
D linux-x86/sample/scripting/scriptpad/src/resources/scriptpad.js
D linux-x86/sample/scripting/scriptpad/src/scripts/README.txt
D linux-x86/sample/scripting/scriptpad/src/scripts/browse.js
D linux-x86/sample/scripting/scriptpad/src/scripts/insertfile.js
D linux-x86/sample/scripting/scriptpad/src/scripts/linewrap.js
D linux-x86/sample/scripting/scriptpad/src/scripts/mail.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memmonitor.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.bat
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.sh
D linux-x86/sample/scripting/scriptpad/src/scripts/textcolor.js
D linux-x86/sample/try-with-resources/index.html
D linux-x86/sample/try-with-resources/src/CustomAutoCloseableSample.java
D linux-x86/sample/try-with-resources/src/Unzip.java
D linux-x86/sample/try-with-resources/src/ZipCat.java
M linux-x86/src.zip

https://android-review.googlesource.com/978088

https://goto.google.com/android-sha1/fe743aa0d39ef9bab51c612a957acdd4588d069c

da...@google.com <da...@google.com> #10Dec 20, 2024 03:52PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f65f09de487c04fa40b4734d88b92a79fe2c545
Author: Hung Nguyen <hungnv@google.com>
Date: Wed May 08 15:49:58 2019

Make Room an isolating incremental annotation processor.

This CL introduces an annotation processor option called
`room.incremental`
which the user can set to try out incremental annotation processing with
Room. It is currently off by default.

The user can pass the option through the Android Gradle plugin's DSL,
for example:

android {
defaultConfig
javaCompileOptions {
annotationProcessorOptions {
argument 'room.incremental', 'true'
}
}
}
}

Caveat: There is a JDK bug

https://bugs.openjdk.java.net/browse/JDK-8007720 that prevents Room from
being incremental (details are discussed in the code comment).
Therefore, if the JDK version being used does not already have this fix,
Room cannot be incremental and we will print out a warning to ask the
user to use a JDK version having the fix.

Note that Room currently does not track the annotation processor option
`room.schemaLocation` properly as an @OutputDirectory, and this could
impact build correctness. However, this issue impacts both
non-incremental and incremental builds, and it already existed before,
so we will fix it separately (tracked at

bug 132245929

).

Additionally, Room is currently not using the
javax.annotation.processing.Filer API to let Gradle know the originating
element of a generated schema file, so the schema files may not get
deleted properly when certain source files are deleted (tracked at bug
134472065).

Bug: 112110217
Test: New RoomIncrementalAnnotationProcessingTest
Change-Id: I0076e596b1c05bcc51afea21a4f6a9a90fb6c7be

M room/compiler/src/main/kotlin/androidx/room/RoomProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/Context.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/compiler/src/main/kotlin/androidx/room/util/SimpleJavaVersion.kt
M room/compiler/src/main/kotlin/androidx/room/vo/Warning.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DatabaseWriter.kt
A room/compiler/src/main/resources/META-INF/gradle/incremental.annotation.processors
M room/compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt
A room/compiler/src/test/kotlin/androidx/room/util/SimpleJavaVersionTest.kt
M room/compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Dao1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Dao2.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Database1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Database2.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Entity1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Entity2.java
D room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/CompileTest.kt
A room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/RoomIncrementalAnnotationProcessingTest.kt

https://android-review.googlesource.com/958285

https://goto.google.com/android-sha1/6f65f09de487c04fa40b4734d88b92a79fe2c545

ae...@gmail.com <ae...@gmail.com> #11Dec 20, 2024 05:07PM

Room 2.2.0 will be an incremental annotation processing when enabled via the option 'room.incremental = true'

ae...@gmail.com <ae...@gmail.com> #12Dec 22, 2024 04:36AM

When will be some alpha or at least snapshot build with this support, please?

ae...@gmail.com <ae...@gmail.com> #13Dec 22, 2024 05:29AM

in a couple of weeks, we should have it.

ae...@gmail.com <ae...@gmail.com> #14Dec 22, 2024 06:21PM

I updated to 2.2.0 stable release and added the option "room.incremental = true" to my gradle properties.
But I am still seeing this warning:
w: [kapt] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: androidx.room.RoomProcessor (DYNAMIC).

ae...@gmail.com <ae...@gmail.com> #15Dec 22, 2024 06:27PM

Sorry about my last comment. I just saw I configured it wrong. It is not supposed to be se tin the gradle.properties, but in the annotationProcessorOptions.

android {
...
defaultConfig {
...
javaCompileOptions {
annotationProcessorOptions {
arguments = [
"room.schemaLocation":"$projectDir/schemas".toString(),
"room.incremental":"true",
"room.expandProjection":"true"]
}
}
}
}

da...@google.com <da...@google.com> #16Dec 22, 2024 08:27PM

@Yigit Will a future version of room have this enabled by default?

Message last modified on Dec 22, 2024 08:28PM

ae...@gmail.com <ae...@gmail.com> #17Dec 22, 2024 09:11PM

yes, it will be but we are looking for some feedback before we make the switch just to be safe and not break other people.

da...@google.com <da...@google.com> #18Dec 22, 2024 11:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2715143f2b6f2b74a088b242b39c9841d2d8dcf2
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Jun 18 09:54:58 2020

Make room.incremental default be true

Relnote: Room's incremental annotation processing option is now ON by default.
Bug: 112110217
Test: :room:integration-tests:room-i-a-p:test
Change-Id: If46d955da45d985543ab982bd0e9d27bbd961517

M room/compiler/src/main/kotlin/androidx/room/processor/Context.kt

https://android-review.googlesource.com/1343816

ae...@gmail.com <ae...@gmail.com> #19Dec 24, 2024 09:31PM

Is it switched on by default in 2.2.5? Because I still got the message got a warning from kapt

[WARN] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: androidx.room.RoomProcessor (DYNAMIC).

Solved to adding "room.incremental"="true" in the annotation params.

Message last modified on Dec 24, 2024 09:31PM

el...@google.com <el...@google.com> Dec 26, 2024 07:47PM

Reassigned to da...@google.com.

ae...@gmail.com <ae...@gmail.com> #20Jan 1, 2025 03:49PM

Oops, spoke too soon. First appears in the release notes for 2.3.0:

https://developer.android.com/jetpack/androidx/releases/room#2.3.0-alpha02

ae...@gmail.com <ae...@gmail.com> #21Jan 6, 2025 06:06PM

KNOWN ISSUE: Note that incremental Room is currently broken in some cases (Issue 159501719), so we may need to revert this change or send out a patch to at least provide workarounds to users. https://issuetracker.google.com//159501719#comment18 lists the possible fixes.

da...@google.com <da...@google.com> #22Jan 8, 2025 03:09PM

Sorry there was a typo, correction: https://issuetracker.google.com/159501719#comment18

ae...@gmail.com <ae...@gmail.com> #23Jan 8, 2025 03:28PM

Hi. Thank you for your response. For now I am not succeed in reproduce the issue with the BundledSQLiteDriver and the database is locked. But I will try more.

Speaking of "not using a SQLiteDriver" - am I understood right that I just need to delete .setDriver() method?

da...@google.com <da...@google.com> #24Jan 8, 2025 03:32PM

Thats right, not calling setDriver will make Room work in compatibility mode and will use the FrameworkSQLiteOpenHelper and its APIs and will keep the 'before KMP coroutines' behavior.

ae...@gmail.com <ae...@gmail.com> #25Jan 8, 2025 06:16PM

So. I removed setDriver method. The builder is still in common module. Now the error IllegalStateException: Cannot perform this operation because there is no current transaction happens every time when app trying to make database operation using this code

private val dbMutex = Mutex()

suspend fun <R> MyDatabse.workaroundWithTransaction(block: suspend TransactionScope<R>.() -> R) {
    dbMutex.withLock {
        useWriterConnection {
            it.deferredTransaction(block)
        }

        // TODO: Fix https://issuetracker.google.com/issues/340606803#comment2
        // Manually triggers invalidation
        invalidationTracker.refreshAsync()
    }
}

The stack trace:

java.lang.IllegalStateException: Cannot perform this operation because there is no current transaction.
	at android.database.sqlite.SQLiteSession.throwIfNoTransaction(SQLiteSession.java:1021)
	at android.database.sqlite.SQLiteSession.endTransaction(SQLiteSession.java:419)
	at android.database.sqlite.SQLiteDatabase.endTransaction(SQLiteDatabase.java:833)
	at androidx.sqlite.db.framework.FrameworkSQLiteDatabase.endTransaction(FrameworkSQLiteDatabase.android.kt:100)
	at androidx.room.driver.SupportSQLitePooledConnection.transaction(SupportSQLiteConnectionPool.android.kt:90)
	at androidx.room.driver.SupportSQLitePooledConnection.access$transaction(SupportSQLiteConnectionPool.android.kt:51)
	at androidx.room.driver.SupportSQLitePooledConnection$transaction$1.invokeSuspend(Unknown Source:15)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:98)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:113)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)

Note: there was AndroidSQLiteDriverPooledConnection now it is SupportSQLitePooledConnection in stack trace.

Message last modified on Jan 8, 2025 06:24PM

ae...@gmail.com <ae...@gmail.com> #26Jan 8, 2025 07:21PM

Also, users report that when using the Android driver, sometimes the database does not return a response from an SQL query where it should have returned it.

The example of such request

@Query("""SELECT * from "${Holder.TABLE_HOLDER}" WHERE "${Holder.COLUMN_HOLDER_ID}" LIKE :holderId""")
fun getHolderById(holderId: String): Flow<Holder?>

Message last modified on Jan 8, 2025 07:46PM

ae...@gmail.com <ae...@gmail.com> #27Jan 8, 2025 07:41PM

I found the way to reproduce it!

First you launch workaroundWithTransaction method, then getHolderById method. The result: getHolderById stops returning result.

This error is ever worse than before because it is reproduceable in almost 100% cases!

I have to return to BundledSQLiteDriver

Message last modified on Jan 8, 2025 07:51PM

da...@google.com <da...@google.com> #28Jan 9, 2025 02:25AM

Can you provide more details on the repro case? Is it possible to create a sample repro? Or maybe a test? Can you please show us some code?

Are you starting a transaction and in the transaction you are also collecting the Flow?

db.workaroundWithTransaction {
  db.dao.getHolderById(...).collect {
    
  }
}

This is not a valid usage of Flow because you are essentially starting a transaction that will never end and that might explain the database locked exception you are seeing.

Here another test I have created based on your description but it works fine for me on all drivers:

@Test
fun check() = runTest {
    async(Dispatchers.IO) {
        // Insert 100 items in a deferred transaction and notifying invalidation tracker
        repeat(100) { id ->
            db.useWriterConnection {
                it.deferredTransaction {
                    db.dao().insert(SampleEntity(id.toLong()))
                }
            }
            db.invalidationTracker.refreshAsync()
        }
    }

    async(Dispatchers.IO) {
        // Collect list of inserted items until list is of size 100, meaning
        // all 100 items where inserted and a result with a list of them was received
        db.dao().getItemListFlow().collect {
            if (it.size == 100) {
                cancel()
            }
        }
    }
}

Message last modified on Jan 9, 2025 02:27AM

ae...@gmail.com <ae...@gmail.com> #29Jan 9, 2025 12:36PM

Hi. The order of reproducing:

call db.dao().getHolderById("some_id").first() - will return a result
call db.useWriterConnection {...} - to make any change in db
call db.dao().getHolderById("some_id").first() - no longer returns a result

Only restarting the app will make db.dao().getHolderById("some_id").first() work again.

For now I can't create a simple repo, maybe later.

Message last modified on Jan 9, 2025 01:34PM

ba...@gmail.com <ba...@gmail.com> #30Jan 21, 2025 08:53AM

I don't have a minimal repro case, but I am facing this issue in my project (https://github.com/tasks/tasks)

I have been using AndroidSQLiteDriver in production and never had a database locked crash. Many months ago I briefly deployed BundledSQLiteDriver but reverted it because of this crash

This weekend I wanted to use window functions on Android so I switched to BundledSQLiteDriver again. It did not crash on my Pixel 9 Pro during development so I thought the issue was fixed. Then I deployed my changes and am getting tons of crashes again

I then tested on a CAT S22. This thing is a potato and I get database locked crashes easily.

I commented out my transactor.withTransaction calls so the only transactions are generated by Room and it still crashes

When I use PRAGMA busy_timeout to increase the timeout then the database just deadlocks instead of crashing

Message last modified on Jan 21, 2025 04:17PM

ba...@gmail.com <ba...@gmail.com> #31Jan 21, 2025 09:07AM

Just to add more details:

I can comment out my @RawQuery, useWriterConnection, and useReaderConnection calls, and I still get database locked crashes using only generated @Query, @Insert, @Update, and @Delete functions. The app runs in a single process

Switching from BundledSQLiteDriver back to AndroidSQLiteDriver fixes the issue completely

On my CAT S22 the app crashes on first launch after a clean install 100% of the time. The app will start after relaunching but it will then crash frequently during synchronization

ae...@gmail.com <ae...@gmail.com> #32Jan 21, 2025 11:54AM

Hi. Is there any updates? I believe it is should be P1 issue.

ba...@gmail.com <ba...@gmail.com> #33Jan 21, 2025 06:32PM

My guess, without looking at any of the library code, is that transactions are not being queued with the BundledSQLiteDriver. I have firebase crashes from 20+ different database functions at this point. My pixel 9 pro is probably servicing requests fast enough to not crash, the CAT S22 not so much.

da...@google.com <da...@google.com> #34Jan 21, 2025 07:39PM

I'll grab an old Nexus 5 I have around that is pretty potato to see if I can repro this.

Room has a connection pool manager and it has 4 reader connections and one writer, it uses coroutines to suspend callers when the connections are being used. This is indeed different than Android's driver that 'blocks' callers when a connection is not available.

ba...@gmail.com <ba...@gmail.com> #35Jan 21, 2025 08:46PM

I became aware of room's connection strategy when I learned that reading data with Room flows acquired a transaction, which was a surprising source of performance problems at my day job 🙃

I thought using AndroidSQLiteDriver was analogous to not specifying a driver at all, and would use the connection/transaction strategy you mentioned. Based on my observations I assumed this was related to the problem with the BundledSQLiteDriver - transactions are happening on multiple connections rather than queuing them on one connection? I'm just speculating and could also be mistaken about how this works under the hood.

If you're trying to repro by running my app but aren't having any luck let me know, I could create a branch that seeds the app with some test data or something.

da...@google.com <da...@google.com> #36Jan 21, 2025 09:11PM

I was able to successful run the Tasks app but indeed haven't had luck reproducing the issue, so if you do end up creating that branch with seed data I will gladly use it.

Reading data via a Flow returned from a @Dao has never required a transaction, unless specified in the DAO via @Transaction. Would love to hear more about the surprising performance issues.

However, I agree that transactions tend to be a source of performance issues. If no driver is used Room uses SupportSQLite and Android's SQLite bindings, transactions there always use the single primary connection and they block each other. When using the AndroidSQLiteDriver, similarly that uses Android's SQLite binding which will also uses the primary connection. There is a difference in code paths when no driver is specified and when AndroidSQLiteDriver is used, but it is in terms of backwards compatibility of other SupportSQLite APIs (see warning in https://developer.android.com/training/data-storage/room/room-kmp-migration#set_a_sqlite_driver).

Now BundledSQLiteDriver internally does not have a connection pool like the Android driver does and instead relies on Room's which we try to test as much as we can but of course it is not as mature's as Android. So we really appreciate you trying it out and reporting these issues. As for how different it is, the main difference is that the connection pool is suspending, other coroutines can continue while a connection is being used, this is very different from the other drivers that will 'block' the caller which for DAO functions Room alleviates by using a FIFO single threaded pool (the transaction executor) but can't control when other blocking APIs are used (beginTransaction). So yes, it is possible to start multiple transactions with Room's connection pool, but in essence they are also queued via suspending coroutines as the connection is being acquired and returned to the pool.

ba...@gmail.com <ba...@gmail.com> #37Jan 21, 2025 10:39PM

Reading data via a Flow returned from a @Dao has never required a transaction, unless specified in the DAO via @Transaction. Would love to hear more about the surprising performance issues.

The issue we were having was that on startup our sync loop would sometimes start a transaction before our UI created a Room flow, and the UI flow would be blocked until the sync transaction finished. I think we jumped to the conclusion that Room flows acquire a transaction when they're started, but I just looked at the library code again and I think its just acquiring a transaction the first time you observe a table 🤦 edit: OK I'll stop derailing this ticket, but when a flow is started and its the first observer on a table there is a transaction, and when a flow finishes and its the last observer on a table there is a transaction

I was able to successful run the Tasks app but indeed haven't had luck reproducing the issue, so if you do end up creating that branch with seed data I will gladly use it.

I will get this to you ASAP

Message last modified on Jan 22, 2025 12:25AM

da...@google.com <da...@google.com> #38Jan 22, 2025 03:08PM

Yes, if a Flow needs to observe tables that have no observer 'installed' then Room has to create some TRIGGERs to start observing the tables and it does it in a transaction. Unfortunately this has to block the Flow's initial query to guarantee consistency. I think we would need a different invalidation system, not TRIGGER based, to possibly avoid that start and end transaction but I don't think we have enough strong compelling reasons to change the system.

al...@beeper.com <al...@beeper.com> #39Jan 22, 2025 06:00PM

I have attached a backup file that you can import into Tasks by tapping on 'Settings > Backups > Import' and selecting the file.

On my CAT S22 with this commit that just adds BundledSQLiteDriver it crashes with a database locked error, and the previous commit does not.

The next-worst phone I have is a Galaxy S9 and I cannot get the database locked error on there, even with 10x as much data in the database

When I look at Firebase, these are the types of phones experiencing this crash: TP-Link Neffos A5 Tinno Y52 ZTE Blade A34 Moto E13 & E20 Xiamo Redmi A1 & A2 Alcatel 1C Transsion Tecno Spark Go 1 Mobiwire Smart C11

This list is not exhaustive, I just grabbed it from the first 5 distinct crashes. I've never even heard of most of these phones until just now

Message last modified on Jan 22, 2025 06:03PM

auto.20250121T0008.json

346 KB

Download

ae...@gmail.com <ae...@gmail.com> #40Jan 22, 2025 06:12PM

Thank you for participating. I am really glad to see some progress and discussion on this issue.

ap...@google.com <ap...@google.com> #41Jan 23, 2025 08:44PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3462864

Reduce no-op transaction while syncing triggers

Expand for full commit details

Reduce no-op transaction while syncing triggers 
 
The ObservedTableStates instance will return a list of observe operations (add or remove triggers) to perform if it 'needs sync'. A sync is required if at least a trigger needs to be added or removed from a table since the last sync. However, it might be that multiple observers are added and removed such that the end result of operations is actually to do nothing. In this case Room still tries to start a database transaction to not add or remove any triggers. Since transactions have lock implications it is best to avoid the transaction that if all observer operations are no-op. 
 
Example case this change is optimizing: 
1.  Flow A in UI begins collecting, trigger A is installed 
2.  UI is rotated, not using collectAsStateWithLifecycle() or equivalent 
2.a Flow A stops collecting, a sync is required 
2.b Flow A starts collecting, a sync is still required 
3.  Triggers are synced, operation on table A is no-op 
 
Bug: 380088809 
Test: Existing 
Change-Id: Iae612a1c4f8b8f1e8e15d2f60eb9bf68241570ef

Files:

M room/room-runtime/src/commonMain/kotlin/androidx/room/InvalidationTracker.kt

Hash: a0e5f03fe83ec6446228a4b872f1d72fb2bf8216
Date: Thu Jan 23 11:06:08 2025

ae...@gmail.com <ae...@gmail.com> #42Jan 23, 2025 10:23PM

Are you were able to reproduce the issue and fix it or it is an other issue got fixed?

al...@beeper.com <al...@beeper.com> #43Jan 29, 2025 11:56PM

I've spent an hour trying to repro the deadlock I mentioned in https://issuetracker.google.com/u/1/issues/380088809#comment30 when using PRAGMA busy_timeout = <time in ms> with the CAT S22. I have not been successful, so maybe that does fix my problem. I'm going to try releasing with BundledSQLiteDriver again 🤞

ae...@gmail.com <ae...@gmail.com> #44Feb 3, 2025 11:22PM

Hi. Are there any updates on this?

da...@google.com <da...@google.com> #45Feb 4, 2025 02:22PM

Hey - 2.7.0-alpha13 has a change that should reduce the issue, but not guaranteed.

But I was not able to reproduce the issue with the project and data from comment#39. 🙁

Things got busy so I have to dedicate more time to this issue, but its sort of a wild goose chase without a reliable repro.

ck...@gmail.com <ck...@gmail.com> #46Feb 9, 2025 06:16PM

Starting with the latest version, 2.7.0-alpha13, we switched to BundledSQLiteDriver, which produces hundreds of database-locked exceptions.

   Non-fatal Exception: android.database.SQLException: Error code: 5, message: database is locked
       at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.nativeStep(BundledSQLiteStatement.jvmAndroid.kt)
       at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.access$nativeStep(BundledSQLiteStatement.jvmAndroid.kt)
       at androidx.sqlite.driver.bundled.BundledSQLiteStatement.step(BundledSQLiteStatement.jvmAndroid.kt:100)
       at app.resubs.core.database.dao.PendingNotificationDao_Impl.getAll$lambda$1(PendingNotificationDao_Impl.kt:94)
       at androidx.room.util.DBUtil__DBUtil_androidKt$performSuspending$lambda$1$$inlined$internalPerform$1.invokeSuspend(DBUtil.kt:68)
       at androidx.room.util.DBUtil__DBUtil_androidKt$performSuspending$lambda$1$$inlined$internalPerform$1.invoke(DBUtil.kt:8)
       at androidx.room.util.DBUtil__DBUtil_androidKt$performSuspending$lambda$1$$inlined$internalPerform$1.invoke(DBUtil.kt:4)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invokeSuspend(ConnectionPoolImpl.kt:144)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invoke(ConnectionPoolImpl.kt:8)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invoke(ConnectionPoolImpl.kt:4)
       at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:43)
       at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:166)
       at kotlinx.coroutines.BuildersKt.withContext(Builders.kt)
       at androidx.room.coroutines.ConnectionPoolImpl.useConnection(ConnectionPoolImpl.kt:144)
       at androidx.room.coroutines.ConnectionPoolImpl$useConnection$1.invokeSuspend(ConnectionPoolImpl.kt:13)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:35)

Message last modified on Feb 9, 2025 06:17PM

ae...@gmail.com <ae...@gmail.com> #47Feb 9, 2025 08:41PM

Hi ck...@gmail.com. If you have any ideas on how to reproduce the error, please help with this.

da...@google.com <da...@google.com> #48Feb 10, 2025 02:43PM

I did found that we were not configuring the busy_timeout in the initial connection which can lead to SQLITE_BUSY (error code 5). I've sent a cl to fix that.

I have another alternative / workaround for those with this issue which will also hint me to the root of the cause. In comment#10 I mentioned how increasing the timeout can help, but I realize my suggestion there was not great because it should be done on all connections and not just on the initial connection, to do this you will need to wrap your driver, here is an example code:

val actualDriver = BundledSQLiteDriver()
val driverWrapper =
  object : SQLiteDriver by actualDriver {
    override fun open(fileName: String): SQLiteConnection {
      return actualDriver.open(fileName).also { newConnection ->
        newConnection.execSQL("PRAGMA busy_timeout = $customBusyTimeout")
      }
    }
  }
roomDatabaseBuilder
  .setDriver(driverWrapper)

Let me know if this helps or not.

ae...@gmail.com <ae...@gmail.com> #49Feb 11, 2025 11:52AM

Hi ck...@gmail.com, ba...@gmail.com. Could you please test this solution on your side?

ap...@google.com <ap...@google.com> #50Feb 11, 2025 09:46PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3486790

Apply busy_timeout config for initial connection

Expand for full commit details

Apply busy_timeout config for initial connection 
 
Fix an issue where busy_timeout was not being configured in the initial connection where schema validation is also done. The busy_timeout must be set on all connections to avoid SQLITE_BUSY. 
 
Bug: 380088809 
Test: BaseBuilderTest#setCustomBusyTimeout 
Change-Id: I9320856f64363b05bcf6407eed0efe36ef3312a3

Files:

M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseBuilderTest.kt
M room/room-runtime/src/commonMain/kotlin/androidx/room/RoomConnectionManager.kt
M room/room-runtime/src/commonMain/kotlin/androidx/room/coroutines/ConnectionPool.kt

Hash: ba379355137898cf40a16bff549863ab6a55f093
Date: Mon Feb 10 09:32:51 2025

ae...@gmail.com <ae...@gmail.com> #51Mar 2, 2025 03:16PM

Hi. I have applied this fix to my app and release for 10% of users. I got 4000 installs and for now I don't see this error. I am going to try with version 2.7.0-rc01.

se...@scrapgolem.com <se...@scrapgolem.com> #52Mar 5, 2025 01:30PM

I'm still seeing this or a similar issue on 2.7.0-rc01. I haven't tried using AndroidSQLiteDriver or any of the other workarounds listed here. Previously, I was using setQueryCoroutineContext(Dispatchers.IO.limitedParallelism(1)) which did solve the problem. I removed that after upgrading to 2.7.0-rc01.

I got this crash yesterday:

android.database.SQLException: Error code: 5, message: database is locked
    at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.nativeStep(SourceFile)
    at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.access$nativeStep(BundledSQLiteStatement.jvmAndroid.kt:0)
    at androidx.sqlite.driver.bundled.BundledSQLiteStatement.step(BundledSQLiteStatement.jvmAndroid.kt:0)
    at androidx.sqlite.driver.bundled.BundledSQLiteStatement.step(BundledSQLiteStatement.jvmAndroid.kt:100)
    at androidx.sqlite.SQLite.execSQL(com.google.android.gms:play-services-mlkit-barcode-scanning@@18.3.1:56)
    at androidx.room.coroutines.PooledConnectionImpl.endTransaction(ConnectionPoolImpl.kt:420)
    at androidx.room.coroutines.PooledConnectionImpl.transaction(ConnectionPoolImpl.kt:388)
    at androidx.room.coroutines.PooledConnectionImpl.isRecycled(ConnectionPoolImpl.kt:0)
    at androidx.room.coroutines.PooledConnectionImpl.access$isRecycled(ConnectionPoolImpl.kt:0)
    at androidx.room.coroutines.PooledConnectionImpl.withTransaction(ConnectionPoolImpl.kt:0)
    at androidx.room.coroutines.PooledConnectionImpl.withTransaction(ConnectionPoolImpl.kt:344)
    at kotlin.coroutines.intrinsics.IntrinsicsKt__IntrinsicsKt.getCOROUTINE_SUSPENDED
    at androidx.room.util.DBUtil__DBUtil_androidKt$performInTransactionSuspending$3$invokeSuspend$$inlined$internalPerform$1.invokeSuspend(DBUtil.kt:0)
    at androidx.room.util.DBUtil__DBUtil_androidKt$performInTransactionSuspending$3$invokeSuspend$$inlined$internalPerform$1.invokeSuspend(DBUtil.kt:59)
    at androidx.room.util.DBUtil__DBUtil_androidKt$performInTransactionSuspending$3$invokeSuspend$$inlined$internalPerform$1.invoke(DBUtil.kt:0)
    at androidx.room.util.DBUtil__DBUtil_androidKt$performInTransactionSuspending$3$invokeSuspend$$inlined$internalPerform$1.invoke(DBUtil.kt:0)
    at kotlin.coroutines.intrinsics.IntrinsicsKt__IntrinsicsKt.getCOROUTINE_SUSPENDED
    at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invokeSuspend(ConnectionPoolImpl.kt:0)
    at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invokeSuspend(ConnectionPoolImpl.kt:144)
    at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invoke(ConnectionPoolImpl.kt:0)
    at androidx.room.coroutines.ConnectionPoolImpl$useConnection$4.invoke(ConnectionPoolImpl.kt:0)
    at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(ChildStackFactory.kt:43)
    at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext
    at kotlinx.coroutines.BuildersKt.withContext(DebugStrings.kt:0)
    at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext
    at kotlinx.coroutines.BuildersKt.withContext(DebugStrings.kt:1)
    at androidx.room.coroutines.ConnectionPoolImpl.useConnection(ConnectionPoolImpl.kt:144)
    at androidx.room.RoomDatabase.useConnection$room_runtime_release(RoomDatabase.android.kt:0)
    at androidx.room.RoomConnectionManager.useConnection
    at androidx.room.RoomDatabase.useConnection$room_runtime_release(RoomDatabase.android.kt:587)
    at kotlin.coroutines.intrinsics.IntrinsicsKt__IntrinsicsKt.getCOROUTINE_SUSPENDED
    at androidx.room.util.DBUtil__DBUtil_androidKt$performInTransactionSuspending$3.invokeSuspend(DBUtil.android.kt:0)
    at androidx.room.util.DBUtil__DBUtil_androidKt$performInTransactionSuspending$3.invokeSuspend(DBUtil.android.kt:243)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:0)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
    at java.lang.Thread.run(Thread.java:1012)

Message last modified on Mar 5, 2025 01:30PM

ae...@gmail.com <ae...@gmail.com> #53Mar 12, 2025 07:52PM

Hi. I got a new error: Fatal Exception: android.database.SQLException: Error code: 5, message: Timed out attempting to acquire a reader connection.

Writer pool:
	Xu1@d088033 (capacity=1)
		[1] - ow@e204ff0
		Status: Free connection
Reader pool:
	Xu1@6c0ec8f (capacity=4)
		[1] - ow@dd27b1c
		Status: Acquired connection
		Coroutine: [go2@7c92325, eo2{Active}@cf76cfa, Dispatchers.IO]
		Acquired:
			at lR.C(Unknown Source:310)
			at iR.invokeSuspend(Unknown Source:13)
			at dq.resumeWith(Unknown Source:8)
			at TR1.o(Unknown Source:6)
			at W.resumeWith(Unknown Source:22)
			at dq.resumeWith(Unknown Source:31)
			at xc0.run(Unknown Source:109)
			at K2.run(Unknown Source:1024)
			at qc2.run(Unknown Source:2)
			at SV.run(Unknown Source:93)
		
		[2] - ow@71a2d08
		Status: Free connection
		[3] - ow@c0dcca1
		Status: Free connection
		[4] - ow@bbf5ec6
		Status: Free connection

Message last modified on Mar 12, 2025 07:54PM

da...@google.com <da...@google.com> #54Mar 13, 2025 12:42PM

"Timed out attempting to acquire a reader connection" is a better error than "database is locked", hehe

It seems you have 3 zombie connections in your pool. I suspect this is because currently don't refill the pool when a connection dies. I'll work on a change to make sure the pool is always of the correct size. Thanks again for your patience on helping us make the library better.

ap...@google.com <ap...@google.com> #55Mar 19, 2025 05:09PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3546974

Reimplement suspending pool with Semaphore

Expand for full commit details

Reimplement suspending pool with Semaphore 
 
This changes the implementation of Room's connection pool to use a Semaphore instead of a Channel. It makes the implementation simpler and removes the possibility of connections getting 'lost' due the the various branches needed to handle when a channel send / receive fails. 
 
The Channel was also used as a 'queue' instead a circular array is used to push and pop connections acquired and released into the pool. The semaphore still controls the amount of connections being locked and unlocked and is the suspending API that waits for a connection to be free. 
 
Bug: 322386871 
Bug: 380088809 
Test: BaseConnectionPoolTest 
Change-Id: I9b7f2d44b511eb3e3d8cdaf8cb8905bb6203f8c5

Files:

M room/room-runtime/src/commonMain/kotlin/androidx/room/coroutines/ConnectionPoolImpl.kt
M room/room-runtime/src/commonTest/kotlin/androidx/room/coroutines/BaseConnectionPoolTest.kt

Hash: dc4715197f7869c87af3025acba91a0c8a57db4d
Date: Mon Mar 17 12:01:10 2025

da...@google.com <da...@google.com> #56Mar 24, 2025 01:17PM

The next release (2.7.0-rc03) will have a change that should alleviate the 'Timed out attempting to acquire a reader connection' issue, I'll continue to keep this issue open so others can report if they are still experiencing it or not.

ae...@gmail.com <ae...@gmail.com> #57Mar 24, 2025 01:33PM

Hi. Thank you for your fixes. I have released 2.7.0-rc01 for 100% of users. For now it have about 22000 installs and I don't see the error SQLException: Error code: 5, message: database is locked anymore.

Message last modified on Mar 24, 2025 01:34PM

Issue 380088809

Description

Issue summary

Comments

ae...@gmail.com <ae...@gmail.com> #2Nov 30, 2024 01:29AM

el...@google.com <el...@google.com> #3Dec 2, 2024 11:41PM

ae...@gmail.com <ae...@gmail.com> #4Dec 3, 2024 12:21AM

ae...@gmail.com <ae...@gmail.com> #5Dec 3, 2024 12:36AM

ae...@gmail.com <ae...@gmail.com> #6Dec 5, 2024 11:44PM

ae...@gmail.com <ae...@gmail.com> #7Dec 10, 2024 11:43AM

ae...@gmail.com <ae...@gmail.com> #8Dec 20, 2024 01:50PM

ae...@gmail.com <ae...@gmail.com> #9Dec 20, 2024 01:55PM

da...@google.com <da...@google.com> #10Dec 20, 2024 03:52PM

ae...@gmail.com <ae...@gmail.com> #11Dec 20, 2024 05:07PM

ae...@gmail.com <ae...@gmail.com> #12Dec 22, 2024 04:36AM

ae...@gmail.com <ae...@gmail.com> #13Dec 22, 2024 05:29AM

ae...@gmail.com <ae...@gmail.com> #14Dec 22, 2024 06:21PM

ae...@gmail.com <ae...@gmail.com> #15Dec 22, 2024 06:27PM

da...@google.com <da...@google.com> #16Dec 22, 2024 08:27PM

ae...@gmail.com <ae...@gmail.com> #17Dec 22, 2024 09:11PM

da...@google.com <da...@google.com> #18Dec 22, 2024 11:35PM

ae...@gmail.com <ae...@gmail.com> #19Dec 24, 2024 09:31PM

el...@google.com <el...@google.com> Dec 26, 2024 07:47PM

ae...@gmail.com <ae...@gmail.com> #20Jan 1, 2025 03:49PM

ae...@gmail.com <ae...@gmail.com> #21Jan 6, 2025 06:06PM

da...@google.com <da...@google.com> #22Jan 8, 2025 03:09PM

ae...@gmail.com <ae...@gmail.com> #23Jan 8, 2025 03:28PM

da...@google.com <da...@google.com> #24Jan 8, 2025 03:32PM

ae...@gmail.com <ae...@gmail.com> #25Jan 8, 2025 06:16PM

ae...@gmail.com <ae...@gmail.com> #26Jan 8, 2025 07:21PM

ae...@gmail.com <ae...@gmail.com> #27Jan 8, 2025 07:41PM

da...@google.com <da...@google.com> #28Jan 9, 2025 02:25AM

ae...@gmail.com <ae...@gmail.com> #29Jan 9, 2025 12:36PM

ba...@gmail.com <ba...@gmail.com> #30Jan 21, 2025 08:53AM

ba...@gmail.com <ba...@gmail.com> #31Jan 21, 2025 09:07AM

ae...@gmail.com <ae...@gmail.com> #32Jan 21, 2025 11:54AM

ba...@gmail.com <ba...@gmail.com> #33Jan 21, 2025 06:32PM

da...@google.com <da...@google.com> #34Jan 21, 2025 07:39PM

ba...@gmail.com <ba...@gmail.com> #35Jan 21, 2025 08:46PM

da...@google.com <da...@google.com> #36Jan 21, 2025 09:11PM

ba...@gmail.com <ba...@gmail.com> #37Jan 21, 2025 10:39PM

da...@google.com <da...@google.com> #38Jan 22, 2025 03:08PM

al...@beeper.com <al...@beeper.com> #39Jan 22, 2025 06:00PM

ae...@gmail.com <ae...@gmail.com> #40Jan 22, 2025 06:12PM

ap...@google.com <ap...@google.com> #41Jan 23, 2025 08:44PM

ae...@gmail.com <ae...@gmail.com> #42Jan 23, 2025 10:23PM

al...@beeper.com <al...@beeper.com> #43Jan 29, 2025 11:56PM

ae...@gmail.com <ae...@gmail.com> #44Feb 3, 2025 11:22PM

da...@google.com <da...@google.com> #45Feb 4, 2025 02:22PM

ck...@gmail.com <ck...@gmail.com> #46Feb 9, 2025 06:16PM

ae...@gmail.com <ae...@gmail.com> #47Feb 9, 2025 08:41PM

da...@google.com <da...@google.com> #48Feb 10, 2025 02:43PM

ae...@gmail.com <ae...@gmail.com> #49Feb 11, 2025 11:52AM

ap...@google.com <ap...@google.com> #50Feb 11, 2025 09:46PM

ae...@gmail.com <ae...@gmail.com> #51Mar 2, 2025 03:16PM

se...@scrapgolem.com <se...@scrapgolem.com> #52Mar 5, 2025 01:30PM

ae...@gmail.com <ae...@gmail.com> #53Mar 12, 2025 07:52PM

da...@google.com <da...@google.com> #54Mar 13, 2025 12:42PM

ap...@google.com <ap...@google.com> #55Mar 19, 2025 05:09PM

da...@google.com <da...@google.com> #56Mar 24, 2025 01:17PM

ae...@gmail.com <ae...@gmail.com> #57Mar 24, 2025 01:33PM

Add comment

Issue metadata