Unintended line breaks in Text [391378120]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Jan 22, 2025 10:38AM

Jetpack Compose version: BOM 2024.12.01

Jetpack Compose component(s) used: Text in Material3

Android Studio Build: Meerkat Canary 9

Kotlin version: 2.1.0

Problem:

Since bumping target SDK to 35 we notice that some strings on some devices receive unintended line breaks even when the Text Composable is allowed to be as wide as it wants. Trying to force single line does not work either as setting maxLines=1 clip the string rather than join to one line.

Examples of problematic strings:

Actual:ALEX
Rendered:
ALE
X

Actual: Your IKEA
Rendered: 
Your
IKEA

Steps to Reproduce or Code Sample to Reproduce:

Code: Attached minimal reproduction repo including our custom font

Device: Reproduced on Pixel 9 Pro XL real device and emulator using the font/display settings in attached screenshot. Also reported on but not verified: Pixel 8 Pro, Pixel Tablet

Summary of the reprod sample: Activity with the following XML:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical"
    android:paddingHorizontal="32dp"
    android:paddingTop="256dp"
    >

    <TextView
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:text="TextView: Reproduced by making this string long enough to wrap down to a second line and be above the ComposeView in the parent LinearLayout"
        android:visibility="visible"
        android:layout_marginBottom="16dp"
        android:background="#33FF00FF"
        />

    <androidx.compose.ui.platform.ComposeView
        android:id="@+id/compose"
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

</LinearLayout>

...and the following sample code:

class ReprodActivity : AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        val binding  = ActivityReprodBinding.inflate(layoutInflater)
        setContentView(binding.root)
        binding.compose.setContent {
            Column(
                modifier = Modifier.fillMaxWidth(),
                verticalArrangement = spacedBy(12.dp)
            ) {
                Text(
                    text = "Compose:",
                    fontWeight = FontWeight.Bold,
                    color = Color.Black,
                    fontSize = 14.sp,
                    modifier = Modifier.background(Color.Magenta)
                )
                Sample("Your Test")
                Sample("Your IKEA")
                Sample("ALEX")
            }
        }
    }
}

@Composable
fun Sample(text: String) {
    Row(
        Modifier
            .fillMaxWidth()
            .horizontalScroll(rememberScrollState()),
        content = { repeat(1) { SampleText(text) } },
    )
}

@Composable
private fun SampleText(text: String) {
    Text(
        text = text,
        fontWeight = FontWeight.Bold,
        color = Color.Black,
        fontFamily = MyFontFamily,
        fontSize = 14.sp,
        lineHeight = 22.sp,
        modifier = Modifier.background(Color.Magenta),
    )
}

private val Regular = Font(R.font.noto_ikea_latin_regular, FontWeight.Normal)
private val Bold = Font(R.font.noto_ikea_latin_bold, FontWeight.Bold)
private val MyFontFamily = FontFamily(Regular, Bold)

This will produce the result in attached screenshots.

Some findings from debugging the issue:

Seems to only be reproducible when combining XML + Compose
Seems to have occurred after bumping to target SDK 35
Only some devices are affected and only on some combinations of the display/font size settings
Only some strings are affected, "Your IKEA" breaks, "Your Test" does not
Seems to only be reproducible when using our custom font (used without prior issues since 2019)
In the reproduction sample the issue only occurs if the TextView has more than 1 line of text, if the TextView as 1 line, is Visibility.Gone, removed or moved below the ComposeView in the LinearLayout the issue does not occur.

settings.png

254 KB

View

Download

image (1).png

124 KB

View

Download

image (8).png

98 KB

View

Download

reprod.zip

296 KB

Download

Comments

gr...@google.com <gr...@google.com> Jan 22, 2025 07:42PM

Assigned to gr...@google.com.

gr...@google.com <gr...@google.com> #2Jan 22, 2025 09:42PM

I guess technically, the ProGuard rule should be on androidx.work.NonBlockingWorker subclasses, but I'd also be okay with just not using reflection to access the Worker(Context, WorkerParamters) constructor and skipping the need for a ProGuard rule at all.

Message last modified on Jan 22, 2025 09:46PM

gr...@google.com <gr...@google.com> #3Jan 22, 2025 10:25PM

Fixed in

https://android-review.googlesource.com/c/platform/frameworks/support/+/767262

gr...@google.com <gr...@google.com> #4Jan 22, 2025 10:46PM

The fix will be available in alpha10.

gr...@google.com <gr...@google.com> #5Jan 22, 2025 11:24PM

Reassigned to no...@google.com.

I tried to use the ProGuard configuration which is linked in

comment #3

in my project.
The release build fails and the following warnings are printed:

22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { NonBlockingWorker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { void internalInit(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.Worker { Worker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'

The app is opensource if you want to run the release build yourself. Here is the branch (WIP):

https://github.com/EventFahrplan/EventFahrplan/tree/workmanager
Please run: ./gradlew --info --debug aCcc34c3Release

gr...@google.com <gr...@google.com> #6Jan 23, 2025 12:06AM

Ah, that's because we have a typo in our Proguard file. Change WorkParameters to WorkerParameters.

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #7Jan 23, 2025 11:40AM

Thank you for quick reply. I changed this here:

https://github.com/EventFahrplan/EventFahrplan/commit/7567331dc69a303d5c423850a97bf29005ea7b1c

The release build still fails though. Here is a part of the log output:

23:43:15.760 [ERROR] [system.err] Note: there were 11 duplicate class definitions.
23:43:15.760 [ERROR] [system.err] (

http://proguard.sourceforge.net/manual/troubleshooting.html#duplicateclass)
23:43:15.822 [QUIET] [system.out] Initializing...
23:43:15.827 [QUIET] [system.out] Note: the configuration refers to the unknown class 'androidx.work.impl.background.firebase.FirebaseJobScheduler'
23:43:15.845 [QUIET] [system.out] Note: the configuration refers to the unknown class 'androidx.work.WorkParameters'
23:43:15.857 [QUIET] [system.out] Note: the configuration refers to the unknown class 'androidx.work.impl.background.firebase.FirebaseJobScheduler'
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.273 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.273 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.273 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.285 [ERROR] [system.err] Warning: androidx.work.impl.background.systemjob.SystemJobService: can't find referenced method 'android.net.Network getNetwork()' in library class android.app.job.JobParameters
23:43:16.883 [QUIET] [system.out] Note: androidx.work.impl.Schedulers: can't find dynamically referenced class androidx.work.impl.background.firebase.FirebaseJobService
23:43:16.883 [QUIET] [system.out] Note: androidx.work.impl.Schedulers: can't find dynamically referenced class androidx.work.impl.background.firebase.FirebaseJobScheduler
23:43:16.911 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.jdk8.JDK8PlatformImplementations
23:43:16.911 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.JRE8PlatformImplementations
23:43:16.912 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.jdk7.JDK7PlatformImplementations
23:43:16.912 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.JRE7PlatformImplementations
23:43:16.914 [QUIET] [system.out] Note: kotlin.jvm.internal.Reflection: can't find dynamically referenced class kotlin.reflect.jvm.internal.ReflectionFactoryImpl
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.AndroidPlatform: can't find dynamically referenced class com.android.org.conscrypt.SSLParametersImpl
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.AndroidPlatform: can't find dynamically referenced class org.apache.harmony.xnet.provider.jsse.SSLParametersImpl
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.AndroidPlatform$CloseGuard: can't find dynamically referenced class dalvik.system.CloseGuard
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.ConscryptPlatform: can't find dynamically referenced class org.conscrypt.ConscryptEngineSocket
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.Platform: can't find dynamically referenced class sun.security.ssl.SSLContextImpl

Message last modified on Jan 23, 2025 11:43AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #8Jan 23, 2025 11:56AM

I think your compileSdk is too low. WorkManager requires it to be 28 or higher:

https://irina-dot-devsite.googleplex.com/topic/libraries/architecture/adding-components

I'm not sure why you are running into the warnings about Unsafe, but you can try using -dontwarn sun.misc.Unsafe in your proguard file to see if it helps. We haven't observed it ourselves.

For what it's worth, one of the notes is referring to WorkParameters still - are you sure it was changed properly?

gr...@google.com <gr...@google.com> #9Jan 23, 2025 11:05PM

Sorry, the right url above should be:

https://developer.android.com/jetpack/docs/release-notes

Message last modified on Jan 28, 2025 07:41PM

ap...@google.com <ap...@google.com> #10Jan 24, 2025 02:21AM

I changed the ProGuard configuration as you can see it in the GitHub repository. It matches with your change here

https://android-review.googlesource.com/c/platform/frameworks/support/+/782087/2/work/workmanager/proguard-rules.pro if I don't miss anything. I cannot tell why "WorkParameters" is still listed. I verified the output once again by running ./gradlew clean --info --debug aCcc34c3Release. Feel free to run the build yourself. All you need to do is to create a random release-keystore and the app/gradle.properties from the app/gradle.properties.example.

So you saying when I want to migrate my app to targetSdkVersion 26 until November I need to raise the compileSdkVersion to 28 in order to use WorkManager? Using targetSdkVersion 26 with compileSdkVersion 28 won't work?

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #11Jan 24, 2025 08:01AM

There shouldn't be any issues with targetSdkVersion 26 and compileSdkVersion 28.

gr...@google.com <gr...@google.com> #12Jan 28, 2025 12:40AM

Okay. I will try that. Thanks.
Feel free to contact me if you are not able to build my project.

gr...@google.com <gr...@google.com> #13Jan 28, 2025 07:46PM

Does it suffice to raise the compileSdkVersion to 28 or do I also have to raise the version of the support library artifacts at the same time? I tried your suggestion in

comment #11

but the build still fails.

er...@gmail.com <er...@gmail.com> #14Feb 13, 2025 11:52PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit cee9ab55352f3ad506552afb4753baf8648b4c30
Author: Sumir Kataria <sumir@google.com>
Date: Mon Oct 08 14:20:57 2018

Fix class name in Proguard configuration.

Bug: 116296569
Test: N/A
Change-Id: I3525f9d2f3b06523cbe842b35f97014677879a64

M work/workmanager/proguard-rules.pro

https://android-review.googlesource.com/782087

https://goto.google.com/android-sha1/cee9ab55352f3ad506552afb4753baf8648b4c30

gr...@google.com <gr...@google.com> #15Feb 14, 2025 11:35PM

Marked as fixed.

Support library as well.

er...@gmail.com <er...@gmail.com> #16Mar 12, 2025 03:57PM

Do the latest changes (WorkParameters -> WorkerParameters, NonBlockingWorker -> ListenableWorker) in the ProGuard configuration apply to WorkManager 1.0.0-alpha09 or 1.0.0-alpha10 or both?

gp...@squareup.com <gp...@squareup.com> #17Mar 12, 2025 06:02PM

alpha10.

Message last modified on Mar 12, 2025 06:02PM

Issue 391378120

Description

Issue summary

Comments

gr...@google.com <gr...@google.com> Jan 22, 2025 07:42PM

gr...@google.com <gr...@google.com> #2Jan 22, 2025 09:42PM

gr...@google.com <gr...@google.com> #3Jan 22, 2025 10:25PM

gr...@google.com <gr...@google.com> #4Jan 22, 2025 10:46PM

gr...@google.com <gr...@google.com> #5Jan 22, 2025 11:24PM

gr...@google.com <gr...@google.com> #6Jan 23, 2025 12:06AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #7Jan 23, 2025 11:40AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #8Jan 23, 2025 11:56AM

gr...@google.com <gr...@google.com> #9Jan 23, 2025 11:05PM

ap...@google.com <ap...@google.com> #10Jan 24, 2025 02:21AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #11Jan 24, 2025 08:01AM

gr...@google.com <gr...@google.com> #12Jan 28, 2025 12:40AM

gr...@google.com <gr...@google.com> #13Jan 28, 2025 07:46PM

er...@gmail.com <er...@gmail.com> #14Feb 13, 2025 11:52PM

gr...@google.com <gr...@google.com> #15Feb 14, 2025 11:35PM

er...@gmail.com <er...@gmail.com> #16Mar 12, 2025 03:57PM

gp...@squareup.com <gp...@squareup.com> #17Mar 12, 2025 06:02PM

Add comment

Issue metadata