Unintended line breaks in Text [391378120]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Jan 22, 2025 10:38AM

Jetpack Compose version: BOM 2024.12.01

Jetpack Compose component(s) used: Text in Material3

Android Studio Build: Meerkat Canary 9

Kotlin version: 2.1.0

Problem:

Since bumping target SDK to 35 we notice that some strings on some devices receive unintended line breaks even when the Text Composable is allowed to be as wide as it wants. Trying to force single line does not work either as setting maxLines=1 clip the string rather than join to one line.

Examples of problematic strings:

Actual:ALEX
Rendered:
ALE
X

Actual: Your IKEA
Rendered: 
Your
IKEA

Steps to Reproduce or Code Sample to Reproduce:

Code: Attached minimal reproduction repo including our custom font

Device: Reproduced on Pixel 9 Pro XL real device and emulator using the font/display settings in attached screenshot. Also reported on but not verified: Pixel 8 Pro, Pixel Tablet

Summary of the reprod sample: Activity with the following XML:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical"
    android:paddingHorizontal="32dp"
    android:paddingTop="256dp"
    >

    <TextView
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:text="TextView: Reproduced by making this string long enough to wrap down to a second line and be above the ComposeView in the parent LinearLayout"
        android:visibility="visible"
        android:layout_marginBottom="16dp"
        android:background="#33FF00FF"
        />

    <androidx.compose.ui.platform.ComposeView
        android:id="@+id/compose"
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

</LinearLayout>

...and the following sample code:

class ReprodActivity : AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        val binding  = ActivityReprodBinding.inflate(layoutInflater)
        setContentView(binding.root)
        binding.compose.setContent {
            Column(
                modifier = Modifier.fillMaxWidth(),
                verticalArrangement = spacedBy(12.dp)
            ) {
                Text(
                    text = "Compose:",
                    fontWeight = FontWeight.Bold,
                    color = Color.Black,
                    fontSize = 14.sp,
                    modifier = Modifier.background(Color.Magenta)
                )
                Sample("Your Test")
                Sample("Your IKEA")
                Sample("ALEX")
            }
        }
    }
}

@Composable
fun Sample(text: String) {
    Row(
        Modifier
            .fillMaxWidth()
            .horizontalScroll(rememberScrollState()),
        content = { repeat(1) { SampleText(text) } },
    )
}

@Composable
private fun SampleText(text: String) {
    Text(
        text = text,
        fontWeight = FontWeight.Bold,
        color = Color.Black,
        fontFamily = MyFontFamily,
        fontSize = 14.sp,
        lineHeight = 22.sp,
        modifier = Modifier.background(Color.Magenta),
    )
}

private val Regular = Font(R.font.noto_ikea_latin_regular, FontWeight.Normal)
private val Bold = Font(R.font.noto_ikea_latin_bold, FontWeight.Bold)
private val MyFontFamily = FontFamily(Regular, Bold)

This will produce the result in attached screenshots.

Some findings from debugging the issue:

Seems to only be reproducible when combining XML + Compose
Seems to have occurred after bumping to target SDK 35
Only some devices are affected and only on some combinations of the display/font size settings
Only some strings are affected, "Your IKEA" breaks, "Your Test" does not
Seems to only be reproducible when using our custom font (used without prior issues since 2019)
In the reproduction sample the issue only occurs if the TextView has more than 1 line of text, if the TextView as 1 line, is Visibility.Gone, removed or moved below the ComposeView in the LinearLayout the issue does not occur.

settings.png

254 KB

View

Download

image (1).png

124 KB

View

Download

image (8).png

98 KB

View

Download

reprod.zip

296 KB

Download

Comments

gr...@google.com <gr...@google.com> Jan 22, 2025 07:42PM

Assigned to gr...@google.com.

gr...@google.com <gr...@google.com> #2Jan 22, 2025 09:42PM

the abovementioned issue is reproducible on "1.0.0-beta02" version

Message last modified on Jan 22, 2025 09:46PM

gr...@google.com <gr...@google.com> #3Jan 22, 2025 10:25PM

Hi, thanks for reporting. We'll have a look. In the meantime, you can probably move padding, to page layout?

gr...@google.com <gr...@google.com> #4Jan 22, 2025 10:46PM

I intentionally set the padding to ViewPager2 to allow offscreen pages to be partially visible

gr...@google.com <gr...@google.com> #5Jan 22, 2025 11:24PM

Reassigned to no...@google.com.

Sorry didn't realise that from your GIF. Any chance you could share a minimum sample app with us so we can investigate?

In the meantime, could you try this as a workaround and let us know if it fixes the issue:
`val rv = viewpager2.getChildAt(0) as RecyclerView` and set padding and android:clipToPadding on it directly (and nothing on ViewPager2)
?

gr...@google.com <gr...@google.com> #6Jan 23, 2025 12:06AM

I've tried your solution:

Tried to set left and right padding of the underlying recyclerView, like so:
(pager.getChildAt(0) as RecyclerView).apply {
//hijacking padding from pager
setPadding(
pager.paddingLeft, //resolves to 53
pager.paddingTop,
pager.paddingRight, //resolves to 53
pager.paddingBottom
)
//reseting padding on pager
pager.setPadding(0, pager.paddingTop, 0, pager.paddingBottom)
clipToPadding = false
}

got this exception:

E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.easecentral.ease.debug, PID: 23890
java.lang.IllegalStateException: Page can only be offset by a positive amount, not by -53
at androidx.viewpager2.widget.ScrollEventAdapter.updateScrollEventValues(ScrollEventAdapter.java:260)
at androidx.viewpager2.widget.ScrollEventAdapter.onScrolled(ScrollEventAdapter.java:168)
at androidx.recyclerview.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:5152)
at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:4212)
at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:3843)
at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4385)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at androidx.viewpager2.widget.ViewPager2.onLayout(ViewPager2.java:511)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1915)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.widget.ScrollView.onLayout(ScrollView.java:1552)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at com.android.internal.policy.DecorView.onLayout(DecorView.java:753)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2792)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2319)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1460)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7183)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:949)
at android.view.Choreographer.doCallbacks(Choreographer.java:761)
at android.view.Choreographer.doFrame(Choreographer.java:696)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:935)
at android.os.Handler.handleCallback(Handler.java:873)
E/AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

I'll try to provide some minimum sample app, but can't promise anything right now, as I'm swarmed with other projects

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #7Jan 23, 2025 11:40AM

That's our internal checks kicking-in. For now I can only offer a workaround of disabling overscroll, which I recognise is not ideal.

We'll have a look at some point - sample app will help.

Thanks again for reporting!

Message last modified on Jan 23, 2025 11:43AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #8Jan 23, 2025 11:56AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 450e0c3c50cb320b0f6222626034455a48aca54b
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Aug 13 10:18:41 2019

Take RV padding and item decorations into account

RecyclerView's padding and item decorations shift the position of the
current page when idle. The padding also shrinks the page size.

Bug: 139012032
Test: ./gradlew viewpager2:cC

Change-Id: Ia03646db95bb8d392408bce4d22430981c3f9171

M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/PaddingMarginDecorationTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ScrollEventAdapter.java
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java

https://android-review.googlesource.com/1101299

https://goto.google.com/android-sha1/450e0c3c50cb320b0f6222626034455a48aca54b

gr...@google.com <gr...@google.com> #9Jan 23, 2025 11:05PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6faf0d9fbabf6b59465ed135b4b44100bb2b3806
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Aug 14 16:33:05 2019

Always snap to center between padding

Even when clipToPadding is false, the center of RecyclerView is still
the middle of the rectangle described on the inside of the padding, not
the middle of the rectangle described on the outside of the padding.

Bug: 139452422
Bug: 139012032
Test: ./gradlew recyclerview:recyclerview:cC \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.recyclerview.widget.PagerSnapHelperTest

Change-Id: I8869f13fdd6a45b49ee3b288ff83e224faffa3c9

M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/PagerSnapHelper.java
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PaddingMarginDecorationTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/swipe/PageSwiperEspresso.java
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/swipe/PageSwiperManual.java

https://android-review.googlesource.com/1103182

https://goto.google.com/android-sha1/6faf0d9fbabf6b59465ed135b4b44100bb2b3806

Message last modified on Jan 28, 2025 07:41PM

ap...@google.com <ap...@google.com> #10Jan 24, 2025 02:21AM

Hi, in the upcoming release of viewpager2, you will be able to set padding on RecyclerView. Note that if you have asymmetric padding, you will also need the upcoming release of recyclerview.

Closing the bug for now, but please feel free to re-open this if the suggested releases don't fix your problem, so we can continue the investigation.

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #11Jan 24, 2025 08:01AM

beta04 will allow for a workaround (set padding in the inner RecyclerView), but we will keep this open for a long-term fix

gr...@google.com <gr...@google.com> #12Jan 28, 2025 12:40AM

Who this

gr...@google.com <gr...@google.com> #13Jan 28, 2025 07:46PM

Looping under a more general overscroll buganizer item.

er...@gmail.com <er...@gmail.com> #14Feb 13, 2025 11:52PM

Saw that beta02 is out but there is no mention of this issue being fixed in the release notes. Were you able to land the fix in beta02 or it got pushed to a future version?

gr...@google.com <gr...@google.com> #15Feb 14, 2025 11:35PM

Marked as fixed.

Looks like it actually went out in beta01.

er...@gmail.com <er...@gmail.com> #16Mar 12, 2025 03:57PM

Do you have some kind of ETA when 1.8 will reach stable? We're currently debating on switching our prod app on the compose-bom-beta:2025.02.00 artifact otherwise which points to 1.8.0-beta02 versions at the moment.

gp...@squareup.com <gp...@squareup.com> #17Mar 12, 2025 06:02PM

The team just release 1.8.0-rc01 compose-bom-beta:2025.03.00 and I am still seeing the issue happen inconsistently.

Message last modified on Mar 12, 2025 06:02PM

Issue 391378120

Description

Issue summary

Comments

gr...@google.com <gr...@google.com> Jan 22, 2025 07:42PM

gr...@google.com <gr...@google.com> #2Jan 22, 2025 09:42PM

gr...@google.com <gr...@google.com> #3Jan 22, 2025 10:25PM

gr...@google.com <gr...@google.com> #4Jan 22, 2025 10:46PM

gr...@google.com <gr...@google.com> #5Jan 22, 2025 11:24PM

gr...@google.com <gr...@google.com> #6Jan 23, 2025 12:06AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #7Jan 23, 2025 11:40AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #8Jan 23, 2025 11:56AM

gr...@google.com <gr...@google.com> #9Jan 23, 2025 11:05PM

ap...@google.com <ap...@google.com> #10Jan 24, 2025 02:21AM

pa...@partners.mbank.pl <pa...@partners.mbank.pl> #11Jan 24, 2025 08:01AM

gr...@google.com <gr...@google.com> #12Jan 28, 2025 12:40AM

gr...@google.com <gr...@google.com> #13Jan 28, 2025 07:46PM

er...@gmail.com <er...@gmail.com> #14Feb 13, 2025 11:52PM

gr...@google.com <gr...@google.com> #15Feb 14, 2025 11:35PM

er...@gmail.com <er...@gmail.com> #16Mar 12, 2025 03:57PM

gp...@squareup.com <gp...@squareup.com> #17Mar 12, 2025 06:02PM

Add comment

Issue metadata