AGP KMP breaks Gradle metadata for KMP projects that target JVM [396184120]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Feb 12, 2025 09:13PM

Applying the newer AGP KMP plugin to androidx.sqlite breaks the Gradle metadata such that a JVM project depending on the artifact will attempt (and fail) to use the android artifact instead of the JVM one.

This was originally reported in SQLite KMP b/396148592

Here is a diff on the metadata, left is before AGP KMP is used (i.e. after reverting the changes in this CL) and right is with AGP KMP applied: https://diff.googleplex.com/#key=EY2FqaJWQbUQ

Let me know if you need a sample project, but if you create a new JVM or Kotlin project and depend on androidx.sqlite:sqlite:2.5.0-beta01 and try to use classes from it, it will fail at runtime with a class not found exception. When inspecting the deps via :dependencies you will notice it attempts to use the -android artifact instead of the -jvm one:

runtimeClasspath - Runtime classpath of 'main'.
+--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10
|    \--- org.jetbrains:annotations:13.0
\--- androidx.sqlite:sqlite:2.5.0-beta01
     +--- androidx.annotation:annotation:1.8.1
     |    \--- androidx.annotation:annotation-jvm:1.8.1
     |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 2.1.10 (*)
     +--- androidx.sqlite:sqlite-android:2.5.0-beta01
     |    +--- androidx.annotation:annotation:1.8.1 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.1.10 (*)
     |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 (c)
     \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 (*)

Comments

au...@google.com <au...@google.com> #2Feb 12, 2025 09:28PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

da...@google.com <da...@google.com> #3Feb 12, 2025 09:34PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

au...@google.com <au...@google.com> #4Feb 12, 2025 09:39PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

da...@google.com <da...@google.com> #5Feb 12, 2025 09:45PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

Message last modified on Feb 12, 2025 09:46PM

sqlitedrivertest.zip

182 KB

Download

da...@google.com <da...@google.com> #6Feb 12, 2025 09:56PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

hm...@google.com <hm...@google.com> #7Feb 13, 2025 10:15AM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

Message last modified on Feb 13, 2025 12:58PM

hm...@google.com <hm...@google.com> #8Feb 13, 2025 01:15PM

Yes, this fix is planned to be included in a future 1.7.x release.

hm...@google.com <hm...@google.com> #9Feb 13, 2025 01:46PM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

da...@google.com <da...@google.com> #10Feb 13, 2025 02:03PM

The library is from androidx, we are using 8.9.0-beta01

I did also notice the compile classpath is fine, after all it compiles correctly and the APIs do resolve in the IDE, but at runtime it fails.

da...@google.com <da...@google.com> #11Feb 13, 2025 07:22PM

So far we have found that from alpha12 (good version) to alpha13 (bad version) of androidx.sqlite, one change that affected the metadata was the upgrade from Gradle 8.11.1 to 8.12, this is a diff of the metadata: https://diff.googleplex.com/#key=2ZkNTETNoG0R.

Notice the removal of the org.gradle.libraryelements attribute. The attribute is also missing with Gradle 8.13-rc1

Message last modified on Feb 13, 2025 07:23PM

ow...@google.com <ow...@google.com> Feb 18, 2025 05:47PM

Reassigned to hm...@google.com.

hm...@google.com <hm...@google.com> #12Feb 26, 2025 12:40PM

Update on libraryelements attribute missing in jvm target publications with Gradle 8.12 - Jetbrain are saying it will be fixed after https://youtrack.jetbrains.com/issue/KT-36004/Update-org.gradle.usage-attribute-rules-to-support-the-JAVAAPI-and-JAVARUNTIME-value which is targeting KGP 2.1.21. Temporary fix could be for androidX to explicitly set libraryelements attribute to "jar" for the jvm api/runtime elements publications.

By the way I have noticed a weird behaviour - if you do ./gradlew publish in your project libraryelements is not there for jvm publications but if you do ./gradlew publishJvmPublicationToMavenRepository it's there

Daniel, Owen, let me know if this is enough info to proceed further with a fix.

hm...@google.com <hm...@google.com> #13Mar 3, 2025 10:25AM

Reassigned to da...@google.com.

For the issue of the android publications where "org.gradle.libraryelements" = "jar" instead of "aar" - that was fixed in AGP 8.10 canary 7. Please feel free to try it out and report back. Thank you

da...@google.com <da...@google.com> Mar 3, 2025 01:42PM

Marked as fixed.

au...@google.com <au...@google.com> #14Mar 4, 2025 05:12PM

FYI danysantiago@ we have upgraded to 8.10.0-alpha07 in androidx.