AGP KMP breaks Gradle metadata for KMP projects that target JVM [396184120]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Feb 12, 2025 09:13PM

Applying the newer AGP KMP plugin to androidx.sqlite breaks the Gradle metadata such that a JVM project depending on the artifact will attempt (and fail) to use the android artifact instead of the JVM one.

This was originally reported in SQLite KMP b/396148592

Here is a diff on the metadata, left is before AGP KMP is used (i.e. after reverting the changes in this CL) and right is with AGP KMP applied: https://diff.googleplex.com/#key=EY2FqaJWQbUQ

Let me know if you need a sample project, but if you create a new JVM or Kotlin project and depend on androidx.sqlite:sqlite:2.5.0-beta01 and try to use classes from it, it will fail at runtime with a class not found exception. When inspecting the deps via :dependencies you will notice it attempts to use the -android artifact instead of the -jvm one:

runtimeClasspath - Runtime classpath of 'main'.
+--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10
|    \--- org.jetbrains:annotations:13.0
\--- androidx.sqlite:sqlite:2.5.0-beta01
     +--- androidx.annotation:annotation:1.8.1
     |    \--- androidx.annotation:annotation-jvm:1.8.1
     |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 2.1.10 (*)
     +--- androidx.sqlite:sqlite-android:2.5.0-beta01
     |    +--- androidx.annotation:annotation:1.8.1 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.1.10 (*)
     |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 (c)
     \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 (*)

Comments

au...@google.com <au...@google.com> #2Feb 12, 2025 09:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit e81f3bda1116a1734ec397f54dd40f8472203294
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Aug 08 12:22:30 2022

Converting `sqlite` related files in `sqlite` from Java to Kotlin (Part 1/3).

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I7bc3574feaacb12bd4aa1c006579ddc52607a3a5

M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/RoomSQLiteQueryTest.java
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteProgram.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteCompat.kt
M sqlite/sqlite/src/test/java/androidx/sqlite/db/SimpleSQLiteQueryTest.kt
M sqlite/sqlite/api/current.txt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SimpleSQLiteQuery.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQuery.kt
M room/room-compiler/build.gradle
M room/room-runtime/src/main/java/androidx/room/RoomSQLiteQuery.kt
M sqlite/sqlite-framework/build.gradle
M sqlite/sqlite/api/public_plus_experimental_current.txt
M sqlite/sqlite/build.gradle
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteStatement.kt
M room/room-runtime/api/restricted_current.ignore
M sqlite/sqlite/api/restricted_current.txt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/QueryInterceptorTest.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorDatabase.kt

https://android-review.googlesource.com/2177713

da...@google.com <da...@google.com> #3Feb 12, 2025 09:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit 659c2cdeeb8a045b413da4763d1431497592e5cf
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Aug 08 11:07:43 2022

Renaming `sqlite` related files in `sqlite` from Java to Kotlin (Part 1/3).

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I60b041d58430c70c028b91ef8c86a0d64f89fc3a

M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQuery.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteStatement.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteProgram.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteCompat.kt
M sqlite/sqlite/src/test/java/androidx/sqlite/db/SimpleSQLiteQueryTest.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SimpleSQLiteQuery.kt

https://android-review.googlesource.com/2177712

au...@google.com <au...@google.com> #4Feb 12, 2025 09:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit a55634970cd065189bf9055c9ec5cbbdeeb789fc
Author: elifbilgin <elifbilgin@google.com>
Date: Wed Aug 10 16:44:43 2022

Converting `sqlite-framework` related files in `sqlite-framework` from Java to Kotlin.

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite-framework` related files in `sqlite-framework` from Java to Kotlin.
Change-Id: Iaa63a678596118d4d40da7b12a30839166d0bc11

D sqlite/sqlite-framework/src/main/java/androidx/sqlite/util/SneakyThrow.java
M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperTest.kt
M sqlite/sqlite-framework/api/current.txt
M sqlite/sqlite-framework/src/androidTest/java/androidx/sqlite/db/framework/OpenHelperRecoveryTest.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteProgram.kt
M sqlite/sqlite-framework/api/public_plus_experimental_current.txt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/InternalsTest.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/util/ProcessLock.kt
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteStatement.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelperFactory.kt
M sqlite/sqlite-framework/api/restricted_current.txt

https://android-review.googlesource.com/2182324

da...@google.com <da...@google.com> #5Feb 12, 2025 09:45PM

Project: platform/frameworks/support
Branch: androidx-main

commit d6fc345225a1546cdb00a8a2728dfb5adcddb762
Author: elifbilgin <elifbilgin@google.com>
Date: Wed Aug 10 12:55:32 2022

Initial code check-in for renaming `sqlite-framework` related files in `sqlite` from *.java to *.kt.

Test: N/A
Bug: 240707042
Relnote: Initial code check-in for renaming `sqlite-framework` related files in `sqlite` from *.java to *.kt.
Change-Id: I2ecd06a8122751ae46765a8a354a6c1e191e2149

M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/util/ProcessLock.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteProgram.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteStatement.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelperFactory.kt

https://android-review.googlesource.com/2182323

Message last modified on Feb 12, 2025 09:46PM

sqlitedrivertest.zip

182 KB

Download

da...@google.com <da...@google.com> #6Feb 12, 2025 09:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5e2fab48d7c66ec49ae8c1fff52bd0999c94fe05
Author: elifbilgin <elifbilgin@google.com>
Date: Thu Aug 18 10:27:53 2022

Converting `sqlite` related files in `sqlite` from Java to Kotlin (Part 2/3).

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I1d635ae1b6e7ef76de9c626b2088266a6a094a4d

M work/work-runtime/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SuspendingQueryTest.kt
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQueryBuilder.kt
M work/work-gcm/build.gradle
M sqlite/sqlite/api/current.txt
M work/work-testing/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/ForceStopRunnableTest.java
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelper.kt
M sqlite/sqlite/api/public_plus_experimental_current.txt
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteOpenHelper.kt
M work/work-multiprocess/build.gradle
M sqlite/sqlite/api/restricted_current.txt
M work/work-benchmark/build.gradle
M work/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/2189939

hm...@google.com <hm...@google.com> #7Feb 13, 2025 10:15AM

Project: platform/frameworks/support
Branch: androidx-main

commit 751e9ba511b3263cab58bd877afe2dd7dc77b891
Author: elifbilgin <elifbilgin@google.com>
Date: Wed Aug 17 16:31:25 2022

Renaming `sqlite` related files in `sqlite` from Java to Kotlin (Part 2/3).

Test: Existing tests
Bug: 240707042
Relnote: Renaming `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I0c0558046191bd05621ae39988b4b7cd5b9459c5

M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQueryBuilder.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteOpenHelper.kt

https://android-review.googlesource.com/2189938

Message last modified on Feb 13, 2025 12:58PM

hm...@google.com <hm...@google.com> #8Feb 13, 2025 01:15PM

Project: platform/frameworks/support
Branch: androidx-main

commit 684e629ec17072ea31aae485492b4fd2b10043f6
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Aug 30 18:47:45 2022

Converting SupportSQLiteDatabase from *.java to *.kt.

Test: N/A
Bug: 240707042
Relnote: Converting SupportSQLiteDatabase from *.java to *.kt.
Change-Id: I251619c5d7a0869b89fe23217abd768c295f5e1f

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperFactoryTest.kt
M sqlite/sqlite-ktx/build.gradle
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.kt
M sqlite/sqlite-ktx/src/main/java/androidx/sqlite/db/SupportSQLiteDatabaseExt.kt
A sqlite/sqlite/api/current.ignore
A sqlite/sqlite/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M sqlite/integration-tests/inspection-sqldelight-testapp/build.gradle
M sqlite/sqlite-inspection/build.gradle
M sqlite/sqlite/api/current.txt
M sqlite/integration-tests/inspection-room-testapp/build.gradle
M room/room-ktx/src/test/java/androidx/room/MigrationTest.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.kt
M sqlite/sqlite-framework/build.gradle
M sqlite/sqlite/api/public_plus_experimental_current.txt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
M sqlite/sqlite/build.gradle
M sqlite/sqlite/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorDatabase.kt

https://android-review.googlesource.com/2199905

hm...@google.com <hm...@google.com> #9Feb 13, 2025 01:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 89bfc918a0bfe3237470262b75fd4a71c4048a1e
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Aug 30 18:07:34 2022

Initial code check-in for renaming SupportSQLiteDatabase from *.java to *.kt.

Test: N/A
Bug: 240707042
Relnote: Initial code check-in for renaming SupportSQLiteDatabase from *.java to *.kt.
Change-Id: I5627dba94bad99b1110778cd3e770c1f2a996294

M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteDatabase.kt

https://android-review.googlesource.com/2199904

da...@google.com <da...@google.com> #10Feb 13, 2025 02:03PM

This bug was linked in a change in the following release(s):

androidx.room:room-ktx:2.5.0-beta01
androidx.room:room-runtime:2.5.0-beta01
androidx.sqlite:sqlite:2.3.0-beta01
androidx.sqlite:sqlite-framework:2.3.0-beta01
androidx.sqlite:sqlite-ktx:2.3.0-beta01
androidx.work:work-gcm:2.8.0-beta01
androidx.work:work-multiprocess:2.8.0-beta01
androidx.work:work-runtime:2.8.0-beta01
androidx.work:work-runtime-ktx:2.8.0-beta01
androidx.work:work-testing:2.8.0-beta01

da...@google.com <da...@google.com> #11Feb 13, 2025 07:22PM

So far we have found that from alpha12 (good version) to alpha13 (bad version) of androidx.sqlite, one change that affected the metadata was the upgrade from Gradle 8.11.1 to 8.12, this is a diff of the metadata: https://diff.googleplex.com/#key=2ZkNTETNoG0R.

Notice the removal of the org.gradle.libraryelements attribute. The attribute is also missing with Gradle 8.13-rc1

Message last modified on Feb 13, 2025 07:23PM

ow...@google.com <ow...@google.com> Feb 18, 2025 05:47PM

Reassigned to hm...@google.com.

hm...@google.com <hm...@google.com> #12Feb 26, 2025 12:40PM

Update on libraryelements attribute missing in jvm target publications with Gradle 8.12 - Jetbrain are saying it will be fixed after https://youtrack.jetbrains.com/issue/KT-36004/Update-org.gradle.usage-attribute-rules-to-support-the-JAVAAPI-and-JAVARUNTIME-value which is targeting KGP 2.1.21. Temporary fix could be for androidX to explicitly set libraryelements attribute to "jar" for the jvm api/runtime elements publications.

By the way I have noticed a weird behaviour - if you do ./gradlew publish in your project libraryelements is not there for jvm publications but if you do ./gradlew publishJvmPublicationToMavenRepository it's there

Daniel, Owen, let me know if this is enough info to proceed further with a fix.

hm...@google.com <hm...@google.com> #13Mar 3, 2025 10:25AM

Reassigned to da...@google.com.

For the issue of the android publications where "org.gradle.libraryelements" = "jar" instead of "aar" - that was fixed in AGP 8.10 canary 7. Please feel free to try it out and report back. Thank you

da...@google.com <da...@google.com> Mar 3, 2025 01:42PM

Marked as fixed.

au...@google.com <au...@google.com> #14Mar 4, 2025 05:12PM

FYI danysantiago@ we have upgraded to 8.10.0-alpha07 in androidx.