Fixed
Status Update
Comments
da...@google.com <da...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 1b9ae441be4de3443b138e789c85722bba29c356
Author: Clara F <clarafok@google.com>
Date: Mon Mar 14 15:26:56 2022
[GH] Add room-paging-guava module to Room
Create module for integrating Guava into Room Paging
Test: n/a
Bug: 203666906
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/337 .
Resolves #337
Relnote: "Added a new artifact, room-paging-guava, for ListenableFuturePagingSource in
room-paging."
Github-Pr-Head-Sha: f62df108d6d5dd765c43b1e75472ddd0a097f9de
GitOrigin-RevId: 8c86aaa8e3a856614cbdccabe07c0d658efb0407
Change-Id: Ie14a1beef5d3b7ba07f3acc3fdd1f7bfc6fd1b9e
A room/room-paging-guava/src/androidTest/AndroidManifest.xml
A room/room-paging-guava/api/public_plus_experimental_current.txt
M settings.gradle
M docs-tip-of-tree/build.gradle
A room/room-paging-guava/api/restricted_current.txt
A room/room-paging-guava/api/res-current.txt
A room/room-paging-guava/src/main/AndroidManifest.xml
A room/room-paging-guava/api/current.txt
A room/room-paging-guava/build.gradle
https://android-review.googlesource.com/2025245
Branch: androidx-main
commit 1b9ae441be4de3443b138e789c85722bba29c356
Author: Clara F <clarafok@google.com>
Date: Mon Mar 14 15:26:56 2022
[GH] Add room-paging-guava module to Room
Create module for integrating Guava into Room Paging
Test: n/a
Bug: 203666906
This is an imported pull request from
Resolves #337
Relnote: "Added a new artifact, room-paging-guava, for ListenableFuturePagingSource in
room-paging."
Github-Pr-Head-Sha: f62df108d6d5dd765c43b1e75472ddd0a097f9de
GitOrigin-RevId: 8c86aaa8e3a856614cbdccabe07c0d658efb0407
Change-Id: Ie14a1beef5d3b7ba07f3acc3fdd1f7bfc6fd1b9e
A room/room-paging-guava/src/androidTest/AndroidManifest.xml
A room/room-paging-guava/api/public_plus_experimental_current.txt
M settings.gradle
M docs-tip-of-tree/build.gradle
A room/room-paging-guava/api/restricted_current.txt
A room/room-paging-guava/api/res-current.txt
A room/room-paging-guava/src/main/AndroidManifest.xml
A room/room-paging-guava/api/current.txt
A room/room-paging-guava/build.gradle
go...@lutraha.com <go...@lutraha.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit eb60980fbbeb3a9d824e721969a54db902c44857
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:08:03 2022
[GH] Add room-paging-rxjava3 module to Room
Test: n/a
Bug: 203666906
Relnote: Integrating rxjava3 support in Room Paging
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/339 .
Resolves #339
Github-Pr-Head-Sha: 274be4dcfc6f40861b476638c9671503e28129d4
GitOrigin-RevId: f081e641921b7dd64f1bba5800b4395074f902e1
Change-Id: I00d8884025aa4263a96dc509ccb8e303b53beeb8
M settings.gradle
A room/room-paging-rxjava3/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava3/api/restricted_current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava3/api/current.txt
A room/room-paging-rxjava3/build.gradle
A room/room-paging-rxjava3/src/main/AndroidManifest.xml
A room/room-paging-rxjava3/api/public_plus_experimental_current.txt
A room/room-paging-rxjava3/api/res-current.txt
https://android-review.googlesource.com/2027363
Branch: androidx-main
commit eb60980fbbeb3a9d824e721969a54db902c44857
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:08:03 2022
[GH] Add room-paging-rxjava3 module to Room
Test: n/a
Bug: 203666906
Relnote: Integrating rxjava3 support in Room Paging
This is an imported pull request from
Resolves #339
Github-Pr-Head-Sha: 274be4dcfc6f40861b476638c9671503e28129d4
GitOrigin-RevId: f081e641921b7dd64f1bba5800b4395074f902e1
Change-Id: I00d8884025aa4263a96dc509ccb8e303b53beeb8
M settings.gradle
A room/room-paging-rxjava3/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava3/api/restricted_current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava3/api/current.txt
A room/room-paging-rxjava3/build.gradle
A room/room-paging-rxjava3/src/main/AndroidManifest.xml
A room/room-paging-rxjava3/api/public_plus_experimental_current.txt
A room/room-paging-rxjava3/api/res-current.txt
on...@adastra.one <on...@adastra.one> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 41a1d4f8677c57db934d37bb0cd8db9d3f3aae6c
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:10:36 2022
[GH] Add room-paging-rxjava2 module to Room
Test: n/a
Bug: 203666906
Relnote: "Added new artifact room-paging-rxjava2 for rxjava2 support in Room Paging"
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/338 .
Resolves #338
Github-Pr-Head-Sha: f8c5c6f04217e43bbc4a78b9715deb920b830fa3
GitOrigin-RevId: 1dbf1e202286c42fc34c89a808d8c421fa1303af
Change-Id: I88f076392f1917c2fec52d3bd58d91e73b12a53b
A room/room-paging-rxjava2/api/current.txt
A room/room-paging-rxjava2/api/restricted_current.txt
M settings.gradle
A room/room-paging-rxjava2/api/res-current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava2/src/main/AndroidManifest.xml
A room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava2/api/public_plus_experimental_current.txt
https://android-review.googlesource.com/2027364
Branch: androidx-main
commit 41a1d4f8677c57db934d37bb0cd8db9d3f3aae6c
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:10:36 2022
[GH] Add room-paging-rxjava2 module to Room
Test: n/a
Bug: 203666906
Relnote: "Added new artifact room-paging-rxjava2 for rxjava2 support in Room Paging"
This is an imported pull request from
Resolves #338
Github-Pr-Head-Sha: f8c5c6f04217e43bbc4a78b9715deb920b830fa3
GitOrigin-RevId: 1dbf1e202286c42fc34c89a808d8c421fa1303af
Change-Id: I88f076392f1917c2fec52d3bd58d91e73b12a53b
A room/room-paging-rxjava2/api/current.txt
A room/room-paging-rxjava2/api/restricted_current.txt
M settings.gradle
A room/room-paging-rxjava2/api/res-current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava2/src/main/AndroidManifest.xml
A room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava2/api/public_plus_experimental_current.txt
a....@pri-num.com <a....@pri-num.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 2f45502b3d448965f0e52067e8b39108708d1faf
Author: clarafok <clarafok@google.com>
Date: Mon Apr 11 15:50:07 2022
Implement LimitOffsetListenableFuturePagingSource
An abstract implementation of ListenableFuturePagingSource to be
implemented by Room. Supports Guava operations through ListenableFuture.
Test: ./gradlew room:room-paging-guava:cC
Bug: 203666906
Change-Id: I3ec746a072d28e856018d03aeb08931a8d42fa93
A room/room-paging-guava/src/main/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
A room/room-paging-guava/src/androidTest/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSourceTest.kt
M room/room-paging/build.gradle
M room/room-paging-guava/build.gradle
M room/room-paging/src/main/kotlin/androidx/room/paging/util/RoomPagingUtil.kt
https://android-review.googlesource.com/2037356
Branch: androidx-main
commit 2f45502b3d448965f0e52067e8b39108708d1faf
Author: clarafok <clarafok@google.com>
Date: Mon Apr 11 15:50:07 2022
Implement LimitOffsetListenableFuturePagingSource
An abstract implementation of ListenableFuturePagingSource to be
implemented by Room. Supports Guava operations through ListenableFuture.
Test: ./gradlew room:room-paging-guava:cC
Bug: 203666906
Change-Id: I3ec746a072d28e856018d03aeb08931a8d42fa93
A room/room-paging-guava/src/main/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
A room/room-paging-guava/src/androidTest/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSourceTest.kt
M room/room-paging/build.gradle
M room/room-paging-guava/build.gradle
M room/room-paging/src/main/kotlin/androidx/room/paging/util/RoomPagingUtil.kt
aq...@gmail.com <aq...@gmail.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 76e8c1ef8e3f90ecb1376ec0d0dc418990b7e515
Author: Clara Fok <clarafok@google.com>
Date: Thu Apr 28 17:05:24 2022
Hook up room-paging-guava to room-compiler
Test: ./gradlew :room:room-compiler:test
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: Iaa2e7b542b4398f2e364c0b68896c046589e9a09
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/ListenableFuturePagingSourceQueryResultBinderProvider.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/integration-tests/kotlintestapp/build.gradle
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-paging-guava/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/ItemStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetListenableFuturePagingSource.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/PagingSourceQueryResultBinderProvider.kt
M testutils/testutils-common/src/main/java/androidx/testutils/FilteringExecutor.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/room-compiler/src/test/data/common/input/ListenableFuturePagingSource.java
https://android-review.googlesource.com/2067883
Branch: androidx-main
commit 76e8c1ef8e3f90ecb1376ec0d0dc418990b7e515
Author: Clara Fok <clarafok@google.com>
Date: Thu Apr 28 17:05:24 2022
Hook up room-paging-guava to room-compiler
Test: ./gradlew :room:room-compiler:test
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: Iaa2e7b542b4398f2e364c0b68896c046589e9a09
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/ListenableFuturePagingSourceQueryResultBinderProvider.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/integration-tests/kotlintestapp/build.gradle
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-paging-guava/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/ItemStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetListenableFuturePagingSource.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/PagingSourceQueryResultBinderProvider.kt
M testutils/testutils-common/src/main/java/androidx/testutils/FilteringExecutor.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/room-compiler/src/test/data/common/input/ListenableFuturePagingSource.java
da...@google.com <da...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit a5a856d88a480cbb1d4364f6b3d64ff450411cfd
Author: clarafok <clarafok@google.com>
Date: Wed May 11 13:52:19 2022
Implement room-paging-rxjava3 LimitOffsetRxPagingSource
Test: ./gradlew room:room-paging-rxjava3:cC
Bug: 203666906
Change-Id: I0127af74e4ec38c0570f56a5783ec2157f9bb9fc
A room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
A room/room-paging-rxjava3/src/androidTest/kotlin/androidx/room/paging/rxjava3/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava3/build.gradle
https://android-review.googlesource.com/2094107
Branch: androidx-main
commit a5a856d88a480cbb1d4364f6b3d64ff450411cfd
Author: clarafok <clarafok@google.com>
Date: Wed May 11 13:52:19 2022
Implement room-paging-rxjava3 LimitOffsetRxPagingSource
Test: ./gradlew room:room-paging-rxjava3:cC
Bug: 203666906
Change-Id: I0127af74e4ec38c0570f56a5783ec2157f9bb9fc
A room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
A room/room-paging-rxjava3/src/androidTest/kotlin/androidx/room/paging/rxjava3/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava3/build.gradle
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit c7b01e966accae484bb1dd081e3fa5f3f38047fc
Author: clarafok <clarafok@google.com>
Date: Thu May 12 15:28:45 2022
Hook up rxjava3 LimitOffsetRxPagingSource to room-compiler
Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: I57099d83a8c845263c5031990de3124971ac2363
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
A room/room-compiler/src/test/data/common/input/Rx3PagingSource.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx3PagingSource.java
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava3PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
https://android-review.googlesource.com/2097220
Branch: androidx-main
commit c7b01e966accae484bb1dd081e3fa5f3f38047fc
Author: clarafok <clarafok@google.com>
Date: Thu May 12 15:28:45 2022
Hook up rxjava3 LimitOffsetRxPagingSource to room-compiler
Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: I57099d83a8c845263c5031990de3124971ac2363
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
A room/room-compiler/src/test/data/common/input/Rx3PagingSource.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx3PagingSource.java
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava3PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
da...@google.com <da...@google.com>
da...@google.com <da...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit c4782c289e754747e1a98a28e2700836d78d7578
Author: clarafok <clarafok@google.com>
Date: Fri May 13 14:12:02 2022
Implement rxjava2 LimitOffsetRxPagingSource
Test: ./gradlew room:room-paging-rxjava2:cC
Bug: 203666906
Change-Id: Iefd883d45b18b032bb3a29d51209fc7de169c1aa
A room/room-paging-rxjava2/src/androidTest/kotlin/androidx/room/paging/rxjava2/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt
https://android-review.googlesource.com/2098470
Branch: androidx-main
commit c4782c289e754747e1a98a28e2700836d78d7578
Author: clarafok <clarafok@google.com>
Date: Fri May 13 14:12:02 2022
Implement rxjava2 LimitOffsetRxPagingSource
Test: ./gradlew room:room-paging-rxjava2:cC
Bug: 203666906
Change-Id: Iefd883d45b18b032bb3a29d51209fc7de169c1aa
A room/room-paging-rxjava2/src/androidTest/kotlin/androidx/room/paging/rxjava2/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt
an...@gmail.com <an...@gmail.com> #10
Project: platform/frameworks/support
Branch: androidx-main
commit d1ba57918465b84aa9564074df68d3136a4f8fcd
Author: clarafok <clarafok@google.com>
Date: Fri May 13 16:09:09 2022
Hook up room-paging-rxjava2 to room-compiler
Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Fixes: 203666906
Change-Id: Ic8f07f14491ece38b1296ca71c761511218a65a9
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/test/data/common/input/Rx2PagingSource.java
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava2PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx2PagingSource.java
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
https://android-review.googlesource.com/2098475
Branch: androidx-main
commit d1ba57918465b84aa9564074df68d3136a4f8fcd
Author: clarafok <clarafok@google.com>
Date: Fri May 13 16:09:09 2022
Hook up room-paging-rxjava2 to room-compiler
Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Fixes: 203666906
Change-Id: Ic8f07f14491ece38b1296ca71c761511218a65a9
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/test/data/common/input/Rx2PagingSource.java
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava2PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx2PagingSource.java
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
da...@google.com <da...@google.com> #11
re
ap...@google.com <ap...@google.com> #12
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Handle null value case for KSP annotation convertValueToType()
Expand for full commit details
Handle null value case for KSP annotation convertValueToType()
In I883b890f6e844ef3efd351ed7c5cf3004969e44c KSP annotation values that where null where replaced by their default value to workaround the KSP1 issue of not returning default values when reading non-JVM source set annotations. Usages of `filterNotNull()` and `mapNotNull()` where used when unwrapping but a direct null value case was missed. This CL adds such case when the value type is a primitive yet it is missing (null).
Bug: 329508813
Bug: 396607230
Test: Manual in KMP project with Kotlin 2.1.10 and KSP with useKsp2 = false and @ColumnInfo
Change-Id: I693c912910dd5dd7cfae73abef18e9076c11f0af
Files:
- M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspAnnotationValue.kt
Hash: f344a2e445227b287ecf10f84171065265606c9e
Date: Fri Feb 28 12:56:32 2025
da...@google.com <da...@google.com>
na...@google.com <na...@google.com> #13
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-compiler-processing:2.7.0-rc02
Description
Version used: room 2.7.0-beta01, sqlite 2.5.0-beta01
Devices/Android versions reproduced on: iPhone 16 Pro (18.2)
The issue happens during the compilation. The app compiles for Android target, but it fails to compile for iOS simulator.
> Task :xxx:kspKotlinIosSimulatorArm64 FAILED
note: [ksp] loaded provider(s): [androidx.room.RoomKspProcessor$Provider]
error: [ksp] java.lang.NullPointerException: null cannot be cast to non-null type androidx.room.compiler.processing.XAnnotation
at androidx.room.compiler.processing.XAnnotationValue.asAnnotation(XAnnotationValue.kt:62)
at androidx.room.compiler.processing.XAnnotationValue.asAnnotationList(XAnnotationValue.kt:68)
at androidx.room.processor.EntityProcessor$Companion.extractIndices(EntityProcessor.kt:42)
at androidx.room.processor.TableEntityProcessor.doProcess(TableEntityProcessor.kt:85)
at androidx.room.processor.TableEntityProcessor.process$lambda$0(TableEntityProcessor.kt:54)
at androidx.room.processor.cache.Cache$Bucket.get(Cache.kt:48)
at androidx.room.processor.TableEntityProcessor.process(TableEntityProcessor.kt:54)
at androidx.room.processor.DatabaseProcessor.processEntities(DatabaseProcessor.kt:442)
at androidx.room.processor.DatabaseProcessor.doProcess(DatabaseProcessor.kt:68)
at androidx.room.processor.DatabaseProcessor.process(DatabaseProcessor.kt:59)
at androidx.room.DatabaseProcessingStep.process$lambda$2$lambda$1(DatabaseProcessingStep.kt:69)
at androidx.room.processor.Context.collectLogs(Context.kt:178)
at androidx.room.DatabaseProcessingStep.process(DatabaseProcessingStep.kt:68)
at androidx.room.compiler.processing.CommonProcessorDelegate.processRound(XBasicAnnotationProcessor.kt:134)
at androidx.room.compiler.processing.ksp.KspBasicAnnotationProcessor.process(KspBasicAnnotationProcessor.kt:62)
at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension$doAnalysis$8$1.invoke(KotlinSymbolProcessingExtension.kt:320)
at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension$doAnalysis$8$1.invoke(KotlinSymbolProcessingExtension.kt:318)
at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension.handleException(KotlinSymbolProcessingExtension.kt:430)
at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension.doAnalysis(KotlinSymbolProcessingExtension.kt:318)
at org.jetbrains.kotlin.backend.konan.TopDownAnalyzerFacadeForKonan.analyzeFilesWithGivenTrace(TopDownAnalyzerFacadeForKonan.kt:102)
at org.jetbrains.kotlin.backend.konan.TopDownAnalyzerFacadeForKonan.analyzeFiles(TopDownAnalyzerFacadeForKonan.kt:65)
at org.jetbrains.kotlin.backend.konan.driver.phases.FrontendKt.FrontendPhase$lambda$3$lambda$2(Frontend.kt:67)
at org.jetbrains.kotlin.cli.common.messages.AnalyzerWithCompilerReport.analyzeAndReport(AnalyzerWithCompilerReport.kt:112)
at org.jetbrains.kotlin.backend.konan.driver.phases.FrontendKt.FrontendPhase$lambda$3(Frontend.kt:66)
at org.jetbrains.kotlin.backend.common.phaser.PhaseBuildersKt$createSimpleNamedCompilerPhase$1.phaseBody(PhaseBuilders.kt:69)
at org.jetbrains.kotlin.backend.common.phaser.SimpleNamedCompilerPhase.phaseBody(CompilerPhase.kt:226)
at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:113)
at org.jetbrains.kotlin.backend.konan.driver.PhaseEngine.runPhase(Machinery.kt:120)
at org.jetbrains.kotlin.backend.konan.driver.PhaseEngine.runPhase$default(Machinery.kt:111)
at org.jetbrains.kotlin.backend.konan.driver.phases.TopLevelPhasesKt.runFrontend(TopLevelPhases.kt:32)
at org.jetbrains.kotlin.backend.konan.driver.DynamicCompilerDriver.serializeKlibK1(DynamicCompilerDriver.kt:152)
at org.jetbrains.kotlin.backend.konan.driver.DynamicCompilerDriver.produceKlib(DynamicCompilerDriver.kt:113)
at org.jetbrains.kotlin.backend.konan.driver.DynamicCompilerDriver.run$lambda$2$lambda$1$lambda$0(DynamicCompilerDriver.kt:44)
at org.jetbrains.kotlin.backend.konan.driver.PhaseEngine$Companion$startTopLevel$topLevelPhase$1.phaseBody(Machinery.kt:79)
at org.jetbrains.kotlin.backend.konan.driver.PhaseEngine$Companion$startTopLevel$topLevelPhase$1.phaseBody(Machinery.kt:73)
at org.jetbrains.kotlin.backend.common.phaser.SimpleNamedCompilerPhase.phaseBody(CompilerPhase.kt:226)
at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:113)
at org.jetbrains.kotlin.backend.konan.driver.PhaseEngine$Companion.startTopLevel(Machinery.kt:86)
at org.jetbrains.kotlin.backend.konan.driver.DynamicCompilerDriver.run(DynamicCompilerDriver.kt:37)
at org.jetbrains.kotlin.backend.konan.KonanDriver.run(KonanDriver.kt:151)
at org.jetbrains.kotlin.cli.bc.K2Native.runKonanDriver(K2Native.kt:167)
at org.jetbrains.kotlin.cli.bc.K2Native.doExecute(K2Native.kt:63)
at org.jetbrains.kotlin.cli.bc.K2Native.doExecute(K2Native.kt:32)
at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:102)
at org.jetbrains.kotlin.cli.common.CLICompiler.exec(CLICompiler.kt:316)
at org.jetbrains.kotlin.cli.common.CLICompiler.exec(CLICompiler.kt:294)
at org.jetbrains.kotlin.cli.common.CLICompiler.exec(CLICompiler.kt:258)
at org.jetbrains.kotlin.cli.common.CLICompiler$Companion.doMainNoExit(CLICompiler.kt:395)
at org.jetbrains.kotlin.cli.bc.K2Native$Companion.mainNoExitWithRenderer$lambda$2(K2Native.kt:217)
at org.jetbrains.kotlin.util.UtilKt.profileIf(Util.kt:22)
at org.jetbrains.kotlin.util.UtilKt.profile(Util.kt:16)
at org.jetbrains.kotlin.cli.bc.K2Native$Companion.mainNoExitWithRenderer(K2Native.kt:216)
at org.jetbrains.kotlin.cli.bc.K2NativeKt.mainNoExitWithXcodeRenderer(K2Native.kt:235)
at org.jetbrains.kotlin.cli.utilities.MainKt$daemonMainWithXcodeRenderer$1.invoke(main.kt:52)
at org.jetbrains.kotlin.cli.utilities.MainKt$daemonMainWithXcodeRenderer$1.invoke(main.kt:52)
at org.jetbrains.kotlin.cli.utilities.MainKt.mainImpl(main.kt:20)
at org.jetbrains.kotlin.cli.utilities.MainKt.inProcessMain(main.kt:57)
at org.jetbrains.kotlin.cli.utilities.MainKt.daemonMainWithXcodeRenderer(main.kt:52)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.jetbrains.kotlin.internal.compilerRunner.native.KotlinNativeToolRunner.runInProcess(KotlinNativeToolRunner.kt:151)
at org.jetbrains.kotlin.internal.compilerRunner.native.KotlinNativeToolRunner.runTool(KotlinNativeToolRunner.kt:52)
at org.jetbrains.kotlin.gradle.tasks.KotlinNativeCompile$compile$1.invoke(KotlinNativeTasks.kt:594)
at org.jetbrains.kotlin.gradle.tasks.KotlinNativeCompile$compile$1.invoke(KotlinNativeTasks.kt:578)
at org.jetbrains.kotlin.compilerRunner.ReportUtilsKt.addBuildMetricsForTaskAction(reportUtils.kt:259)