(FR) RX improvements [63317956]

Fixed

Bug

Status Update

No update yet.

Description

ji...@gmail.com

created issue #1

Jul 5, 2017 12:04PM

Component used: Room with RxRoom
Version used: 1.0.0alpha3
Devices/Android versions reproduced on: all

After using Room and RxRoom I was lacking of some functionalities like the ability to return an Single/Completable from insert queries.

For example something like this would be super helpful :
@Insert(onConflict = OnConflictStrategy.REPLACE)
Completable insertAll(CatalogEntry... entries);

@Insert(onConflict = OnConflictStrategy.REPLACE)
Single<Long> insertAll(CatalogEntry... entries);

@Insert(onConflict = OnConflictStrategy.REPLACE)
Single<List<Long>> insertAll(CatalogEntry... entries);

Also when doing a query for retrieving a list, why should I use Flowable, if I just want to get a list my query should be like:

@Query("SELECT * FROM catalog_entries")
Single<List<CatalogEntry>> getAll();

Thanks for your work ! I love it already :)

Comments

de...@gmail.com <de...@gmail.com> #2Jul 6, 2017 02:33AM

Thanks for the report - do you have any reproduction steps?

yb...@google.com <yb...@google.com> #3Jul 17, 2017 04:06PM

Assigned to yb...@google.com.

Nevermind, this has been fixed and will be available in an upcoming release.

ji...@gmail.com <ji...@gmail.com> #4Jul 17, 2017 07:19PM

An unfortunate side effect of this seems to be that the adapter is set to null before any pending fragment animations are completed.

In my project I add a PreferenceFragmentCompat to the backstack, specifying custom enter and exit animations. Now, when the user presses the back button I call FragmentManager.popBackStack() which in turn starts the custom exit animation.

The problem is that popBackstack() internally calls onDestroyView() on the PreferenceFragmentCompat to be removed. The PreferenceFragmentCompat calls unbindPreferences() which calls getListView().setAdapter(null).

The effect is that the list of preference items is cleared instantly before the exit animation even starts! This causes a white flicker and is clearly noticeable, the preference items disappear, then the view fades out.

Could you prevent setAdapter(null) from being called in this scenario? Maybe unregister the data observer instead?

ra...@gmail.com <ra...@gmail.com> #5Aug 30, 2017 09:41PM

Since the Fragment 1.2.0-alpha02 release fragments wait until exit animations are complete before onDestroyView() is called so this should not be an issue in any current Fragment versions.

Please file a bug against Fragments the with a sample project that reproduces this issue and we will be happy to take a look at what's going on.

ra...@gmail.com <ra...@gmail.com> #6Jan 11, 2018 02:47PM

I can confirm that using fragment 1.2.2 resolves the issue, thank you!

Without an explicit dependency declaration version 1.1.0 was still used (transient dependency of appcompat 1.1.0).

la...@x2mobile.net <la...@x2mobile.net> #7Mar 26, 2018 01:18PM

This issue is half year old and it's still not implemented. Without this the library is unusable.

je...@gmail.com <je...@gmail.com> #8Mar 27, 2018 12:51PM

fr...@gmail.com <fr...@gmail.com> #9Apr 24, 2018 05:48AM

+1 Here as well. I would like Completable support.

sh...@gmail.com <sh...@gmail.com> #10Apr 24, 2018 05:03PM

+1 i think Completable support is necessary

do...@gmail.com <do...@gmail.com> #11May 22, 2018 12:10PM

+1 for Completable support as well

wh...@gmail.com <wh...@gmail.com> #12Jun 5, 2018 11:24AM

+1 for completable - just missed it on the fly while coding

ej...@gmail.com <ej...@gmail.com> #13Jun 10, 2018 10:41PM

+1 for Completable support as well

vs...@gmail.com <vs...@gmail.com> #14Jun 11, 2018 11:23AM

+1 for completable for @Delete @Update and @Insert

lo...@gmail.com <lo...@gmail.com> #15Jun 14, 2018 10:34AM

+1 for Completable support as well

56...@gmail.com <56...@gmail.com> #16Jun 14, 2018 10:43AM

Please Give a star instead of adding new comments.

ju...@gmail.com <ju...@gmail.com> #17Jun 28, 2018 12:20PM

This would be a nice improvement!

My initial response is to wrap the insert in a Completable when exposing the call to a consumer because of the time spent writing to the file system on the main thread. Guessing would probably desire the same API for delete.

Out of the box without LiveData/RxJava support for those types of calls it would violate strict rules and run into the guards of Room ensures that database is never accessed on the main thread.

fo...@gmail.com <fo...@gmail.com> #18Aug 14, 2018 08:38AM

It's really necessary thing and it's not implemented still(

sh...@gmail.com <sh...@gmail.com> #19Aug 14, 2018 12:22PM

+1 Come on we need support for completable. its been more than an year :(

yb...@google.com <yb...@google.com> #20Aug 14, 2018 05:34PM

Reassigned to fl...@google.com.

we are targeting this for 2.1.

bo...@li.ru <bo...@li.ru> #21Aug 17, 2018 06:02AM

+1 for completable for @Delete @Update and @Insert

ai...@gmail.com <ai...@gmail.com> #22Aug 20, 2018 09:54PM

+1 Come on guys!! ^_^

ap...@google.com <ap...@google.com> #23Aug 22, 2018 10:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c0c36b71b1e73eeaa49e5f29c2e3ee3923c811da
Author: Florina Muntenescu <florinam@google.com>
Date: Wed Aug 15 10:49:18 2018

Refactoring insert/update/delete to allow extensibility around the return type

Bug: 63317956
Test: tests updated
Change-Id: I5f8168fbd5cf08e64cb80c1835f4eebef6b4e018

M room/compiler/src/main/kotlin/androidx/room/processor/DeletionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/InsertionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/processor/UpdateMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/DeleteOrUpdateMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InsertMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InstantDeleteOrUpdateMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InstantInsertMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/DeleteOrUpdateMethodBinderProvider.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InsertMethodBinderProvider.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantDeleteOrUpdateMethodBinderProvider.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantInsertMethodBinderProvider.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/DeleteOrUpdateMethodAdapter.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/InsertMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/vo/DeletionMethod.kt
M room/compiler/src/main/kotlin/androidx/room/vo/InsertionMethod.kt
M room/compiler/src/main/kotlin/androidx/room/vo/ShortcutMethod.kt
M room/compiler/src/main/kotlin/androidx/room/vo/UpdateMethod.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DeletionMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/InsertionMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/UpdateMethodProcessorTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt

https://android-review.googlesource.com/732628

https://goto.google.com/android-sha1/c0c36b71b1e73eeaa49e5f29c2e3ee3923c811da

ap...@google.com <ap...@google.com> #24Sep 6, 2018 10:26AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 524c841aa2bec6fa72768b1aeb40f6c6b6734907
Author: Florina Muntenescu <florinam@google.com>
Date: Mon Sep 03 16:37:48 2018

Adding RxJava support to insert

Bug: 63317956
Change-Id: Ic122774f591319dcd70d7f362af94adb0342184b
Test: InsertionMethodProcessorTest and TypeAdapterStoreTest updated

M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/processor/InsertionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/RxCallableInsertMethodBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InsertMethodBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantInsertMethodBinderProvider.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/RxCallableInsertMethodBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/InsertMethodAdapter.kt
A room/compiler/src/test/data/common/input/rxjava2/Completable.java
A room/compiler/src/test/data/common/input/rxjava2/Maybe.java
A room/compiler/src/test/data/common/input/rxjava2/Single.java
M room/compiler/src/test/kotlin/androidx/room/processor/InsertionMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt

https://android-review.googlesource.com/745108

https://goto.google.com/android-sha1/524c841aa2bec6fa72768b1aeb40f6c6b6734907

ap...@google.com <ap...@google.com> #25Sep 7, 2018 04:17PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ecce72935bbe7987a9c0c1639f4aa245153c717a
Author: Florina Muntenescu <florinam@google.com>
Date: Fri Sep 07 15:36:18 2018

Add RxJava support for Delete and Update methods in Room.

Support for update and delete returning Integer also added.
Now, update and delete support:
* void
* int
* Integer
* Completable
* Single<Integer>
* Maybe<Integer>

Refactored the DeleteOrUpdateMethodAdapter to hold the return type, like InsertMethodAdapter is.

Bug: 63317956
Test: DaoWriterTest, TypeAdapterStoreTest, kotlin integration tests
Change-Id: Ic8d3cff21b9e8179fed237a18421c13b3e59059b

M room/compiler/src/main/kotlin/androidx/room/processor/DeletionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/UpdateMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/DeleteOrUpdateMethodBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/InstantDeleteOrUpdateMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/RxCallableDeleteOrUpdateMethodBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/DeleteOrUpdateMethodBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/InstantDeleteOrUpdateMethodBinderProvider.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/RxCallableDeleteOrUpdateMethodBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/DeleteOrUpdateMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/vo/DeletionMethod.kt
M room/compiler/src/main/kotlin/androidx/room/vo/ShortcutMethod.kt
M room/compiler/src/main/kotlin/androidx/room/vo/UpdateMethod.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/test/data/common/input/rxjava2/Completable.java
M room/compiler/src/test/data/common/input/rxjava2/Maybe.java
M room/compiler/src/test/data/common/input/rxjava2/Single.java
M room/compiler/src/test/data/daoWriter/input/DeletionDao.java
M room/compiler/src/test/data/daoWriter/input/UpdateDao.java
M room/compiler/src/test/data/daoWriter/output/DeletionDao.java
M room/compiler/src/test/data/daoWriter/output/UpdateDao.java
M room/compiler/src/test/kotlin/androidx/room/processor/ShortcutMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M room/compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt

https://android-review.googlesource.com/750573

https://goto.google.com/android-sha1/ecce72935bbe7987a9c0c1639f4aa245153c717a

fl...@google.com <fl...@google.com> #26Sep 8, 2018 03:31PM

Marked as fixed.

Support for Single, Maybe and Completable added for insert, update and delete. To be released in Room 2.1

vf...@thoughtworks.com <vf...@thoughtworks.com> #27Apr 9, 2019 10:37AM

When is Room 2.1 going to be released?

sl...@gmail.com <sl...@gmail.com> #28Jul 5, 2019 11:08AM

artifact was moved to

https://mvnrepository.com/artifact/androidx.room

Issue 63317956

Description

Issue summary

Comments

de...@gmail.com <de...@gmail.com> #2Jul 6, 2017 02:33AM

yb...@google.com <yb...@google.com> #3Jul 17, 2017 04:06PM

ji...@gmail.com <ji...@gmail.com> #4Jul 17, 2017 07:19PM

ra...@gmail.com <ra...@gmail.com> #5Aug 30, 2017 09:41PM

ra...@gmail.com <ra...@gmail.com> #6Jan 11, 2018 02:47PM

la...@x2mobile.net <la...@x2mobile.net> #7Mar 26, 2018 01:18PM

je...@gmail.com <je...@gmail.com> #8Mar 27, 2018 12:51PM

fr...@gmail.com <fr...@gmail.com> #9Apr 24, 2018 05:48AM

sh...@gmail.com <sh...@gmail.com> #10Apr 24, 2018 05:03PM

do...@gmail.com <do...@gmail.com> #11May 22, 2018 12:10PM

wh...@gmail.com <wh...@gmail.com> #12Jun 5, 2018 11:24AM

ej...@gmail.com <ej...@gmail.com> #13Jun 10, 2018 10:41PM

vs...@gmail.com <vs...@gmail.com> #14Jun 11, 2018 11:23AM

lo...@gmail.com <lo...@gmail.com> #15Jun 14, 2018 10:34AM

56...@gmail.com <56...@gmail.com> #16Jun 14, 2018 10:43AM

ju...@gmail.com <ju...@gmail.com> #17Jun 28, 2018 12:20PM

fo...@gmail.com <fo...@gmail.com> #18Aug 14, 2018 08:38AM

sh...@gmail.com <sh...@gmail.com> #19Aug 14, 2018 12:22PM

yb...@google.com <yb...@google.com> #20Aug 14, 2018 05:34PM

bo...@li.ru <bo...@li.ru> #21Aug 17, 2018 06:02AM

ai...@gmail.com <ai...@gmail.com> #22Aug 20, 2018 09:54PM

ap...@google.com <ap...@google.com> #23Aug 22, 2018 10:22PM

ap...@google.com <ap...@google.com> #24Sep 6, 2018 10:26AM

ap...@google.com <ap...@google.com> #25Sep 7, 2018 04:17PM

fl...@google.com <fl...@google.com> #26Sep 8, 2018 03:31PM

vf...@thoughtworks.com <vf...@thoughtworks.com> #27Apr 9, 2019 10:37AM

sl...@gmail.com <sl...@gmail.com> #28Jul 5, 2019 11:08AM

Add comment

Issue metadata