Wrong state after invoking startActivityForResult [65665621]

Fixed

Bug

Status Update

No update yet.

Description

fa...@gmail.com

created issue #1

Sep 14, 2017 01:18PM

Component used: LifecycleRegistry
Version used: 1.0.0-alpha9
Devices/Android versions reproduced on: Android 5 (it works on Android 8)

I have a strange problem connected to a MutableLiveData that doesn't trigger the observer when updated in onActivityResult. The cause seems to be a wrong state in LifecycleRegistry, in the following example the println in onResume prints "resume CREATED". Between startActivityForResult and onResume the state is set to CREATED even if the Activity remains always started (because the other activity is not full screen).

You can reproduce this issue using this Activity:

class LiveDataTestActivity : AppCompatActivity(), LifecycleRegistryOwner {

private val lifecycle = LifecycleRegistry(this)

override fun getLifecycle() = lifecycle

private val myLiveData = MutableLiveData<Int>().apply { value = 0 }

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
val textView = TextView(this).apply {
text = "AAAA"
setOnClickListener {
val sendIntent = Intent().apply {
action = Intent.ACTION_SEND
putExtra(Intent.EXTRA_TEXT, "This is my text to send.")
type = "text/plain"
}
startActivityForResult(sendIntent, 123)
}
}
setContentView(textView)

myLiveData.observe(this, Observer<Int> {
textView.text = it.toString()
})
}

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
super.onActivityResult(requestCode, resultCode, data)
myLiveData.value = (myLiveData.value ?: 0) + 1
println("Value ${myLiveData.value}")
}

override fun onResume() {
super.onResume()
println("resume ${lifecycle.currentState}")
}
}

Comments

yb...@google.com <yb...@google.com> Sep 15, 2017 12:07AM

Assigned to se...@google.com.

fa...@gmail.com <fa...@gmail.com> #2Sep 15, 2017 08:55AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

yb...@google.com <yb...@google.com> Sep 28, 2017 10:07PM

Reassigned to sh...@google.com.

yb...@google.com <yb...@google.com> Sep 29, 2017 07:47PM

Reassigned to yb...@google.com.

yb...@google.com <yb...@google.com> #3Sep 30, 2017 12:48AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

yb...@google.com <yb...@google.com> Oct 3, 2017 09:13PM

Reassigned to sh...@google.com.

sh...@google.com <sh...@google.com> Oct 4, 2017 09:33PM

Accepted by sh...@google.com.

sh...@google.com <sh...@google.com> #4Oct 12, 2017 12:45AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

sh...@google.com <sh...@google.com> Oct 16, 2017 10:41PM

Marked as fixed.

yb...@google.com <yb...@google.com> #5Oct 16, 2017 11:24PM

Status: Assigned (reopened)

reopened. fix for live data is in but the greater fix to make lifecycles consistent is still not merged.

yb...@google.com <yb...@google.com> Oct 18, 2017 02:06AM

Marked as fixed.

va...@gmail.com <va...@gmail.com> #6Jan 24, 2018 08:58AM

Norm

ms...@gmail.com <ms...@gmail.com> #7Feb 27, 2018 04:25AM

Fragment ransaction bug:

UncaughtException
java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
at android.view.ViewGroup.addViewInner(ViewGroup.java:4937)
at android.view.ViewGroup.addView(ViewGroup.java:4768)
at android.view.ViewGroup.addView(ViewGroup.java:4708)
at android.view.ViewGroup.addView(ViewGroup.java:4681)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1425)
at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1750)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1819)
at android.support.v4.app.BackStackRecord.executePopOps(BackStackRecord.java:855)
at android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2587)
at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2377)
at android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2332)
at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2239)
at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:700)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Issue 65665621

Description

Issue summary

Comments

yb...@google.com <yb...@google.com> Sep 15, 2017 12:07AM

fa...@gmail.com <fa...@gmail.com> #2Sep 15, 2017 08:55AM

yb...@google.com <yb...@google.com> Sep 28, 2017 10:07PM

yb...@google.com <yb...@google.com> Sep 29, 2017 07:47PM

yb...@google.com <yb...@google.com> #3Sep 30, 2017 12:48AM

yb...@google.com <yb...@google.com> Oct 3, 2017 09:13PM

sh...@google.com <sh...@google.com> Oct 4, 2017 09:33PM

sh...@google.com <sh...@google.com> #4Oct 12, 2017 12:45AM

sh...@google.com <sh...@google.com> Oct 16, 2017 10:41PM

yb...@google.com <yb...@google.com> #5Oct 16, 2017 11:24PM

yb...@google.com <yb...@google.com> Oct 18, 2017 02:06AM

va...@gmail.com <va...@gmail.com> #6Jan 24, 2018 08:58AM

ms...@gmail.com <ms...@gmail.com> #7Feb 27, 2018 04:25AM

Add comment

Issue metadata