Room Feature Request: Add Support for VIEW [67033276]

Fixed

Feature Request

Status Update

No update yet.

Description

mm...@commonsware.com

created issue #1

Sep 28, 2017 11:14AM

Component used: Room
Version used: 1.0.0-beta1
Devices/Android versions reproduced on: n/a

There appears to be no way to execute a CREATE VIEW in a way that Room will recognize. Instead, developers seem to need some icky workarounds (see

https://stackoverflow.com/q/46452786/115145 for an example).

My guess is that there should be a VIEW equivalent of @Entity, where the annotation takes the SELECT statement to go after the AS in the CREATE VIEW statement, where the Room compiler then assembles the rest.

Alternatively, @Entity could be extended to support views (e.g., via a viewSelect annotation property that triggers CREATE VIEW instead of CREATE TABLE logic). Bonus points here: there's no need to figure out the right annotation for a VIEW (since @View probably has been used 28 times already in various Android annotation processors...). :-)

Thanks for considering this!

Comments

yb...@google.com <yb...@google.com> #2Sep 28, 2017 03:16PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

an...@gmail.com <an...@gmail.com> #3Oct 8, 2017 09:12PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

fr...@gmail.com <fr...@gmail.com> #4Apr 24, 2018 04:00PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

da...@google.com <da...@google.com> Jul 24, 2018 07:53PM

Assigned to da...@google.com.

xm...@gmail.com <xm...@gmail.com> #5Aug 28, 2018 01:05PM

+1 For this

mu...@gmail.com <mu...@gmail.com> #6Sep 5, 2018 04:42PM

+1 For this

wo...@gmail.com <wo...@gmail.com> #7Sep 10, 2018 01:47AM

+10 for view support :)

ya...@google.com <ya...@google.com> Sep 10, 2018 08:55AM

Reassigned to ya...@google.com.

ap...@google.com <ap...@google.com> #8Sep 26, 2018 12:55AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 86ccd847759ea146464aaaf9ed128342d704b3ac
Author: Yuichi Araki <yaraki@google.com>
Date: Mon Aug 06 12:15:14 2018

Database View

Use @DatabaseView to create a view.

Bug: 67033276
Test: DatabaseViewTest, DatabaseViewProcessorTest, DatabaseVerifierTest,
Test: DatabaseWriterTest, SQLiteOpenHelperWriterTest,
Test: DatabaseViewSyncTest, InvalidationTrackerTest
Change-Id: I4a909add53f82fc6816b8d944278a3c9abef735d

M room/common/api/current.txt
M room/common/src/main/java/androidx/room/Database.java
A room/common/src/main/java/androidx/room/DatabaseView.java
M room/common/src/main/java/androidx/room/SkipQueryVerification.java
M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/parser/ParserErrors.kt
M room/compiler/src/main/kotlin/androidx/room/processor/DatabaseProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/processor/DatabaseViewProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt
M room/compiler/src/main/kotlin/androidx/room/vo/Database.kt
A room/compiler/src/main/kotlin/androidx/room/vo/DatabaseView.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DatabaseWriter.kt
M room/compiler/src/main/kotlin/androidx/room/writer/SQLiteOpenHelperWriter.kt
A room/compiler/src/main/kotlin/androidx/room/writer/ViewInfoValidationWriter.kt
A room/compiler/src/test/data/common/input/UserSummary.java
M room/compiler/src/test/data/databasewriter/input/ComplexDatabase.java
M room/compiler/src/test/data/databasewriter/output/ComplexDatabase.java
M room/compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DatabaseProcessorTest.kt
A room/compiler/src/test/kotlin/androidx/room/processor/DatabaseViewProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/compiler/src/test/kotlin/androidx/room/verifier/DatabaseVerifierTest.kt
M room/compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/compiler/src/test/kotlin/androidx/room/writer/DatabaseWriterTest.kt
M room/compiler/src/test/kotlin/androidx/room/writer/SQLiteOpenHelperWriterTest.kt
M room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/TestDatabase.java
M room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PetDao.java
M room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PetDaoTest.java
A room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/DogWithOwner.java
A room/integration-tests/testapp/schemas/androidx.room.integration.testapp.migration.MigrationDb/8.json
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/TestDatabase.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/PetDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/migration/MigrationDb.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/migration/MigrationTest.java
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/DatabaseViewTest.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/InvalidationTest.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/LiveDataQueryTest.java
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/vo/PetWithUser.java
M room/migration/src/main/java/androidx/room/migration/bundle/BundleUtil.java
M room/migration/src/main/java/androidx/room/migration/bundle/DatabaseBundle.java
A room/migration/src/main/java/androidx/room/migration/bundle/DatabaseViewBundle.java
M room/migration/src/test/java/androidx/room/migration/bundle/DatabaseBundleTest.java
A room/migration/src/test/java/androidx/room/migration/bundle/DatabaseViewBundleTest.java
A room/runtime/src/androidTest/java/androidx/room/migration/ViewInfoTest.java
M room/runtime/src/main/java/androidx/room/InvalidationTracker.java
A room/runtime/src/main/java/androidx/room/util/ViewInfo.java
M room/runtime/src/test/java/androidx/room/InvalidationTrackerTest.java
M room/testing/src/main/java/androidx/room/testing/MigrationTestHelper.java

https://android-review.googlesource.com/731045

https://goto.google.com/android-sha1/86ccd847759ea146464aaaf9ed128342d704b3ac

ya...@google.com <ya...@google.com> Oct 8, 2018 02:23AM

Marked as fixed.

to...@gmail.com <to...@gmail.com> #9Oct 8, 2018 03:12AM

I don't remember when I was this excited about a feature. Great work, can't wait to see it land in an official release.

jp...@gmail.com <jp...@gmail.com> #10Oct 9, 2018 10:32AM

"Thanks" seems so inadequate, but thanks :-)