Data binding breaks caching task outputs [69243050]

Fixed

Bug

Status Update

No update yet.

Description

lo...@gradle.com

created issue #1

Nov 13, 2017 12:43PM

When `android.defaultConfig.dataBinding.enabled == true`, a number of things happen that break task output caching:

- AndroidJavaCompile.dataBindingDependencyArtifacts is missing a `@PathSensitive` annotation, so it's treated as `ABSOLUTE` (this is tracked in

https://issuetracker.google.com/issues/68759178)

- A number of absolute paths are specified as annotation processor parameters in `options.compilerArgs`:

- -Aandroid.databinding.minApi=26
- -Aandroid.databinding.enableDebugLogs=0
- -Aandroid.databinding.sdkDir=/Users/lptr/Library/Android/sdk
- -Aandroid.databinding.bindingBuildFolder=/private/var/folders/kw/65bvkdfn6cv_4g4vszf1wm_80000gn/T/junit4630811611102055048/junit5868716240725709754/library/build/intermediates/data-binding-compiler/debug
- -Aandroid.databinding.enableForTests=0
- -Aandroid.databinding.modulePackage=org.gradle.android.example.library
- -Aandroid.databinding.generationalFileOutDir=/private/var/folders/kw/65bvkdfn6cv_4g4vszf1wm_80000gn/T/junit4630811611102055048/junit5868716240725709754/library/build/intermediates/bundles/debug/data-binding
- -Aandroid.databinding.xmlOutDir=/private/var/folders/kw/65bvkdfn6cv_4g4vszf1wm_80000gn/T/junit4630811611102055048/junit5868716240725709754/library/build/intermediates/data-binding-info/debug
- -Aandroid.databinding.artifactType=LIBRARY
- -Aandroid.databinding.printEncodedErrors=0
- -Aandroid.databinding.isTestVariant=0
- -Aandroid.databinding.exportClassListTo=/private/var/folders/kw/65bvkdfn6cv_4g4vszf1wm_80000gn/T/junit4630811611102055048/junit5868716240725709754/library/build/intermediates/data-binding-info/debug/_generated.txt

- A source file is generated called `DataBindingInfo.java` with a random UUID that changes every time a new file is generated:

package android.databinding.layouts;

import android.databinding.BindingBuildInfo;

@BindingBuildInfo(buildId="9dfdb009-9c54-4b16-8df1-956cd6e00303")
public class DataBindingInfo {}

Comments

xa...@google.com <xa...@google.com> Nov 13, 2017 05:21PM

Assigned to je...@google.com.

yb...@google.com <yb...@google.com> #2Nov 13, 2017 05:43PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

yb...@google.com <yb...@google.com> #3Nov 13, 2017 05:44PM

Almost 2 months later and this is still broken

yb...@google.com <yb...@google.com> #4Nov 13, 2017 05:45PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

xa...@google.com <xa...@google.com> #5Nov 13, 2017 05:48PM

jb...@google.com What is the update on this?

yb...@google.com <yb...@google.com> #6Nov 13, 2017 05:58PM

What is the status of this item?

lo...@gradle.com <lo...@gradle.com> #7Nov 13, 2017 07:54PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

yb...@google.com <yb...@google.com> #8Nov 16, 2017 04:32PM

Any ETA on next release?

lo...@gradle.com <lo...@gradle.com> #9Nov 16, 2017 05:41PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

yb...@google.com <yb...@google.com> #10Nov 16, 2017 05:52PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

je...@google.com <je...@google.com> Nov 22, 2017 11:16PM

Reassigned to yb...@google.com.

lo...@gradle.com <lo...@gradle.com> #11Nov 23, 2017 08:26AM

Hi, is there any update to this issue? Thanks.

yb...@google.com <yb...@google.com> #12Nov 23, 2017 10:19PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

lo...@gradle.com <lo...@gradle.com> #13Nov 24, 2017 08:27AM

Yeah, still not fixed --'

mz...@gmail.com <mz...@gmail.com> #14Feb 13, 2018 03:57PM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

lo...@gradle.com <lo...@gradle.com> #15Mar 20, 2018 02:05PM

Any updates on this? The help for this command clearly states this argument is supported.

yb...@google.com <yb...@google.com> #16Apr 3, 2018 10:49PM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.

yb...@google.com <yb...@google.com> #17Apr 10, 2018 04:28PM

For what it's worth, I did a quick test with the latest CLI: 11076708 (https://developer.android.com/studio#downloads) on OSX and tried it with a simple:

./sdkmanager --sdk_root="../sdk" --package_file=deps.txt

Deps.txt:

platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3

So perhaps this is now resolved? I haven't tried it with more packages

yb...@google.com <yb...@google.com> #18May 28, 2018 07:34PM

Reassigned to hu...@google.com.

I think this is already fixed, over to H.. to verify.

hu...@google.com <hu...@google.com> #19May 30, 2018 04:04AM

Yes, this has been fixed for Java projects that are not using the Kapt plugin.

In 3.2.0-alpha16, JavaCompile will be cacheable given the same project location (Change-Id: I1b69c0a86ef981f22634862be67d0143760dec2c).

In 3.2.0-alpha17, it will be cacheable across different project locations (Change-Id: Ibe60c7ce9142bf2fe44c9b4689b4490905dd1d1a).

In both scenarios, it is still not cacheable if Kapt is used. I'll find time to fix Kapt next, but it may or may not make it to 3.2 stable.

ja...@google.com <ja...@google.com> #20Jun 22, 2018 08:03PM

Talked with Hung. Caching issue related to kapt is blocked on:

https://youtrack.jetbrains.com/issue/KT-25027

https://youtrack.jetbrains.com/issue/KT-23866

ja...@google.com <ja...@google.com> #21Jun 25, 2018 03:53PM

Update: both JetBrains bugs have now been fixed.

hu...@google.com <hu...@google.com> #22Jul 11, 2018 12:30AM

We have fixed one of the two remaining caching scenarios when Kapt is used:

In 3.2.0-rc-01 (and 3.3.0-alpha-04), JavaCompile will be cacheable with Kapt given the same project location (Change-Id: Idf21b53232af260314c22ea0777d0a20a355a64e).

Fixing the last scenario (making JavaCompile cacheable with Kapt across different project locations) is pending on the following steps:
- Update our code base to Kotlin 1.2.51 or 1.2.60, whichever has the fixes for #20
- Enforce the above versions as minimum Kotlin version and remove Kapt workarounds from the AGP

This last fix might not make it to 3.2 stable (depending on how we want to prioritize it).

ja...@google.com <ja...@google.com> #23Jul 11, 2018 08:29AM

Thanks Hung! Both fixes are in 1.2.51 and 1.2.60. 1.2.51 stable is already available.

https://github.com/JetBrains/kotlin/blob/1.2.50/ChangeLog.md#1251

ta...@gmail.com <ta...@gmail.com> #24Jul 11, 2018 09:49AM

Please make it to 3.2, please make it to 3.2, pretty please.

hu...@google.com <hu...@google.com> #25Jul 18, 2018 11:56PM

Marked as fixed.

I'm happy to inform that we have fixed the last scenario, just in time for the 3.2 release: Starting with 3.2.0-rc-02, JavaCompile will be completely cacheable, with or without Kapt. Change-Id: I6ec2b168379de8c89bb0e56ff4fae4c84edcf2cd

Note to 3.3 canary users: It might take one or two canaries for the last fix to propagate to 3.3, ETA is 3.3.0-alpha-06.

lo...@gradle.com <lo...@gradle.com> #26Jul 19, 2018 07:02AM

This is excellent news indeed!

ta...@gmail.com <ta...@gmail.com> #27Jul 19, 2018 12:37PM

🎉🎉🎉

hu...@google.com <hu...@google.com> #28Aug 15, 2018 10:09PM

Update: This issue will be completely fixed in 3.2.0-rc01 and 3.3.0-alpha07.

[Deleted User] <[Deleted User]> #29Aug 26, 2019 12:10PM

nice

Message last modified on Aug 26, 2019 12:11PM

vi...@gmail.com <vi...@gmail.com> #30Mar 5, 2020 05:23AM