hide protected fields [76109329]

Fixed

Internal Cleanup

androidx-bug-bounty

Status Update

No update yet.

Description

yb...@google.com

created issue #1

Mar 21, 2018 09:16PM

ROomDatabase has protected mCallbacks field which is leaking in the API docs, we should @Hide it.

it is not intended for public use.

https://developer.android.com/reference/android/arch/persistence/room/RoomDatabase.html#mCallbacks

Comments

yb...@google.com <yb...@google.com> #2Mar 25, 2018 08:11PM

Feel free to disable the link check as a workaround.

The Gradle equivalent is:

android {
    lintOptions {
        disable "DialogFragmentCallbacksDetector"
    }
}

yb...@google.com <yb...@google.com> Jun 15, 2018 05:28PM

Reassigned to da...@google.com.

fl...@google.com <fl...@google.com> Jul 19, 2019 08:42AM

Reassigned to fl...@google.com.

fl...@google.com <fl...@google.com> Jul 19, 2019 02:01PM

Accepted by fl...@google.com.

yb...@google.com <yb...@google.com> #3Jul 30, 2020 09:01PM

Not all of our builds depend on androidx.fragment and if you do not use androidx.fragment and you add this disable flag, lint fails due to non-existant check DialogFragmentCallbacksDetector. If you do not plan on fixing this soon, I can try and see if we can only disable the check if we depend on androidx.fragment.

[Deleted User] <[Deleted User]> #4Aug 9, 2020 10:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 52b166175eabed99d14515190bfa0a7cea787004
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 16:11:44 2021

Fix OnCreateDialogIncorrectCallback lint on empty java classes

The OnCreateDialogIncorrectCallbackDetector lint rule currently checks
the first element of a list without verifying the item is actually
there. We should check if the item is null before we do anything else.

RelNote: "The `OnCreateDialogIncorrectCallbackDetector` no longer fails
on empty java classes/interfaces"
Test: java empty interface clean
Bug: 187524311

Change-Id: Iaff6c041370bd5a7c2ac8ef8c32a2e6f7a15e456

M fragment/fragment-lint/src/main/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetector.kt
M fragment/fragment-lint/src/test/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetectorTest.kt

https://android-review.googlesource.com/1702325

ap...@google.com <ap...@google.com> #5Aug 24, 2020 06:09PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.4.0-alpha01 release.