hide protected fields [76109329]

Fixed

Internal Cleanup

androidx-bug-bounty

Status Update

No update yet.

Description

yb...@google.com

created issue #1

Mar 21, 2018 09:16PM

ROomDatabase has protected mCallbacks field which is leaking in the API docs, we should @Hide it.

it is not intended for public use.

https://developer.android.com/reference/android/arch/persistence/room/RoomDatabase.html#mCallbacks

Comments

yb...@google.com <yb...@google.com> #2Mar 25, 2018 08:11PM

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

yb...@google.com <yb...@google.com> Jun 15, 2018 05:28PM

Reassigned to da...@google.com.

fl...@google.com <fl...@google.com> Jul 19, 2019 08:42AM

Reassigned to fl...@google.com.

fl...@google.com <fl...@google.com> Jul 19, 2019 02:01PM

Accepted by fl...@google.com.

yb...@google.com <yb...@google.com> #3Jul 30, 2020 09:01PM

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

[Deleted User] <[Deleted User]> #4Aug 9, 2020 10:54PM

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

ap...@google.com <ap...@google.com> #5Aug 24, 2020 06:09PM

Marked as fixed.

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!