Navigation destination Directions classes should extend their parent's Directions class if it exists [79871405]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

May 17, 2018 04:01AM

Component used: Navigation Safe Args
Version used: 1.0.0-alpha01

When using a global action (an action attached to a <navigation> element), all of the destinations under that <navigation> element should extend the <navigation> element's Directions class. This ensures that the final Directions object contains all of the valid actions from that destination on all levels of the navigation graph.

For example:
<navigation
xmlns:android="

http://schemas.android.com/apk/res/android"
xmlns:app="

http://schemas.android.com/apk/res-auto"
app:startDestination="@id/main_fragment">

<fragment
android:id="@+id/main_fragment"
android:name=".MainFragment">
<action
android:id="@+id/start_login"
app:destination="@id/login"/>
</fragment>
<navigation
android:id="@+id/login"
app:startDestination="@id/login_fragment">
<action
android:id="@+id/action_done"
app:popUpTo="@id/main_fragment"/>
<fragment
android:id="@+id/login_fragment"
android:name=".LoginFragment">
<action
android:id="@+id/register"
app:destination="@id/register_fragment"/>
</fragment>
<fragment
android:id="@+id/register_fragment"
android:name=".RegisterFragment">
</fragment>
</navigation>
</navigation>

There should be
- A LoginDirections class that has an action_done() method (this works right now).
- A LoginFragmentDirections class that extends LoginDirections (currently it does not extend anything)
- An empty RegisterFragmentDirections class that extends LoginDirections (currently it does not exist)

Comments

il...@google.com <il...@google.com> May 17, 2018 04:07PM

Assigned to se...@google.com.

il...@google.com <il...@google.com> Jul 18, 2018 06:10PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Aug 29, 2018 01:10AM

2016-08-26 10:20:09,235 [1279593] WARN - nal.AbstractExternalSystemTask - Could not get unknown property 'assembleRelease' for project ':auth' of type org.gradle.api.Project.
com.intellij.openapi.externalSystem.model.LocationAwareExternalSystemException: Could not get unknown property 'assembleRelease' for project ':auth' of type org.gradle.api.Project.
at org.jetbrains.plugins.gradle.service.project.AbstractProjectImportErrorHandler.createUserFriendlyError(AbstractProjectImportErrorHandler.java:103)
at org.jetbrains.plugins.gradle.service.project.BaseProjectImportErrorHandler.getUserFriendlyError(BaseProjectImportErrorHandler.java:158)
at org.jetbrains.plugins.gradle.service.project.BaseGradleProjectResolverExtension.getUserFriendlyError(BaseGradleProjectResolverExtension.java:579)
at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.getUserFriendlyError(AbstractProjectResolverExtension.java:158)
at com.android.tools.idea.gradle.project.AndroidGradleProjectResolver.getUserFriendlyError(AndroidGradleProjectResolver.java:405)
at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver$ProjectConnectionDataNodeFunction.fun(GradleProjectResolver.java:772)
at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver$ProjectConnectionDataNodeFunction.fun(GradleProjectResolver.java:752)
at org.jetbrains.plugins.gradle.service.execution.GradleExecutionHelper.execute(GradleExecutionHelper.java:238)
at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.resolveProjectInfo(GradleProjectResolver.java:112)
at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.resolveProjectInfo(GradleProjectResolver.java:73)
at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl$1.produce(RemoteExternalSystemProjectResolverImpl.java:41)
at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl$1.produce(RemoteExternalSystemProjectResolverImpl.java:37)
at com.intellij.openapi.externalSystem.service.remote.AbstractRemoteExternalSystemService.execute(AbstractRemoteExternalSystemService.java:59)
at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl.resolveProjectInfo(RemoteExternalSystemProjectResolverImpl.java:37)
at com.intellij.openapi.externalSystem.service.remote.wrapper.ExternalSystemProjectResolverWrapper.resolveProjectInfo(ExternalSystemProjectResolverWrapper.java:49)
at com.intellij.openapi.externalSystem.service.internal.ExternalSystemResolveProjectTask.doExecute(ExternalSystemResolveProjectTask.java:51)
at com.intellij.openapi.externalSystem.service.internal.AbstractExternalSystemTask.execute(AbstractExternalSystemTask.java:138)
at com.intellij.openapi.externalSystem.service.internal.AbstractExternalSystemTask.execute(AbstractExternalSystemTask.java:124)
at com.intellij.openapi.externalSystem.util.ExternalSystemUtil$3.execute(ExternalSystemUtil.java:419)
at com.intellij.openapi.externalSystem.util.ExternalSystemUtil$4$2.run(ExternalSystemUtil.java:500)

da...@google.com <da...@google.com> Aug 29, 2018 03:08AM

Marked as fixed.

Issue 79871405

Description

Issue summary

Comments

il...@google.com <il...@google.com> May 17, 2018 04:07PM

il...@google.com <il...@google.com> Jul 18, 2018 06:10PM

ap...@google.com <ap...@google.com> #2Aug 29, 2018 01:10AM

da...@google.com <da...@google.com> Aug 29, 2018 03:08AM

Add comment

Issue metadata