IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 05f347890c62aaf1f585b9adbbeb75832d3c8b2c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Mon Aug 27 17:05:17 2018

    Make Nav Direction classes extend top level Direction classes.
   
    Directions classes who's destination is contained in a nav graph with
    top level actions will now extend the nav graph's direction class
    enabling global actions to be available to lower layers of the graph.
   
    Bug: 79871405
    Test: ./gradlew :navigation:navigation-safe-args-generator:test
    Change-Id: Id59d8547dacb33c0d75ddd282754d87b499c2b9b

M       navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/GeneratorOutput.kt
M       navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavSafeArgsGenerator.kt
M       navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M       navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/ext/NavJavaPoet_ext.kt
M       navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M       navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M       navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
A       navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/TestUtils.kt
A       navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginDirections.java
A       navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginFragmentDirections.java
A       navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/MainFragmentDirections.java
A       navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/RegisterFragmentDirections.java
M       navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Finish.java
M       navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M       navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentDirections.java
M       navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M       navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/SanitizedMainFragmentArgs.java
M       navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/SanitizedMainFragmentDirections.java
A       navigation/safe-args-generator/src/tests/test-data/nested_login_test.xml
M       navigation/safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt

https://android-review.googlesource.com/739287
https://goto.google.com/android-sha1/05f347890c62aaf1f585b9adbbeb75832d3c8b2c

I believe I have found the potential problem that is causing this:
// @ androidx.navigation.NavController
// line 124

    // Now record the pop operation that we were sent
    if (!mBackStack.isEmpty()) {
        mBackStack.removeLast();
    }
    // We never want to leave NavGraphs on the top of the stack
    while (!mBackStack.isEmpty()
            && mBackStack.peekLast() instanceof NavGraph) {
        popBackStack();
    }

the condition in while loop is never satisfied because of the above `if` statement above it has already removed the last item of the mBackStack (which was the NavGraph) and thus popBackStack() is never called again.

According to Ian Lake, NavigationUI does not support up navigation yet, that is why this is a feature request.

+Pedro Varela - we don't support navigating up through activities as part of NavigationUI yet, please star the feature request: https://issuetracker.google.com/issues/79993862 (this issue)

Ian Lake said Up navigation is not supported through activities, only through fragments.

With the introduction of AppBarConfiguration, this is now possible with the setupActionBarWithNavController method by using an empty set of top level destinations (to always show the up button) and then overriding onSupportNavigateUp() as per the documentation: https://developer.android.com/topic/libraries/architecture/navigation/navigation-ui#action_bar

I'll leave this bug open as we still need an equivalent API for the Toolbar versions.

https://android-review.googlesource.com/846338 adds a setFallbackOnNavigateUpListener method on AppBarConfiguration that allows you to register an OnNavigateUpListener to handle cases where navController.navigateUp() return false.

This allows you to call onSupportNavigateUp() (or super.onSupportNavigateUp() if you're using an ActionBar) from that method to have your Up button transition between activities.

This will be available in 1.0.0-alpha09.

There is Jarks when implementing this way to navigate up between activities.