[Feature request] Support up button behaviour across multiple activities for navigation component [79993862]

Fixed

Feature Request

Status Update

No update yet.

Description

ne...@gmail.com

created issue #1

May 18, 2018 11:07PM

Component used: Navigation
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: -

Overriding onSupportNavigateUp() helps with the up button behaviour in the navigation architecture components, which is great. However if you have multiple activities the up button does not navigate up to the previous activity. It would be great if it would support that, especially for the migration to the navigation component.

Comments

il...@google.com <il...@google.com> May 25, 2018 08:26PM

Assigned to il...@google.com.

pe...@gmail.com <pe...@gmail.com> #2Jul 22, 2018 10:02PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

[Deleted User] <[Deleted User]> #3Jul 26, 2018 05:15PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

pe...@gmail.com <pe...@gmail.com> #4Jul 26, 2018 06:11PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

da...@gmail.com <da...@gmail.com> #5Jul 27, 2018 09:21AM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

il...@google.com <il...@google.com> #6Dec 10, 2018 05:53PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

il...@google.com <il...@google.com> Dec 10, 2018 09:56PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #7Dec 13, 2018 11:56PM

Marked as fixed.

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

su...@gmail.com <su...@gmail.com> #8Sep 13, 2022 09:34AM

Thank you, I'll try it and check.