[Feature request] Support up button behaviour across multiple activities for navigation component [79993862]

Fixed

Feature Request

Status Update

No update yet.

Description

ne...@gmail.com

created issue #1

May 18, 2018 11:07PM

Component used: Navigation
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: -

Overriding onSupportNavigateUp() helps with the up button behaviour in the navigation architecture components, which is great. However if you have multiple activities the up button does not navigate up to the previous activity. It would be great if it would support that, especially for the migration to the navigation component.

Comments

il...@google.com <il...@google.com> May 25, 2018 08:26PM

Assigned to il...@google.com.

pe...@gmail.com <pe...@gmail.com> #2Jul 22, 2018 10:02PM

since these are in public API (:/) we need to do this in 1.2

[Deleted User] <[Deleted User]> #3Jul 26, 2018 05:15PM

since it is already marked as deprecated, we can probably do it by now.

pe...@gmail.com <pe...@gmail.com> #4Jul 26, 2018 06:11PM

Opening diff shortly

da...@gmail.com <da...@gmail.com> #5Jul 27, 2018 09:21AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

il...@google.com <il...@google.com> #6Dec 10, 2018 05:53PM

With the introduction of AppBarConfiguration, this is now possible with the setupActionBarWithNavController method by using an empty set of top level destinations (to always show the up button) and then overriding onSupportNavigateUp() as per the documentation:

https://developer.android.com/topic/libraries/architecture/navigation/navigation-ui#action_bar

I'll leave this bug open as we still need an equivalent API for the Toolbar versions.

il...@google.com <il...@google.com> Dec 10, 2018 09:56PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #7Dec 13, 2018 11:56PM

Marked as fixed.

https://android-review.googlesource.com/846338 adds a setFallbackOnNavigateUpListener method on AppBarConfiguration that allows you to register an OnNavigateUpListener to handle cases where navController.navigateUp() return false.

This allows you to call onSupportNavigateUp() (or super.onSupportNavigateUp() if you're using an ActionBar) from that method to have your Up button transition between activities.

This will be available in 1.0.0-alpha09.

su...@gmail.com <su...@gmail.com> #8Sep 13, 2022 09:34AM

There is Jarks when implementing this way to navigate up between activities.