Fixed
Status Update
Comments
gu...@gmail.com <gu...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
il...@google.com <il...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
gu...@gmail.com <gu...@gmail.com> #4
Opening diff shortly
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: One Plus X (Android 6.0.1) / Galaxy Tab S2 (Android 7.0)
I'm building a PendingIntent from a widget (and also from a notification) to deep link into my app like this:
val pendingIntent = NavDeepLinkBuilder(context).setGraph(R.navigation.nav_graph).setArguments(bundleOf(("A" to "B"))).setDestination(R.id.all_quotes_fragment).createPendingIntent()
When I click on my widget/notification it opens the app as expected. But as soon as the onSaveInstanceState is triggered my app is crashing (see enclosed logcat stacktraces).
I tried to make a new project to reproduce the issue but I can't reproduce it.
Note 1: If I remove the argument from the PendingIntent like below then I'm not having the crash anymore.
val pendingIntent = NavDeepLinkBuilder(context).setGraph(R.navigation.nav_graph).setDestination(R.id.all_quotes_fragment).createPendingIntent()
Note 2: I'm using the Facebook SDK in my app (com.facebook.android:facebook-android-sdk:4.33.0) and if I remove it then my app isn't crashing anymore even if i'm passing arguments to my PendingIntent.
It's a bit strange that just passing this Bundle (bundleOf(("A" to "B"))) make the app crashing.
Looking at the stacktrace it seems that there is an infinite recursion that could be the origin of the issue.
By the way, I'm not doing any state saving by my self.
I'll keep trying to reproduce the issue otherwise it'll be hard to dig this issue.