NavOptions launch document uses not recommended NEW_DOCUMENT flag [109806636]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jun 6, 2018 04:13PM

Component used: Navigation
Version used: 1.0.0-alpha01

NavOptions' launch document flag uses

https://developer.android.com/reference/android/content/Intent#FLAG_ACTIVITY_NEW_DOCUMENT which states: "The use of the activity attribute form of this, R.attr.documentLaunchMode, is preferred over the Intent flag described here. The attribute form allows the Activity to specify multiple document behavior for all launchers of the Activity whereas using this flag requires each Intent that launches the Activity to specify it."

This flag should specifically call out that the documentLaunchMode is recommended or removed (since it is not a general purpose flag and only for activity destinations).

Comments

il...@google.com <il...@google.com> Jun 6, 2018 04:14PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #2Jun 6, 2018 05:47PM

Marked as fixed.

The documentLaunchMode is indeed the recommended (and more flexible) way to set an activity to launch in a particular document, so we'll be deprecating the launchDocument flag in Navigation in alpha02 and removing it in a future alpha.

ma...@gmail.com <ma...@gmail.com> #3Oct 4, 2022 08:21PM

Comment has been deleted.

Message last modified on Oct 31, 2022 07:20PM

Issue 109806636

Description

Issue summary

Comments

il...@google.com <il...@google.com> Jun 6, 2018 04:14PM

il...@google.com <il...@google.com> #2Jun 6, 2018 05:47PM

ma...@gmail.com <ma...@gmail.com> #3Oct 4, 2022 08:21PM

Add comment

Issue metadata