setPopUpTo does not work as expected with first destination in graph and inclusive = true [109909461]

Fixed

Bug

Status Update

No update yet.

Description

ke...@gmail.com

created issue #1

Jun 9, 2018 04:55PM

Component used: Navigation
Version used: alpha02
Devices/Android versions reproduced on: Nexus 5 6.0

I have 3 fragments in my navigation graph. My goal is to navigate away from the first fragment and remove it from the backstack so that it is not reachable by pressing the back button. This works for any fragment that is not the first destination in the graph by calling setPopUpTo([destination], true) on NavOptions.Builder(), but it does not work when [destination] is the first destination in the graph. In the latter case, the first destination never gets popped.

Note: This was working with setClearTask(true) in alpha01.

MyApplication.zip

19 MB

Download

Comments

al...@gmail.com <al...@gmail.com> #2Jun 10, 2018 04:41AM

since these are in public API (:/) we need to do this in 1.2

[Deleted User] <[Deleted User]> #3Jun 12, 2018 10:31AM

since it is already marked as deprecated, we can probably do it by now.

zb...@gmail.com <zb...@gmail.com> #4Jun 13, 2018 03:49PM

Opening diff shortly

il...@google.com <il...@google.com> Jun 20, 2018 05:17PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Jun 26, 2018 09:53PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #5Jun 27, 2018 04:45PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

ke...@gmail.com <ke...@gmail.com> #6Jul 3, 2018 03:48PM

Any update on when alpha03 will drop?

lb...@gmail.com <lb...@gmail.com> #7Sep 20, 2023 11:51PM

@5 Are you suggesting that the start Fragment would just check which Fragment to navigate to right away, such as login/permissions/onboarding, vs the rest?
This Fragment won't have any UI ..

Why this weird solution, instead of just setting a new root to the graph and switch to it?
If at some point, for example, a core permission was found not to be granted, we could set to switch to the permissions Fragment and make it the new root.
Or, if the user has chosen to logout, we could set to switch to the login Fragment and make it the new root.

What you suggest is to just pop all to the same Fragment, and let it choose instead?

da...@gmail.com <da...@gmail.com> #8Dec 7, 2023 09:10AM

Any news or updates? I change the startDestination and want to remove the first-started fragment, before go next. I can't do it. setPopUpTo doesn't work, popBackStack just closes the activity. From time to time I check the jetpack navigation - it becomes better, but it's still to raw. Old school navigation or Cicerone work simpler and better